Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SPMI to handle replays of BBINSTR jit method contexts #41386

Merged
merged 3 commits into from
Aug 27, 2020

Commits on Aug 26, 2020

  1. Fix SPMI to handle replays of BBINSTR jit method contexts

    Move the handling of allocMethodBlockCounts to the method context.
    While this data is both an input and an output, we're more interested
    in the input side.
    
    We could also treat it as an output, if we say wanted to verify that
    the replay jit wrote the same sequence of IL offsets into the BlockCount
    records, but that doesn't seem crucial as changes here would also lead
    to code diffs.
    
    Fix the code that checks the AddressMap for reloc hints so it doesn't
    fail if the exact lookup fails, but instead falls back to a search.
    This is needed because the base of the replay count buffer is recorded
    as the map key, but the instrumentation probes in jitted code refer
    to offsets from this value.
    
    Fixes dotnet#37270.
    AndyAyersMS committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    a6200d3 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2020

  1. update per feedback

    AndyAyersMS committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    204fe40 View commit details
    Browse the repository at this point in the history
  2. more feedback

    AndyAyersMS committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    d01c232 View commit details
    Browse the repository at this point in the history