Fix CA2021 in MethodBodyScanner

[MichalStrehovsky]

#80916 (comment) for context.

Cc @dotnet/ilc-contrib

[ghost]

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

---

#80916 (comment) for context.

Cc @dotnet/ilc-contrib

Author:	MichalStrehovsky
Assignees:	-
Labels:	area-NativeAOT-coreclr
Milestone:	-

[stephentoub]

Since OfType evaluation is lazy, this line is a nop (other than a null check on compilerGeneratedCallees). Presumably you could comment it out to go along with the subsequent commented out lines?

[MichalStrehovsky]

That would work too. I went with this because this file is a line-by-line port from IL Linker where it looks like this:

runtime/src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Dataflow/ReferenceSource/MethodBodyScanner.cs

Lines 254 to 259 in d92e70f

	var calleeMethods = compilerGeneratedCallees.OfType<MethodDefinition> ();
	// https://github.com/dotnet/linker/issues/2845
	// Disabled asserts due to a bug
	// Debug.Assert (interproceduralState.Count == 1 + calleeMethods.Count ());
	// foreach (var method in calleeMethods)
	// Debug.Assert (interproceduralState.Any (kvp => kvp.Key.Method == method));

(It's identical modulo the odd illinker rule to put a space between method name and parameter list. You can see where the MethodDefinition came from. It happened to compile here, but it's still the wrong type.)