Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NativeAOT-LLVM] Merge to Oct 24 #2720

Draft
wants to merge 321 commits into
base: feature/NativeAOT-LLVM
Choose a base branch
from
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Sep 25, 2024

  1. InlineArray design spec/doc (#108044)

    * Create InlineArrayAttribute.md
    
    * Update InlineArrayAttribute.md
    
    * about readonly field
    
    * On type layout
    
    * Update InlineArrayAttribute.md
    
    * On max size
    
    * make linter happy
    
    * more linter failures
    
    * linter failure (hopefully the last one)
    
    * small wording tweak
    
    * Apply suggestions from code review
    
    Co-authored-by: Jan Kotas <[email protected]>
    
    * Added a link to C# Inline Arrays, as an example where this is used.
    
    * Update InlineArrayAttribute.md
    
    * Default behavior of of Equals() and GetHashCode()
    
    ---------
    
    Co-authored-by: Jan Kotas <[email protected]>
    VSadov and jkotas authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    782c2ae View commit details
    Browse the repository at this point in the history
  2. Reduce funceval abort (#108220)

    Visual Studio reported that they were seeing unnecessary func-eval aborts. This was due to a lock ordering issue between CrstReadyToRunEntryPointToMethodDescMap and the coop mode transition. Flipping the ordering should fix the issue for this particular lock though it doesn't prevent any other lock from blocking func-evals. This should reduce, but not eliminate, the number of cases where func-eval abort is required.
    noahfalk authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    dee9010 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    080fcae View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bdcfb10 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    13fef94 View commit details
    Browse the repository at this point in the history
  6. Enable NuGet Audit and fix issues (#107639)

    * Enable NuGet Audit and fix issues
    
    Microsoft.NET.HostModel can reference the live builds of the packages
    it depends on.  These will be deployed by the SDK.�
    Most other audit alerts were due to tasks pulling in old dependencies
    that aren't even used by the task. Avoid these by cherry-picking
    just the assemblies needed by the tasks and provided by MSBuild / SDK.
    This prevents NuGet from downloading the package closure with the
    vulnerable packages.  We don't need those packages since the tasks
    aren't responsible for deploying them.  A better solution in the future
    would be a targeting pack for MSBuild and the .NET SDK - so that
    components that contribute to these hosts have a surface area they can
    target without taking on responsibility for servicing.
    
    There is once case where we have a test that references NuGet.* packages
    which also bring in stale dependencies that overlap with framework
    assemblies.  Avoid these by cherry-picking the NuGet packages in the
    same way.
    
    * Fix package path on linux
    
    * Only use live JSON from HostModel
    
    SDK pins S.R.M and a few others, so don't make them upgrade yet.
    
    * Add a couple missing assembly references
    
    * Refactor tasks dependencies
    
    Consolidate representation of msbuild-provided task dependencies
    
    * Fix audit warnings in tests
    
    * Remove MetadataLoadContext from WasmAppBuilder package
    
    * Update Analyzer.Testing packages
    
    * Reduce exposure of Microsoft.Build.Tasks.Core
    
    * Fix audit warnings that only occur on browser
    
    * Update Asn1 used by linker analyzer tests
    
    * React to breaking change in analyzer test SDK
    
    * Enable working DryIoc tests
    
    * Fix double-write when LibrariesConfiguration differs from Configuration
    
    * Fix LibrariesConfiguration update target
    
    * Clean up references and add comments.
    
    * Make HostModel references private
    
    This ensures projects referenced will not be rebuilt by tests.
    
    This also means the HostModel package will not list these as references,
    but that's OK since the SDK provides them and this is not a shipping
    package.
    
    * Use ProjectReferenceExclusion to avoid framework project references
    
    On .NETCore we want to use the targeting pack and avoid rebuilding libs.
    
    * Update src/libraries/System.Runtime.InteropServices.JavaScript/tests/JSImportGenerator.UnitTest/JSImportGenerator.Unit.Tests.csproj
    
    Co-authored-by: Jeremy Koritzinsky <[email protected]>
    
    ---------
    
    Co-authored-by: Jeremy Koritzinsky <[email protected]>
    ericstj and jkoritzinsky authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    df76a01 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    04b2934 View commit details
    Browse the repository at this point in the history
  8. Enable GC double reporting detection (#107986)

    * Enable GC double reporting detection
    
    This change adds detection of double reporting of stack slots and
    registers during GC stack walk. The detection is disabled by default and
    can be enabled using the DOTNET_EnableGCHoleMonitoring env variable.
    
    If a double reporting is found, it triggers an assert in both release and
    debug builds of the runtime.
    
    * Reflect PR feedback
    
    * Allocate the hash table only when the monitoring is on
    
    * Address PR feedback
    
    * Reflect PR feedback
    janvorli authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    3227d4a View commit details
    Browse the repository at this point in the history
  9. Target .NET 10 / net10.0 (#106599)

    * Update dotnet10 feeds
    
    * Update hardcoded old TFM values
    
    * More hardcode updates and TFM checks
    
    * Updates and delete duplicate file in Bcl.Numerics
    
    * Linker stays on net9.0
    
    * Fix .NET SDK max supported version
    
    * Update apicompat sfx apicompat baseline file
    
    * Update Microsoft.NET.WebAssembly.Threading APICompat settings
    
    * Fix DiagnosticSource build
    
    * Update SDK to RC1 for needed GetAlternateLookup API
    
    to be able to build System.Text.Json on net9.0.
    
    * Fix APICompat runtime regex pattern
    
    * Suppress Bcl.Memory compatibility error for dropped framework
    
    * Fix BinaryFormatter tests regex pattern for version subsitution
    
    * Update BinaryFormatterTests.cs
    
    * Pin SdkVersionForWorkloadTesting to the version in global.json
    
    * Treat net9 and net10 as current for now
    
    * Bump MicrosoftDotNetILCompilerVersion
    
    * Update BinaryFormatterTests.cs
    
    * Update System.Resources.Extensions
    
    * Update AutoImports as well
    
    * Fix ImporterTests.cs
    
    * Block failing SignalRClientTests
    
    * Update XmlSerialzation Schema Import tests.
    
    * Update Versions.props
    
    * Update CompatibilitySuppressions.xml for System.Numerics.Tensors
    
    * Don't set EnableDefaultCompileItems, it doesn't work since we set EnableDefaultItems=false higher up
    
    * Update regex in legacy BinaryFormatterTests.cs too
    
    * Hardcode BinaryFormatter test assembly version to 9.0
    
    This allows us to not change the majority of the tests
    
    * Fix typo
    
    * Fix issue in Microsoft.NET.Workload.Mono.Toolchain.Current.Manifest.pkgproj
    
    * Replace ForceNet8Current in a few more places
    
    * Fix wasi workload
    
    * Fix TreatAsCurrent for 10.0
    
    * Add net9 workload manifests
    
    * Update PackageId in icrosoft.NET.Runtime.WebAssembly.Templates.csproj
    
    * Update ApiCompatBaseline.NetCoreAppLatestStable.xml
    
    Changes from dotnet/runtime#107758
    
    * Remove duplicate dotnet10 feeds from nuget.config
    
    * Update Versions.props
    
    * Fake SDK band version for now
    
    * Update Versions.props
    
    * Update the SDK band versions for real
    
    * Update the dotnet/sdk dependencies
    
    * Update emsdk to net10 workloads
    
    * Install a 9.0 runtime for workload tests too
    
    * Update the compat tasks
    
    * Merge in changes from net10-manifests
    
    * Tmp: Trying out @am11's branch.
    
    * Tmp2: Trying out @am11's branch.
    
    * Tmp3: Replace the last usage of main in clone action.
    
    * Update eng/pipelines/coreclr/templates/build-perf-bdn-app.yml
    
    Co-authored-by: Adeel Mujahid <[email protected]>
    
    * Update eng/pipelines/coreclr/templates/perf-job.yml
    
    Co-authored-by: Adeel Mujahid <[email protected]>
    
    * Update eng/pipelines/runtime-wasm-perf.yml
    
    Co-authored-by: Adeel Mujahid <[email protected]>
    
    ---------
    
    Co-authored-by: Larry Ewing <[email protected]>
    Co-authored-by: Jackson Schuster <[email protected]>
    Co-authored-by: Alexander Köplinger <[email protected]>
    Co-authored-by: Ilona Tomkowicz <[email protected]>
    Co-authored-by: Steve Molloy <[email protected]>
    Co-authored-by: Adeel Mujahid <[email protected]>
    7 people authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c4b3d81 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    3baa42e View commit details
    Browse the repository at this point in the history
  11. [main] Update dependencies from dotnet/arcade (#108182)

    * Update dependencies from https://github.com/dotnet/arcade build 20240923.2
    
    Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
     From Version 10.0.0-beta.24467.1 -> To Version 10.0.0-beta.24473.2
    
    * Update dependencies from https://github.com/dotnet/arcade build 20240924.1
    
    Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
     From Version 10.0.0-beta.24473.2 -> To Version 10.0.0-beta.24474.1
    
    ---------
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    845e9a3 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    cf165a7 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    d6ac24c View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    335b1a9 View commit details
    Browse the repository at this point in the history
  15. [main] Update dependencies from dotnet/cecil, dotnet/hotreload-utils,…

    … dotnet/icu, dotnet/source-build-externals (#108183)
    
    * Update dependencies from https://github.com/dotnet/icu build 20240923.1
    
    Microsoft.NETCore.Runtime.ICU.Transport
     From Version 10.0.0-alpha.1.24466.3 -> To Version 10.0.0-alpha.1.24473.1
    
    * Update dependencies from https://github.com/dotnet/hotreload-utils build 20240923.1
    
    Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
     From Version 10.0.0-alpha.0.24466.1 -> To Version 10.0.0-alpha.0.24473.1
    
    * Update dependencies from https://github.com/dotnet/cecil build 20240923.1
    
    Microsoft.SourceBuild.Intermediate.cecil , Microsoft.DotNet.Cecil
     From Version 0.11.5-alpha.24467.1 -> To Version 0.11.5-alpha.24473.1
    
    * Update dependencies from https://github.com/dotnet/source-build-externals build 20240923.2
    
    Microsoft.SourceBuild.Intermediate.source-build-externals
     From Version 10.0.0-alpha.1.24466.1 -> To Version 10.0.0-alpha.1.24473.2
    
    ---------
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a16e0d5 View commit details
    Browse the repository at this point in the history
  16. Update dependencies from https://github.com/dotnet/roslyn build 20240…

    …923.3 (#108191)
    
    Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
     From Version 4.12.0-3.24470.11 -> To Version 4.12.0-3.24473.3
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f2dfbf5 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    7c85cee View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Configuration menu
    Copy the full SHA
    79a71fc View commit details
    Browse the repository at this point in the history
  2. Delete dead code (#108265)

    jkotas authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    19da949 View commit details
    Browse the repository at this point in the history
  3. ARM64: Fix lsra for AdvSimd_LoadAndInsertScalar (#107786)

    * ARM64: Fix lsra for AdvSimd_LoadAndInsertScalar
    
    * Fix comment
    
    * Expand LoadAndInsertScalar testing
    
    * Only delayfree when register types match
    
    * fix formatting
    
    * Fix comment
    
    * Check that multiregister nodes use fp registers
    
    * Revert rmw assert
    a74nh authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    d22c74d View commit details
    Browse the repository at this point in the history
  4. Bring back Microsoft.BCL.Memory netstandard2.1 facade (#108245)

    * Bring back Microsoft.BCL.Memory netstandard2.1 facade
    
    * Reorder TargetFrameworks
    
    Co-authored-by: Larry Ewing <[email protected]>
    
    ---------
    
    Co-authored-by: Larry Ewing <[email protected]>
    ericstj and lewing authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    dfc3310 View commit details
    Browse the repository at this point in the history
  5. Fix handling of appending keywords to boolean schemas. (#108246)

    * Fix handling of appending keywords to boolean schemas.
    
    * Add a few comments documenting boolean schemas.
    eiriktsarpalis authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    931ea60 View commit details
    Browse the repository at this point in the history
  6. Fixing SetSlice, Reshape, TryCopyTo. (#107852)

    * working
    
    * comments from PR
    
    * can always reshape to self
    
    * fixed tests
    
    * comments from PR
    
    * fixing tests
    michaelgsharp authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    735a031 View commit details
    Browse the repository at this point in the history
  7. [mini] Don't use Unwind Backtrace on android-amd64 (#107615)

    Match what we do for other android RIDs.
    
    The _Unwind_Backtrace support is only used when llvmonly mode is
    enabled, which is not something that we do for Android
    lambdageek authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    e4282ff View commit details
    Browse the repository at this point in the history
  8. Add test coverage for DirectoryServices.TransformControls (#107201)

    * Added tests for server response DirectoryControls
    
    * Addressing platform inconsistencies
    
    * There are looser rules in OpenLDAP when an octet string exceeds the length of its containing sequence.
    * Windows 8.1 and below treats trailing 0x80 bytes differently to every other platform.
    * Added a test which covers an octet string containing invalid Unicode bytes.
    
    * Handle differing .NET Framework behaviour
    
    Also handle changes to the "a" format string: Winldap in Windows 10 is stricter when a SEQUENCE's contents overflow its length
    
    * Update SortResponseControlTests.cs
    edwardneal authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    52a51e8 View commit details
    Browse the repository at this point in the history
  9. Update dependencies from https://github.com/dotnet/arcade build 20240…

    …925.5 (#108277)
    
    Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
     From Version 10.0.0-beta.24474.1 -> To Version 10.0.0-beta.24475.5
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    c5ec080 View commit details
    Browse the repository at this point in the history
  10. Update dependencies from https://github.com/dotnet/roslyn build 20240…

    …926.1 (#108280)
    
    Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset
     From Version 4.12.0-3.24473.3 -> To Version 4.12.0-3.24476.1
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    3bf0029 View commit details
    Browse the repository at this point in the history
  11. Update dependencies from https://github.com/dotnet/cecil build 202409…

    …25.1 (#108279)
    
    Microsoft.SourceBuild.Intermediate.cecil , Microsoft.DotNet.Cecil
     From Version 0.11.5-alpha.24473.1 -> To Version 0.11.5-alpha.24475.1
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    f8b6dc7 View commit details
    Browse the repository at this point in the history
  12. Update dependencies from https://github.com/dotnet/emsdk build 202409…

    …24.1 (#108278)
    
    Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport
     From Version 10.0.0-alpha.1.24468.9 -> To Version 10.0.0-alpha.1.24474.1
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    c4ebd38 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    1990f08 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    9d9c64d View commit details
    Browse the repository at this point in the history
  15. [cdac][tests] Make it easier to set up a unit test (#108288)

    We used to stackalloc a lot of data because the Target callback had to be an UnmanagedCallersOnly function pointer. But now it's just a delegate. So we can heap allocate the mock memory space and get rid of a bunch of incidental fixed statements
    We used to spell out the JSON contract descriptor in every test case. We dont' need to do that - most tests are not testing parsing. Hide all that stuff in MockMemorySpace.Builder
    
    * make MockMemorySpace.ReadContext a class
    
       Now that Target's reader callback is just a normal managed delegate, we don't have a lot of reason to make the testing ReadContext a ref struct.  So simplify our resource usage and just store the descriptors and json as heap allocated arrays
    
    * remove uses of fixed in tests
    
       The ReadContext for the  tests keeps a copy of the json payload, we don't need to use unmanaged pointers
    
    * make the MockMemorySpace.Builder a normal class
    
       we don't hold pointers to span data anymore
    
    * make MockMemorySpace.ReadContext private
    
    * begin hiding ContractDescriptorFill
    
       most of our tests that use a valid contract descriptor don't need to repeat the boilerplate to fill it in
    
    * start removing json and pointer data boilerplate
    
    * Don't fill the pointer data when there isn't any
    
       We previously did the wrong thing with TargetTestHelpers.MakeGlobalJson: it always filled in direct values.  So technically filling in the pointer data in all the other tests is unnecessary.
    
       Add a second SetGlobals overload for the builder that takes a 4-tuple (either ulong? Value or uint IndirectIndex) and a second collection of actual values for the indices.
    
    * remove unused MockMemorySpace.Builder functions
    
       everything is using high level construction now
    
    * remove unneeded stackalloc
    
    * describe test addresses
    lambdageek authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    fdc9e54 View commit details
    Browse the repository at this point in the history
  16. [cdac-build-tool] don't embed resources (#108293)

    reviously we used EmbeddedResource to collect the contract descriptor baselines into cdac-build-tool and we also embedded the C source template.
    
    But we only ever run cdac-build-tool during the runtime build - the files are in the same source tree. Just pass their paths when invoking the tool, don't embed them.
    
    Fixes #107958 
    
    * don't embed baselines into cdac-build-tool
    
    * don't embed the template source file in the tool
    lambdageek authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    9b56e73 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Remove HelperMethodFrame from Delegate construction (#108217)

    * Remove HelperMethodFrame from Delegate construction
    AaronRobinsonMSFT authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    c20bdf6 View commit details
    Browse the repository at this point in the history
  2. Root the System.Runtime EventSource (#108266)

    Root the System.Runtime EventSource
    
    The System.Runtime EventSource (RuntimeEventSource), was unintentionally being garbage collected because it wasn't rooted. This caused runtime EventCounters to no longer be available after GC occurred.
    
    This was a regression from a recent change (dotnet/runtime#106014). That change accidentally converted the static field that was intended to the root the object into a property getter that returned a new instance each time it was called. This fix converts the property back to being initialized only once.
    
    This will fix #107919 once it is backported.
    
    Co-authored-by: Tarek Mahmoud Sayed <[email protected]>
    noahfalk and tarekgh authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    69de6dd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    84b7c2f View commit details
    Browse the repository at this point in the history
  4. [wasm] Change ICU WasmBuildTests to use wasmconsole and `wasmbrow…

    …ser` templates (#108271)
    
    * Clean up icu tests (automatic mode).
    
    * Block the failing test, mark problems with issue links.
    ilonatommy authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    01aa3d9 View commit details
    Browse the repository at this point in the history
  5. [iOS] Enable and disable tests for hybrid globalization on Apple (#10…

    …8187)
    
    Enable and disable tests for hybrid globalization on Apple
    mkhamoyan authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    c315bac View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8699505 View commit details
    Browse the repository at this point in the history
  7. Fix statics issue with barriers (#108311)

    * Fix statics issue with barriers
    
    * Add barriers for RiscV and Loongson
    davidwrighton authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    2fcc09b View commit details
    Browse the repository at this point in the history
  8. Fix build-runtime-tests-and-send-to-helix auth for internal PRs (#107…

    …635)
    
    * Fix build-runtime-tests-and-send-to-helix auth for internal PRs
    * Update build-runtime-tests-and-send-to-helix.yml
    hoyosjs authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    b3a113a View commit details
    Browse the repository at this point in the history
  9. fix guid version > 7 (#108314)

    * fix guid version > 7
    
    * Update src/libraries/System.Runtime/tests/System.Runtime.Tests/System/GuidTests.cs
    kasperk81 authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    a2291e9 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. JIT: refactor AddCodeDsc (#108095)

    The main aim of this change is to remove the block reference from AddCodeDsc,
    as it can become stale over time, making it impossible to determine where
    a throw helper block should be placed, if we have subsequently eliminated
    EH regions.
    
    Instead we use the try/handler indices plus a bit of extra info to
    track where the throw helper block should be placed.
    
    I also moved the key formation logic nearby and reworked it a bit, and
    gave the AddCodeDscs debug indices for dumps.
    
    This should unblock doing late EH region removal.
    AndyAyersMS authored Sep 28, 2024
    Configuration menu
    Copy the full SHA
    4a99ef1 View commit details
    Browse the repository at this point in the history
  2. Convert ReflectionInvocation.CanValueSpecialCast() to managed (#108…

    …305)
    
    ---------
    
    Co-authored-by: Aleksey Kliger (λgeek) <[email protected]>
    AaronRobinsonMSFT and lambdageek authored Sep 28, 2024
    Configuration menu
    Copy the full SHA
    3fd7b0f View commit details
    Browse the repository at this point in the history
  3. Fix the QCall contract for GC suppression. (#108344)

    * Fix the QCall contract for GC suppression.
    
    * Remove QCALL_BEGIN/END from method
    AaronRobinsonMSFT authored Sep 28, 2024
    Configuration menu
    Copy the full SHA
    7c69e7d View commit details
    Browse the repository at this point in the history
  4. Fix handling of IDynamicInterfaceCastable wrt CastCache (#108328)

    Fixes #108229.
    
    The actual fix is the addition of an `if` check where it originally wasn't. I also fixed the other checks for consistency - positive checks are fine to cache, and negative checks against non-interface targets are also fine to cache.
    MichalStrehovsky authored Sep 28, 2024
    Configuration menu
    Copy the full SHA
    ba9b3ba View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Configuration menu
    Copy the full SHA
    3d9334c View commit details
    Browse the repository at this point in the history
  2. [main] Update dependencies from dotnet/xharness (#108184)

    * Update dependencies from https://github.com/dotnet/xharness build 20240923.1
    
    Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
     From Version 10.0.0-prerelease.24467.4 -> To Version 10.0.0-prerelease.24473.1
    
    * Update dependencies from https://github.com/dotnet/xharness build 20240926.1
    
    Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
     From Version 10.0.0-prerelease.24473.1 -> To Version 10.0.0-prerelease.24476.1
    
    ---------
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    Co-authored-by: Larry Ewing <[email protected]>
    3 people authored Sep 29, 2024
    Configuration menu
    Copy the full SHA
    4c53afd View commit details
    Browse the repository at this point in the history
  3. NativeAOT Thread Name (#107943)

    Co-authored-by: Jan Kotas <[email protected]>
    cshung and jkotas authored Sep 29, 2024
    Configuration menu
    Copy the full SHA
    2917e51 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Fix IDynamicInterfaceCastable with shared generic code (#108235)

    Fixes #72909.
    
    Internal team ran into this. Turns out CsWinRT also needs this, but they're were working around instead pushing on a fix.
    
    The big problem with this one is that we have an interface call to a default interface method that requires generic context. This means we need some kind of instantiating thunk (since callsite didn't provide generic context because it didn't know it). The normal default interface case uses an instantiating thunk that simply indexes into the interface list of `this`. We know the index of the interface (we don't know the concrete type because `T`s could be involved), but we can easily compute it at runtime from `this`.
    
    The problem with `IDynamicInterfaceCastable` is that `this` is useless (the class doesn't know anything about the interface). So we need to get the generic context from somewhere else. In this PR, I'm using the thunkpool as "somewhere else". When we finish interface lookup and find out `IDynamicInterfaceCastable` provided a shared method, we create a thunkpool thunk that stashes away the context. We then call the "default interface method instantiating thunk" and instead of indexing into interface list of `this`, we index into interface list of whatever was stashed away. So there are two thunks before we reach the point of executing the method body.
    MichalStrehovsky authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    98db53f View commit details
    Browse the repository at this point in the history
  2. [wasm] Dispose Xunit ToolCommand (#108319)

    * Make sure ToolCommand instances are disposed + do not log after the disposal. 
    with: @pavelsavara
    ilonatommy authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    c049b85 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    96be510 View commit details
    Browse the repository at this point in the history
  4. JIT: use bbID for pred list ordering (#108357)

    Make `bbID` available in release builds, and use it to control the order
    of edges in the pred list. This removes (almost all) the need for reordering
    pred lists when blocks are renumbered (`bbNum` changes, but `bbID` doesn't).
    
    Also remove the need for sorting pred lists; in the one remaining place
    where sorting might be needed, just remove, modify, and then re-add the edge.
    AndyAyersMS authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    70e4eb9 View commit details
    Browse the repository at this point in the history
  5. Move computation of DebuggerAssemblyControlFlags from DomainAssembly …

    …to Assembly (#107809)
    
    This moves the initial computation into `Assembly` and removes the flags from `DomainAssembly`. Actual consumers were already getting the flags off of `Assembly` or `Module`
    elinor-fung authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    9399533 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e720b9f View commit details
    Browse the repository at this point in the history
  7. Remove duplicate code in DiagnosticsHandler (#108012)

    There seems to be some redundant instrumentation code in `DiagnosticsHandler`, which this PR removes.
    stevejgordon authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    74b18d3 View commit details
    Browse the repository at this point in the history
  8. Update dependencies from https://github.com/dotnet/source-build-refer…

    …ence-packages build 20240923.1 (#108389)
    
    Microsoft.SourceBuild.Intermediate.source-build-reference-packages
     From Version 10.0.0-alpha.1.24467.1 -> To Version 10.0.0-alpha.1.24473.1
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    13e55a4 View commit details
    Browse the repository at this point in the history
  9. [cdac] break up cdacreader into 4 separate assemblies (#108156)

    Break up the monolithic cdacreader assembly into four parts:
    
    1. `Microsoft.Diagnostics.DataContractReader.Abstractions` just the API surface for contract implementations and clients. **Note**: everything is internal for now (with IVT for the other assemblies) - we're not committing to a public API surface yet
    2. `Microsoft.Diagnostics.DataContractReader.Contracts`: the concrete implementations of the contracts and data
    3. `Microsoft.Diagnostics.DataContractReader`: a concrete Target that ties everything together
    4. `cdacreader`: just the unmanaged entrypoints and the legacy DAC API surface `SOSDacImpl`
    
    To untangle things I had to add a new `IContractFactory<TContract>` interface - this is what the target's ContractRegistry uses to instantiate specific versions of contracts.
    
    Goals:
    
    * Make it possible to mock a Target and its ContractRegistry so that concrete contracts can be tested in isolation for example by making dummy dependent contracts that return canned answers.
    * Eventually make it possible to inject additional contract implementations into a ContractRegistry implementation
    Make it possible to consume just the Target and Contracts without the unmanaged entrypoints or the legacy interfaces
    
    
    Changes:
    * [cdac] break up cdacreader into 4 separate assemblies
    * rename the contract factories using libraries naming convention
    * removed unused usings
    * document all abstract Target members
    * rename Target -> ContractDescriptorTarget
    * Add ReadTargetPointerFromSpan to abstract Target
       Allows the TypeNameBuidler and SigFormat to depend on the abstract target
    * change SOSDacImpl to depend on the abstract Target
    * fixup filenames and namespaces
    lambdageek authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    a7e5426 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    eb78413 View commit details
    Browse the repository at this point in the history
  11. Enable IDynamicInterfaceCastable tests disabled on fixed bug (#108376)

    These had to be excluded in #108235 but #108328 fixed them in the meantime. One of these PRs might be serviced for .NET 9 and the other may not, so I'm just reenabling this in a separate PR to make backports easier.
    MichalStrehovsky authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e690777 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    a0790e9 View commit details
    Browse the repository at this point in the history
  13. JIT: remove some unnecessary DONT_REMOVE block flags (#108405)

    When we clone a finally or remove an empty try, the cloned handler
    entry or former try region entry no longer need special protection.
    AndyAyersMS authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    7b1e788 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Add comments to host error_codes.h (#107775)

    Include basic descriptions of host error codes in `error_codes.h`. Slight clean-up (and some renames) of some error codes - these are all failures with no expected programmatic recovery, so the value change should be fine:
    - Merged `LibHostCurExeFindFailure` with `CurrentHostFindFailure`
    - Merged `LibHostSdkFindFailure` with `SdkResolveFailure`
    - Merged `LibHostUnknownCommand` with `LibHostInvalidArgs`
    elinor-fung authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e9fa899 View commit details
    Browse the repository at this point in the history
  2. [mono] Set unwind table kind (#107462)

    * Set unwind table kind
    
    To stop hitting assert in the verbose output, when aot compiler is built
    with the debug configuration of llvm
    
    * Set synchronous uw table kind on arm64
    
    * Feedback
    radekdoulik authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    4f66989 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    44c9d13 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    008ee9f View commit details
    Browse the repository at this point in the history
  5. [Swift interop] Add inline array struct lowering tests (#107859)

    * [swift interop] Add inline array tests
    
    * Rename test suite
    jkurdek authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    d024a5b View commit details
    Browse the repository at this point in the history
  6. Remove AppDomain from DebugInterface Load/UnloadClass (#107808)

    Some more cases where we only have the one app domain and we don't need to pass it all over.
    elinor-fung authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e38e56a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fff9521 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    68d8478 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d726811 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    d95cbad View commit details
    Browse the repository at this point in the history
  11. remove dead code from BCL.cs (#108165)

    * remove dead code from BCL.cs
    
    * Update src/tools/illink/src/linker/Linker/BCL.cs
    
    * Update BCL.cs
    kasperk81 authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    2d2e703 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    82f8ac6 View commit details
    Browse the repository at this point in the history
  13. Fix devirtualization across genericness in the hierarchy (#108442)

    This code was trying to answer question: "Was this method overriden by something else in a more derived class"? It was walking the base hierarchy in canonical form, but that was leading to methods not resolving at all. The fix is to walk the non-canonical hierarchy and canonicalize after we resolved everything.
    
    I ran into this in #108379 that unlocked more whole program devirtualization and `StringSearchValuesBase` is in this shape.
    MichalStrehovsky authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e6d9f74 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Update System.Formats.Nrbf ref sources and restore package descriptio…

    …n (#108430)
    
    * Restore System.Formats.Nrbf package description alongside package README
    
    * Add missing struct members to ref source
    
    * Update ref to match dotnet msbuild /t:GenerateReferenceAssemblySource
    
    * Remove 'EnableDefaultPackageReadmeFile' since 'true' is the default
    jeffhandley authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    3ca4ec8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    50e8435 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8611665 View commit details
    Browse the repository at this point in the history
  4. JIT: Support for devirtualizing array interface methods (#108153)

    Update JIT and runtime to devirtualize interface calls on arrays
    over non-shared element types.
    
    Shared types are not (yet) handled.
    
    Add intrinsic and inlining attributes to key methods in the BCL.
    This allows the JIT to devirtualize and inline enumerator creation
    and devirtualize and inline all methods that access the enumerator.
    
    And this in turn allows the enumerator to be stack allocated in some
    simple cases.
    
    However, the enumerator fields are not (yet) physically promoted,
    because of an optimization in the BCL to return a static empty
    array enumerator. So the object being accessed later is ambiguous.
    
    Alse ensure that since GDV resolves the virtual call twice, and
    expects to get similar results both times, things work for the array
    case by keeping track of the initial devirtualization inputs.
    
    Progress towards #62457.
    AndyAyersMS authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    6906730 View commit details
    Browse the repository at this point in the history
  5. HttpListener fix: Operations that change non-concurrent collections m…

    …ust have exclusive access (#107804)
    pjannesen authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    0d86380 View commit details
    Browse the repository at this point in the history
  6. Add instructions to debug CLI builds using VS (#108455)

    Adds instructions to use VS as a tool to debug CLI builds
    
    Previously the coreclr debugging docs only mentioned workflows for Visual Studio
    which involve using VS for both building and debugging. This adds an additional
    method to build using CLI scripts and use VS to only debug.
    
    Thank you @AaronRobinsonMSFT for showing me this method.
    max-charlamb authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    c2ba746 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7474054 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    81efcad View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Remove HelperMethodFrames (HMF) from Reflection code paths (#108415)

    Convert RuntimeTypeHandle.AllocateComObject() to QCall.
    Convert RuntimeFieldHandle.GetValue() to QCall.
    Remove FCThrow from RuntimeFieldHandle.GetToken().
    Convert RuntimeFieldHandle.SetValue() to QCall.
    Convert RuntimeTypeHandle.IsInstanceOfType() to fast/slow paths.
    Convert RuntimeHelpers.PrepareDelegate() to QCall.
    Convert ReflectionInvocation.InvokeDispMethod() to QCall.
    Convert RuntimeType.get_GUID to QCall.
    AaronRobinsonMSFT authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    a38ab4c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2358c59 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c60288e View commit details
    Browse the repository at this point in the history
  4. Allow devirt into abstract classes if we saw a non-abstract child (#1…

    …08379)
    
    We avoid devirtualizing into abstract classes because whole program view might have optimized away the method bodies and devirtualizing them doesn't lead to anything good.
    
    However, if the whole program view had a non-abstract child of this, we can no longer optimize this out and devirtualization should be fine.
    
    Fixes issue encountered in dotnet/runtime#108153 (comment)
    MichalStrehovsky authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    b4c820c View commit details
    Browse the repository at this point in the history
  5. Obsolete ExchangeAlgorithmType, CipherAlgorithmType and HashAlgorithm…

    …Type and their usage (#105875)
    
    * Obsolete KeyExchangeAlgorithm, KeyExchangeStrength, CipherAlgorithm, CipherAlgorithmStrength, HashAlgorithm and HashStrength properties of SslStream.
    
    * Fix build of S.N.S
    
    * Tentatively unobsolete enum types
    
    * Revert "Tentatively unobsolete enum types"
    
    This reverts commit f5f6435b9d03d39c37f6d9de948c421a28f88428.
    
    * Obsolete other usages of enums
    
    * 9.0
    
    * Suppressions
    
    * Change #ifdef checks to 10.0
    
    * Update compatibility suppressions
    
    * Regenerated suppresions
    
    * Fix build
    
    ---------
    
    Co-authored-by: wfurt <[email protected]>
    rzikm and wfurt authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    49399d9 View commit details
    Browse the repository at this point in the history
  6. Interpreter Fixes (#108485)

    Co-authored-by: Aaron Robinson <[email protected]>
    cshung and AaronRobinsonMSFT authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    7a4678f View commit details
    Browse the repository at this point in the history
  7. Fix wrong Region Info Names (#108466)

    * Fix wrong RegionInfo Names
    
    * Exclude the test on Windows 8 for the lack of full globalization data
    tarekgh authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    dff678d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    76772d4 View commit details
    Browse the repository at this point in the history
  9. Added DateOnly overload methods to IsoWeek (#108479)

    * Added DateOnly overload methods to IsoWeek
    
    * Updated reference assembly
    
    * Added documentation comments to IsoWeek DateOnly API
    
    * Added IsoWeek DateOnly tests
    
    * Consolidated IsoWeek tests
    
    * Changed IsoWeek DateOnly test names
    leonluc-dev authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    95428f9 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b3e8c3c View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    b9ffdb0 View commit details
    Browse the repository at this point in the history
  12. Update field references in property accessors (#108413)

    * Update field references in property accessors
    
    * Update field references
    
    * Use @
    
    * Rename field
    
    ---------
    
    Co-authored-by: Stephen Toub <[email protected]>
    cston and stephentoub authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    f428917 View commit details
    Browse the repository at this point in the history
  13. JIT: move funclet separation later (#108456)

    Defer funclet separation until after we've run the optimization phases.
    This is a prerequisite for introducing a late EH opts phase that will
    remove now-empty finallies or faults.
    
    Also update `fgNewBBAtTryRegionEnd` so that the new block's enclosing region
    is the try, not some handler region nested within the try (we see this
    case now during loop canonicalization, because we haven't yet moved the
    handlers).
    AndyAyersMS authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    48355da View commit details
    Browse the repository at this point in the history
  14. JIT: remove fgAddCodeList (#108527)

    AddCodeDscs are currently kept in both a linked list and in a hash map.
    Since the order of these descriptors is not important, remove the list
    and use map iterators to enumerate them.
    
    This makes it easier to remove ACDs.
    AndyAyersMS authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    b2c8aa2 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Reduce differences between bash and cmd versions of crossgen test scr…

    …ipt (#108500)
    
    * Reduce differences between bash and cmd versions of crossgen test script
    * Fix bash crossgen runner script not passing full file list in composite mode
    * Clean up shellcheck warnings
    kg authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f05bfc4 View commit details
    Browse the repository at this point in the history
  2. Networking stress tests infrastructure improvements. (#108325)

    * Update HttpStress
    
    * !fixup Uncomment
    
    * Fix linux build-docker-sdk script
    
    * Fix linux scripts
    
    * Create artifact folders on windows
    
    * Fixes
    
    * fix permissions on bash scripts
    
    * Apply same changes to SslStress
    
    * revert some changes
    
    * Improve build-local scripts
    
    * Update SslStress
    
    * Update sslstress yml files
    
    * !fixup
    
    * mkdir -p in yaml
    
    * Revert cli arg change
    
    * Reference original envvars
    
    * code review changes
    rzikm authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    2c5b609 View commit details
    Browse the repository at this point in the history
  3. Improve software exception handling performance (#108480)

    * Improve software exception handling performance
    
    I have recently discovered that large part of the time spent in the EH
    while handling software exception is in the RtlLookupFunctionEntry
    Windows API. That API is called when unwinding native (non-managed)
    frames on stack. The current implementation of the IL_Throw JIT helper
    that is used to throw managed exceptions needs three unwinds to get to
    the managed caller. Due to the two passes of EH, it means there are six
    calls made to that API per throw.
    This change reduces that to just a single unwind, which leads to about
    12% improvement in single threaded scenarios and about 30% improvement
    in multi threaded one for a case when an exception is thrown over 10
    managed frames and then caught. It also leads to similar improvements in
    async exception handling performance. On Linux, the multi-threaded gain is much higher,
    I've measured 3 fold improvement.
    
    An additional benefit of this change is removal of the helper method
    frame from IL_Throw and IL_Rethrow, which contributes to the current
    effort of getting rid of the helper method frames.
    
    I have made this change for the new EH only.
    janvorli authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    1fa1745 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4da2465 View commit details
    Browse the repository at this point in the history
  5. Add build-time check for unwind proc_info_in_range (#108250)

    * Add build-time check for unwind proc_info_in_range
    
    * Fix windows build
    am11 authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    faaba7f View commit details
    Browse the repository at this point in the history
  6. Fix flag assignment in pal_termios (#108409)

    * Use bitwise OR when setting IGNBRK in pal_termios
    
    * Address feedback
    am11 authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a7f96cb View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4bf7a2b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    fce7c7d View commit details
    Browse the repository at this point in the history
  9. Trim analyzer: fix member reported for generic warning (#108528)

    Fixes an incorrect member reported for warning due to RUC member
    kept by new constraint. Also adds a testcase for
    dotnet/runtime#108507, but doesn't fix
    that issue.
    sbomer authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    8d85ada View commit details
    Browse the repository at this point in the history
  10. Fix ILLink behavior for modreq types (#108494)

    Cecil represents modreq/modopt in signatures as part of the
    TypeReference (using subclasses
    RequiredModifierType/OptionalModifierType). We need to unwrap
    these to get the correct behavior in IsNamedType.
    
    This fixes the `IsTypeInterestingForDataflow` check for
    modreq/modopt types (`Type modreq(IsVolatile)` should be
    considered interesting for dataflow, and `Type[]
    modreq(IsVolatile)` should not). Includes a similar fix for
    function pointers.
    sbomer authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    e183f70 View commit details
    Browse the repository at this point in the history
  11. ILLink: Avoid warning for RUC field rooted as part of a root assembly…

    … (#108498)
    
    Similar to dotnet/runtime#81864, fields
    in a RUC class are producing trim analysis warnings in the OOB
    trim step (the mentioned issue was specific to library mode, but
    it's also a problem for the normal root assembly mode).
    
    This extends the fix from
    dotnet/runtime#84620 to avoid producing
    warnings for fields that are marked just because an assembly was
    rooted. Arguably rooting an assembly _should_ warn about rooted
    RUC members, but that's not the case today for RUC methods, so
    this makes the behavior consistent for fields.
    
    ---------
    
    Co-authored-by: Jackson Schuster <[email protected]>
    sbomer and jtschuster authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    e67f230 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    0b0637e View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    0ab7efe View commit details
    Browse the repository at this point in the history
  14. [cdac] Tighten cdac_data friend declarations (#108525)

    tighten cdac_data friend declarations
    
    Previously classes exposed internals to all cdac_data specializations. By changing the
    friend declarations to the exact specialization which needs will access the internals,
    we can better verify where the internals are accessed and ensure cdac_data<T> accesses
    the correct class.
    max-charlamb authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    fd4d0a9 View commit details
    Browse the repository at this point in the history
  15. Fix IndexOf Optimization Code (#108499)

    * Fix IndexOf Optimization Code
    
    * small typo
    
    * Address the feedback
    
    * Exclude hybrid globalization runs on the new added tests
    tarekgh authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f1de7b0 View commit details
    Browse the repository at this point in the history
  16. linux/arm64: Verify TLS resolver code (#108419)

    * linux/arm64: Verify TLS resolver code
    
    * Move the flag at the top so customer can turn it off to get unblocked
    kunalspathak authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    ed05fa9 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. Configuration menu
    Copy the full SHA
    6160518 View commit details
    Browse the repository at this point in the history
  2. Update fuzzing infra to build and use the shared framework (#108555)

    * Update fuzzing infra to build and use the shared framework
    
    * Update deploy-to-onefuzz pipeline
    
    * Apply suggestions from code review
    
    Co-authored-by: Miha Zupan <[email protected]>
    
    ---------
    
    Co-authored-by: Miha Zupan <[email protected]>
    buyaa-n and MihaZupan authored Oct 5, 2024
    Configuration menu
    Copy the full SHA
    0372b50 View commit details
    Browse the repository at this point in the history
  3. Stored the initial capacity of the ConcurrentDictionary for correctly…

    … sizing the backing array after clearing the collection. (#108065)
    
    * Stored the initial capacity of the ConcurrentDictionary for correctly sizing the backing array after clearing the collection.
    
    * Stored the capacity in the ctor.
    * Used the stored capacity in Clear().
    
    Fixes #107016
    
    * Added a test to check the capacity logic of the ConcurrentDictionary.
    koenigst authored Oct 5, 2024
    Configuration menu
    Copy the full SHA
    3bcaadb View commit details
    Browse the repository at this point in the history
  4. Use architecture independent code paths in Array (#108449)

    * Avoid architecture specific code path in Array.
    
    Check IntPtr.Size which should evaluate to constant/no-op by either the
    trimmer or the compiler.
    
    * Use goto to reuse existing code paths
    
    Co-authored-by: Jan Kotas <[email protected]>
    joncham and jkotas authored Oct 5, 2024
    Configuration menu
    Copy the full SHA
    48dbc4f View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. Configuration menu
    Copy the full SHA
    112ef3d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    438cf85 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Configuration menu
    Copy the full SHA
    f944a77 View commit details
    Browse the repository at this point in the history
  2. [RISC-V] Fix Int32 to Unsigned overflow check (#107024)

    * [RISC-V] Allowed CHECK_POSITIVE to have temporary register
    
    * [RISC-V] Fixed CHECK_POSITIVE in genIntCastOverflowCheck
    
    * [RISC-V] Improved J pseudoinstruction printing
    
    * [RISC-V] Added ret pseudoinstruction to disasm
    
    * [RISC-V] Fixed register type in disasm
    
    * [RISC-V] Fixed ins_Load
    
    * [RISC-V] Formatted code
    
    * [RISC-V] Fixed format bug
    
    * Revert "[RISC-V] Fixed ins_Load"
    
    This reverts commit 144629fb3f98ccbd817dbe3b5cd6d3f687ed942a.
    
    * [RISC-V] Fixed comment in codegenlinear
    
    * [RISC-V] Fixed sextw attribute type
    
    * [RISC-V] Simplified casts logic
    
    * [RISC-V] Improved CHECK_SMALL_INT_RANGE casts
    
    * [RISC-V] Optimized check int range
    
    * [RISC-V] Fixes in codegenriscv64
    
    * [RISC-V] Removed unused comment
    
    * [RISC-V] Fixed long/ulong casts
    
    * [RISC-V] Added some comments
    
    * [RISC-V] Fixes in CHECK_SMALL_INT_RANGE
    
    * [RISC-V] More bugfixes in int casts
    
    * [RISC-V] Generalized CHECK_SMALL_INT_RANGE a little bit
    
    * [RISC-V] Fixed typo
    Bajtazar authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    a1d898f View commit details
    Browse the repository at this point in the history
  3. ARM64-SVE: refactor lsra buildHWIntrinsic (#107459)

    * Add BuildConditionalSelectHWIntrinsic()
    
    * Add GetRMWOp()
    
    * Use GetDelayFreeOp() in BuildConditionalSelectWithEmbeddedOp()
    
    * simplify op2 handling
    
    * Add getVectorAddrOperand()
    
    * Add getConsecutiveRegistersOperand
    
    * Add BuildOperand()
    
    * Use BuildOperand for op1
    
    * Add buildHWIntrinsicImmediate
    
    * Add getOperandCandidates()
    
    * Remove BuildOperand()
    
    * remove delayFreeMultiple
    
    * Fixes from other PRs to be removed
    
    * Fix formatting
    
    * Use BuildHWIntrinsicImmediate for conditional select
    
    * Remove IsRMW
    
    * Replace BuildConditionalSelectWithEmbeddedOp() with BuildEmbeddedOperandUses()
    
    * Revert "Fixes from other PRs to be removed"
    
    * Move functions
    
    * Move functions
    
    * Remove failing unary tests
    
    * Fix opNum type
    
    * Revert "Remove failing unary tests"
    
    * Remove cases from getDelayFreeOperand that are handled by default
    
    * review cleanups
    
    * Simplify masks in getOperandCandidates()
    
    * Remove IsMaskedOperation()
    
    * Check for optional embedded masks in getDelayFreeOperand
    
    * Only call BuildDelayFreeUses when register types match
    
    * Assert only on Arm64
    
    * Comment fixups
    a74nh authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    6c0b392 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a859aa6 View commit details
    Browse the repository at this point in the history
  5. Fix getting default install location for x64 when running x86 host on…

    … x64 Windows (#108538)
    
    - Handle x86 on x64 looking for x64 install so that it looks at `ProgramW6432` instead of `ProgramFiles`
    - Just check `ProgramFiles` for when determining location for current arch
      - We were unnecessarily checking `ProgramFiles(x86)` for x86 running in wow64
    
    Because this is looking at machine-wide locations, our tests don't actually go down this path (tests for default install location go through a test-only environment variable which bypasses the ProgramFiles environment variables lookup).
    elinor-fung authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    08bbf1f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3774ead View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ba28992 View commit details
    Browse the repository at this point in the history
  8. Don't call HasCustomModifier when the argument type is something norm…

    …alized to ELEMENT_TYPE_PTR or ELEMENT_TYPE_BYREF (#108610)
    jkoritzinsky authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    46f3c10 View commit details
    Browse the repository at this point in the history
  9. [main] Update dependencies from 7 repositories (#108385)

    * Update dependencies from https://github.com/dotnet/runtime-assets build 20240930.1
    
    Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
     From Version 10.0.0-beta.24466.1 -> To Version 10.0.0-beta.24480.1
    
    * Update dependencies from https://github.com/dotnet/runtime build 20240929.4
    
    Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
     From Version 10.0.0-alpha.1.24472.5 -> To Version 10.0.0-alpha.1.24479.4
    
    * Update dependencies from https://github.com/dotnet/sdk build 20240929.1
    
    Microsoft.SourceBuild.Intermediate.sdk , Microsoft.DotNet.ApiCompat.Task
     From Version 10.0.100-alpha.1.24472.4 -> To Version 10.0.100-alpha.1.24479.1
    
    * Update dependencies from https://github.com/dotnet/icu build 20240930.1
    
    Microsoft.NETCore.Runtime.ICU.Transport
     From Version 10.0.0-alpha.1.24473.1 -> To Version 10.0.0-alpha.1.24480.1
    
    * Update dependencies from https://github.com/dotnet/hotreload-utils build 20240930.1
    
    Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
     From Version 10.0.0-alpha.0.24473.1 -> To Version 10.0.0-alpha.0.24480.1
    
    * Update dependencies from https://github.com/dotnet/cecil build 20240930.1
    
    Microsoft.SourceBuild.Intermediate.cecil , Microsoft.DotNet.Cecil
     From Version 0.11.5-alpha.24475.1 -> To Version 0.11.5-alpha.24480.1
    
    * Update dependencies from https://github.com/dotnet/runtime-assets build 20240930.2
    
    Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
     From Version 10.0.0-beta.24480.1 -> To Version 10.0.0-beta.24480.2
    
    * Update dependencies from https://github.com/dotnet/source-build-externals build 20240930.1
    
    Microsoft.SourceBuild.Intermediate.source-build-externals
     From Version 10.0.0-alpha.1.24473.2 -> To Version 10.0.0-alpha.1.24480.1
    
    * Update dependencies from https://github.com/dotnet/icu build 20241003.1
    
    Microsoft.NETCore.Runtime.ICU.Transport
     From Version 10.0.0-alpha.1.24480.1 -> To Version 10.0.0-alpha.1.24503.1
    
    * Update dependencies from https://github.com/dotnet/source-build-externals build 20241002.3
    
    Microsoft.SourceBuild.Intermediate.source-build-externals
     From Version 10.0.0-alpha.1.24480.1 -> To Version 10.0.0-alpha.1.24502.3
    
    * Update dependencies from https://github.com/dotnet/runtime build 20241004.10
    
    Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
     From Version 10.0.0-alpha.1.24479.4 -> To Version 10.0.0-alpha.1.24504.10
    
    * Update dependencies from https://github.com/dotnet/sdk build 20240930.5
    
    Microsoft.SourceBuild.Intermediate.sdk , Microsoft.DotNet.ApiCompat.Task
     From Version 10.0.100-alpha.1.24479.1 -> To Version 10.0.100-alpha.1.24480.5
    
    ---------
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    68ef461 View commit details
    Browse the repository at this point in the history
  10. [main] Update dependencies from dotnet/arcade (#108323)

    * Update dependencies from https://github.com/dotnet/arcade build 20240926.2
    
    Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
     From Version 10.0.0-beta.24475.5 -> To Version 10.0.0-beta.24476.2
    
    * Update dependencies from https://github.com/dotnet/arcade build 20241001.6
    
    Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
     From Version 10.0.0-beta.24476.2 -> To Version 10.0.0-beta.24501.6
    
    * Update dependencies from https://github.com/dotnet/arcade build 20241003.1
    
    Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
     From Version 10.0.0-beta.24501.6 -> To Version 10.0.0-beta.24503.1
    
    * Update dependencies from https://github.com/dotnet/arcade build 20241004.4
    
    Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
     From Version 10.0.0-beta.24503.1 -> To Version 10.0.0-beta.24504.4
    
    ---------
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    a7ca444 View commit details
    Browse the repository at this point in the history
  11. Update dependencies from https://github.com/dotnet/source-build-refer…

    …ence-packages build 20241004.1 (#108593)
    
    Microsoft.SourceBuild.Intermediate.source-build-reference-packages
     From Version 10.0.0-alpha.1.24473.1 -> To Version 10.0.0-alpha.1.24504.1
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    8a2a355 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. [wasm] Fixes for issue #108519 (#108543)

    * Fixes for issue 108519
    kg authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    7cbd86c View commit details
    Browse the repository at this point in the history
  2. MSFT:53847109 [.NET Core] DTS / UserPrincipal.GetAuthorizationGroups …

    …returns PrincipalOperationException: Information about the domain could not be retrieved (1212). (#108032)
    
    * Handling sentinel SID when classifying SIDS
    
    * code review comments
    
    * Apply suggestions from code review
    
    ---------
    
    Co-authored-by: Ravi Kumar <[email protected]>
    Co-authored-by: Buyaa Namnan <[email protected]>
    3 people authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    733ef6a View commit details
    Browse the repository at this point in the history
  3. [mono] Fix vector class retrieval and type checks for binary operand …

    …APIs (#107388)
    
    - change the function to be split by the OP code rather than the type of the operands
    - add type checks to the callsite to ensure that the operands are of the correct type
    matouskozak authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    43295bb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    15a5923 View commit details
    Browse the repository at this point in the history
  5. [browser][debugging] Removed trailing comma that results in a warnin…

    …g (#108583)
    
    Co-authored-by: Larry Ewing <[email protected]>
    dlemstra and lewing authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    589f733 View commit details
    Browse the repository at this point in the history
  6. JIT: Disallow SCEV analysis of non-values (#108603)

    SCEV analysis would allow stores either via simple add-rec handling or
    by forwarding to the data of the store. Given that stores are not values
    this is odd behavior that has bitten me while consuming the analysis
    package.
    
    Switch the analysis to return nullptr for stores; instead add handling
    for `GT_PHI` in the places where it was needed.
    jakobbotsch authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    770df10 View commit details
    Browse the repository at this point in the history
  7. [wasm] Read messages from binlog if process output is missing build f…

    …inished message (#107280)
    maraf authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    57feb11 View commit details
    Browse the repository at this point in the history
  8. [browser] Make boot json file name configurable (#108281)

    Co-authored-by: Marek Fišera <[email protected]>
    jeromelaban and maraf authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    445660f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6f4add8 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    667c007 View commit details
    Browse the repository at this point in the history
  11. [cdac] Implement ISOSDacInterface::GetPEFileBase in cDAC (#108602)

    Implements ISOSDacInterface::GetPEFileBase in cDAC
    
    Module already contains the Base so no change is needed.
    Loader_1.cs already implements GetILBase to get the Base off of the module.
    
    Contributes to #108450
    max-charlamb authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    219126c View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    f24eb8a View commit details
    Browse the repository at this point in the history
  13. Fix LINQ Last() in ConcatNIterator to also check base case (Concat2It…

    …erator) (#108486)
    
    * Fix LINQ Last() in ConcatNIterator to also check base case (Concat2Iterator)
    
    * Add a few more test cases of empty concats
    
    * Simplify solution as suggested in PR Review
    andrewjsaid authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    124dd32 View commit details
    Browse the repository at this point in the history
  14. Add fuzzer for Convert.To/FromBase64 APIs (#108247)

    * Add fuzzer for Convert.To/FromBase64 APIs
    
    * Remove asserting invalid chars, decoding logic should detect that
    
    * Apply suggestions from code review
    
    Co-authored-by: Miha Zupan <[email protected]>
    
    * Add ConvertToBase64Fuzzer to the project
    
    * Move ConvertToBase64Fuzzer logic to Base64Fuzzer, remove analyzer supressions, update readme
    
    * Apply suggestions from code review
    
    Co-authored-by: Miha Zupan <[email protected]>
    
    ---------
    
    Co-authored-by: Miha Zupan <[email protected]>
    buyaa-n and MihaZupan authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    a0d5071 View commit details
    Browse the repository at this point in the history
  15. [main] Update dependencies from dotnet/emsdk (#108514)

    * Update dependencies from https://github.com/dotnet/emsdk build 20241002.5
    
    Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport
     From Version 10.0.0-alpha.1.24474.1 -> To Version 10.0.0-alpha.1.24502.5
    
    * Update dependencies from https://github.com/dotnet/emsdk build 20241003.2
    
    Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport
     From Version 10.0.0-alpha.1.24502.5 -> To Version 10.0.0-alpha.1.24503.2
    
    * Update dependencies from https://github.com/dotnet/emsdk build 20241004.3
    
    Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport
     From Version 10.0.0-alpha.1.24503.2 -> To Version 10.0.0-alpha.1.24504.3
    
    ---------
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    Co-authored-by: Larry Ewing <[email protected]>
    3 people authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    9bfe7bf View commit details
    Browse the repository at this point in the history
  16. Call native BrotliEncoderMaxCompressedSize method for BrotliEncoder.G…

    …etMaxCompressedLength (#108043)
    buyaa-n authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    848cabd View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    d5cb4cd View commit details
    Browse the repository at this point in the history
  18. [browser] stop testing runtime with nodejs (#108582)

    * stop testing with nodejs
    
    * One condition, more readible.
    
    * Apply @kasperk81's feedback - this project is not used in WBT anymore.
    
    ---------
    
    Co-authored-by: Ilona Tomkowicz <[email protected]>
    pavelsavara and ilonatommy authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    59a460a View commit details
    Browse the repository at this point in the history
  19. [GC] Revert distribute_free_regions changes in preparation for differ…

    …ent strategy (#108417)
    
    * Revert "[GC] Allow distribute_free_regions to decommit and redistribute (#106414)"
    
    This reverts commit 566a3bd.
    
    * Cherry-pick part of '[release/9.0] Revert "[GC] Avoid OOM in large-allocation-only workloads (#105521)" (#107712)', which is b27a808
    
    The 9.0 revert already handled merge conflicts with bfb674e, which is in main
    and 9.0.  However, this keeps the changes to age huge free regions.  Nothing is
    done with those ages, but this avoids churn to put it back in later.
    markples authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    45343ce View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    5683182 View commit details
    Browse the repository at this point in the history
  21. [cdac] Implement NibbleMap lookup and tests (#108403)

    * [cdac] Implement NibbleMap lookup and tests
    
       The execution manager uses a nibble map to quickly map program counter pointers to the beginnings of the native code for the managed method.
    
       Implement the lookup algorithm for a nibble map.
    
       Start adding unit tests for the nibble map
    
       Also for testing in MockMemorySpace simplify ReaderContext, there's nothing special about the descriptor HeapFragments anymore.  We can use a uniform reader.
    
    * NibbleMap: remove unused _codeHeaderSize field
    
    * cleanup NibbleMap and tests
    
    * NibbleMap: use a struct for MapUnit
    
    * Clarify termination condition; clean up docs
    
       Add an example
    
    
    Co-authored-by: Filip Navara <[email protected]>
    lambdageek and filipnavara authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    9d923b8 View commit details
    Browse the repository at this point in the history
  22. Remove HelperMethodFrames (HMF) from Reflection code paths (#108535)

    Remove RuntimeFieldHandle.GetName() FCall.
    Remove RuntimeMethodHandle.GetName() FCall.
    Cleanup RuntimeTypeHandle.GetUtf8NameInternal().
    Convert TypedReference.MakeTypedReference() to mostly managed.
      - Increase CoreCLR and Mono shared code.
    Convert RuntimeFieldHandle.GetValueDirect() to QCall.
    Convert RuntimeFieldHandle.SetValueDirect() to QCall.
    Removed unused FCThrow* macros.
    AaronRobinsonMSFT authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    0f04f6d View commit details
    Browse the repository at this point in the history
  23. Move tools to use LKG ILC (#107772)

    Starts with crossgen2 and moves shared helpers into a central targets file.
    
    This still leaves a significant amount of work to do. We're still building 3 copies of the crossgen2 and ILC projects (plain, in-build, and AOT) and not all might be necessary. Also, some pieces could maybe be reused in other portions of the build.
    
    There's also no way to _not_ use LKG bits. That's left as future work.
    agocke authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    3f28b1a View commit details
    Browse the repository at this point in the history
  24. [RISC-V] Fix some minor errors (#107179)

    * [RISC-V] Fix minor errors
    
    * Delete Unused Codes in RISCV64 Unwinder
    clamp03 authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    afad60c View commit details
    Browse the repository at this point in the history
  25. ZipArchive: Improve performance of removing extra fields (#108665)

    This improves the performance of removing extra fields in the ZipArchive by optimizing the removal process.
    
    `src/libraries/System.IO.Compression/src/System/IO/Compression/ZipBlocks.cs`: Replaced multiple iterations and list operations with a single `RemoveAll` call to enhance efficiency.
    ericstj authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    10760a2 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Update stepping through MulticastDelegate under the Debugger (#108414)

    * macOS stepping with multicast delegates
    
    * remove one call of  MulticastDebuggerTraceHelper
    
    * change int to INT_PTR
    
    * change to QCall and optimize
    
    * styling and cleanup
    mikelle-rogers authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    abde3f9 View commit details
    Browse the repository at this point in the history
  2. Fix macOS arm64 Unix breakpoint (#108560)

    * Fix arm64 Unix breakpoint
    
    Currently we use brk #0, but lldb cannot step over it. Using brk #0xf000 instead
    works fine.
    
    Close #108541
    
    * Unify windows and unix brk
    
    * Fix formatting
    janvorli authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    02dc5dc View commit details
    Browse the repository at this point in the history
  3. [mono] Fix wording around when objects are entering degraded gc mode …

    …(#108411)
    
    Resolves policheck issue around the wording
    steveisok authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    fe9e98a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7318855 View commit details
    Browse the repository at this point in the history
  5. JIT: Run single EH region repair pass after layout (#108634)

    Fixes #108608. To simplify EH maintenance logic, leave EH regions in a deconstructed phase during block reordering, and correct the end block pointers of each region in a pass over the block list after. By walking the list backwards, we can short-circuit finding the end of each region, and we don't run into the issue of an EH region not being able to determine if it's at the end of its parent region due to some awkward placement of a sibling region.
    amanasifkhalid authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    87273d6 View commit details
    Browse the repository at this point in the history
  6. Tweak Invariant IndexOf logic (#108709)

    Co-authored-by: Tarek Mahmoud Sayed <[email protected]>
    MihaZupan and tarekgh authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    e8e3e14 View commit details
    Browse the repository at this point in the history
  7. Normalize -- and case for options in src/tests/build.sh like we do …

    …in eng/build(-commons).sh (#107425)
    
    Normalize `--` in src/tests/build.sh like we do in eng/build.sh and eng/build-commons.sh, so that `--cross` always works
    kg authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    ea4ba5e View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9d28160 View commit details
    Browse the repository at this point in the history
  9. [RISC-V] Transfer arguments between calling conventions in shuffling …

    …thunks (#107282)
    
    * Log ShuffleEntries from GenerateShuffleArray
    
    * Add failing tests for passing FP structs through shuffling thunks
    
    * Report proper ShuffleEntries for lowered FP structs
    
    * Implement shuffling thunk generation in tighter, more focused loops instead of an omnibus loop handling ShuffleEntries
    
    * Generate ShuffleEntries for delowered arguments
    
    * Better ShuffleEntry mask names, one more bit for field offset
    
    * Fix FpStruct for dst arg loc
    
    * Fold ShuffleEntry generation code for lowering and delowering FpStructs
    
    * ShuffleEntry mask doc update
    
    * Implement forward shuffling of floating registers and delowering of FpStructs. EmptyStructs test passes except for ShufflingThunk_FloatEmptyShort_DoubleFloatNestedEmpty_RiscV
    
    * Fix shuffling of integer registers for member functions
    
    * The delowered argument can also be put in the first stack slot
    
    * Stask shuffling after delowered argument doesn't start with 0. Fixes Regressions/coreclr/GitHub_16833/Test16833
    
    * Code cleanup, fewer indents
    
    * Support second lowering
    
    * Remove unused CondCode
    
    * Handle stack slot shuffling to the right
    
    * Add some stack slots to shuffle in the growing stack test case
    
    * Fix Equals signature on test structs
    
    * Remodel the shuffling with calling convention transfer to recognize the key points first, which simplifies code and solves some corner cases e.g. where we can't assume struct stack size by checking the size + offset of the last field
    
    * Use helper functions in EmitComputedInstantiatingMethodStub
    
    * Implement stack growing in shuffling thunk
    
    * Use signed immediate in EmitSubImm to be consistent with EmitAddImm
    
    * Use ABI register names in logs
    
    * Remove LoadRegPair because it's not used
    
    * Add logging for slli and lui
    
    * Remove stack growing from hand-emitted shuffle thunks
    
    * Minor FloatFloatEmpty test cleanup
    
    * Implement IL shuffling thunks for cases where the stack is growing
    
    * Test stack walking in frames laid by the IL shuffle thunk
    
    * Add assert and comment in CreateILDelegateShuffleThunk
    
    * Fix release build
    
    * Fixes for static delegates from member methods
    
    * Fix log and comment
    
    * Remove EmitJumpAndLinkRegister because it's no longer used
    
    * Use TransferredField.reg in delowering (cosmetic fix to restart CI)
    
    * New stub type for delegate shuffle thunk so it doesn't go in multidelegate code paths
    
    * Make Test_ShufflingThunk_MemberGrowsStack_RiscV harder by returning via buffer
    
    * Explain lowering
    
    * Fold 12-bit sign extension branch in EmitMovConstant
    
    * Harden Test_ShufflingThunk_PackedEmptyUintEmptyFloat_PackedEmptyDouble to cover interleaving FP and int arguments
    
    * Handle shuffles between calling conventions in IL stubs
    
    * Update comments
    
    * Don't use NewStub for IL stubs
    
    * Fold some more duplicated code into SetupShuffleThunk
    
    * Clean up unnecessary diffs
    
    * IL shuffle thunk takes target function address from delegate object. Cache the generated thunk on DelegateEEClass
    
    * Build target signature based on delegate signature instead of just using the signature from target method to retain type context
    
    * Test calling instance and static methods via the same delegate type
    
    * Simplify shuffle thunk caching on DelegateEEClass
    
    * Clean up CreateILDelegateShuffleThunk
    
    * Delete Windows X86 stack size check
    
    * Remove #ifdefs around ILSTUB_DELEGATE_SHUFFLE_THUNK, fix typo in GetStubMethodName
    
    * Fix DecRef'ing path when the IL thunk is already cached on DelegateEEClass
    
    * Fix shuffle thunk destruction in EEClass::Destruct: properly handle IL shuffle thunks and call RemoveStubRange if m_pInstRetBuffCallStub was deleted
    
    * Don't use RemoveStubRange in the destructor, make code for dereferencing shuffle thunk when caching fails the same as destructor
    
    * Remove unused RemoveStubRange
    
    * Cover IL shuffle thunks in ILStubManager::TraceManager
    
    * Remove unused start, end arguments from RangeList::RemoveRanges[Worker]
    
    * Update src/coreclr/vm/comdelegate.cpp
    
    ---------
    
    Co-authored-by: Jan Kotas <[email protected]>
    tomeksowi and jkotas authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    4f60693 View commit details
    Browse the repository at this point in the history
  10. [ppc64le] Fixed assertion failure which was occurring while running S…

    …ystem.Runtime.Serialization.Formatters tests (#108429)
    
    * [ppc64le] Fixed thunk address 8 byte alignment issue
    
    * Fixed FSharp crash issue
    
    * [ppc64le] Implementation of mono_arch_get_delegate_virtual_invoke_impl method for ppc64le architecture
    
    * Fixed clang15 build issues and returning address of sc_sp instead of value
    
    * Added float32 support and implemented related opcodes
    
    * Correction in OP_RCONV_TO_R cases
    
    * Corrected code for few opcodes
    
    * [ppc64le] performance improvements while branching
    
    * [ppc64le] Fixed insufficient memory exception issue
    
    * [ppc64le] Fixed assertion failure which was occurring while running System.Runtime.Serialization.Formatters tests
    alhad-deshpande authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    6fad376 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Disable Comparer_get_Default test on linux-arm64-crossgen (#108725)

    This test was disabled on windows-arm64, but the outerloop also fails on linux-arm64.
    
    See dotnet/runtime#104927
    steveisok authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9696817 View commit details
    Browse the repository at this point in the history
  2. JIT: Add loop-aware RPO, and use as LSRA's block sequence (#108086)

    Part of #107749, and follow-up to #107927. When computing a RPO of the flow graph, ensuring that the entirety of a loop body is visited before any of the loop's successors has the benefit of keeping the loop body compact in the traversal. This is certainly ideal when computing an initial block layout, and may be preferable for register allocation, too. Thus, this change formalizes loop-aware RPO creation as part of the flowgraph API surface, and uses it for LSRA's block sequence.
    amanasifkhalid authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    e32148a View commit details
    Browse the repository at this point in the history
  3. Doc updates (#108722)

    gewarren authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    11c86d8 View commit details
    Browse the repository at this point in the history
  4. Avoid backing field for marshallers. (#108737)

    This also makes the BufferSize pattern consistent across all new custom marshallers.
    AaronRobinsonMSFT authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    55de306 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    76146ee View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    72ebebf View commit details
    Browse the repository at this point in the history
  7. Packaging: Port fix for GetParts from .NETFramework (#108681)

    * Packaging: Port fix for GetParts from .NETFramework
    
    This ports a fix for the `GetParts` method to improve part URI handling and collision detection.
    
    `src/libraries/System.IO.Packaging/src/System/IO/Packaging/Package.cs`: Added sorting of parts array to ensure proper order, introduced a dictionary and list to track parts and detect collisions, and implemented a new method `CopyPartDictionaryToPartList` to copy parts to `_partList`.
    
    * Fix regression in ExtensionEqualityComparer
    
    Previously this comparison was Ordinal after calling ToUpperInvariant
    
    This was changed to InvariantIgnoreCase which breaks because it will
    treat things like ß and ss as equal where they were not before.
    
    * Address feedback
    
    * Remove servicing properties from IO.Packaging
    ericstj authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    5cc1eb5 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2e0276c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f41e95c View commit details
    Browse the repository at this point in the history
  10. Ensure to use float reserved register for TYP_SIMD12 (#108629)

    * Use Float reserved registers
    
    * add test case
    
    * Use consistent internal register requirement for TYP_SIMD12
    
    * Also do in loongarch and risc
    
    * Use Extract to retrieve internal register for SIMD12
    kunalspathak authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    cb256e2 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Update dependencies from https://github.com/dotnet/source-build-refer…

    …ence-packages build 20241007.1 (#108758)
    
    Microsoft.SourceBuild.Intermediate.source-build-reference-packages
     From Version 10.0.0-alpha.1.24504.1 -> To Version 10.0.0-alpha.1.24507.1
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    751b2c0 View commit details
    Browse the repository at this point in the history
  2. JIT: run a late pass of empty try/finally/fault removal (#108003)

    The JIT can sometimes optimize away all the code in a finally or fault, so rerun
    and generalize the empty try-finally removal to cover faults and run it
    again after the main optimization passes.
    AndyAyersMS authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    985c177 View commit details
    Browse the repository at this point in the history
  3. Disable codeql on official builds part 2 (#108767)

    According to the most updated docs, enabled and justification need to be underneath compiled.
    steveisok authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    f938d80 View commit details
    Browse the repository at this point in the history
  4. bgc deadlock fix (#108773)

    this was a regression introduced in #105545. this would only manifest during the beginning of a process when we needed to grow the # of heaps (and can grow) and we haven't done a gen2 GC yet so we set it to doing one.
    
    the problem is the check I made did not include the ephemeral GC that may happen at the beginning of a BGC before we set gc_background_running to true. so at the end of that eph GC, we are in calculate_new_heap_count and set trigger_initial_gen2_p to true, not realizing we are already in a BGC.
    
    then during the joined_generation_to_condemn at the beginning of the next GC, if our conclusion was still doing an eph GC we'd make it a BGC due to trigger_initial_gen2_p which obviously would cause problem if a BGC is already in progress (I do have an assert for this but we haven't seen this in a dbg build...).
    
    the fix is to simply use the right check - is_bgc_in_progress() instead of background_running_p() which includes that eph GC case.
    Maoni0 authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    a910792 View commit details
    Browse the repository at this point in the history
  5. Remove string.Trim{,Start,End}(ReadOnlySpan<char>)

    These three methods have a higher overload resolution priority than any potential
    user defined extension methods `TrimEnd(this string, string)` (et al), but invariably
    yield a different answer than those extension methods: for an existing call
    `text.TrimEnd("suffix")` the extension method wants to remove just the suffix, so
    "prefixinfixsuffix" becomes "prefixinfix".  However, our method treats it as a call
    of `text.TrimEnd('s', 'u', 'f', 'f', 'i', 'x')`, yielding the result "prefixin".
    
    An alternative solution to this problem would be to define our own
    `string.TrimEnd(string)` instance method, but that has its own set of
    complications and is too risky to consider for backporting into .NET 9.
    
    This change only removes the methods from the System.Runtime (ref) assembly,
    in order to work better with the slightly circular dependency/flow in the dotnet/*
    repositories.
    bartonjs authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    e4ff0d8 View commit details
    Browse the repository at this point in the history
  6. [WASI] Updates to work with up coming Wasi sdk (#108687)

    * Handle the wasi-sdk clang includes gracefully
    
    Signed-off-by: James Sturtevant <[email protected]>
    
    * Folder no longer exists and causes errors in clang 19+
    
    Signed-off-by: James Sturtevant <[email protected]>
    
    ---------
    
    Signed-off-by: James Sturtevant <[email protected]>
    Co-authored-by: Larry Ewing <[email protected]>
    jsturtevant and lewing authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    cfc7c20 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    eed9c19 View commit details
    Browse the repository at this point in the history
  8. [LoongArch64] Fix the instruction check in 'CodeGen::genInstrWithCons…

    …tant()' when called by 'CodeGen::genHomeStackSegment()'. (#108776)
    LuckyXu-HF authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    a276e2b View commit details
    Browse the repository at this point in the history
  9. JIT: Fold (x + c1) + c2 in lowering (#108779)

    This transformation already exists in morph, but this duplicates the
    transformation in lowering to facilitate removing the call to morph from
    CSE. This transformation happening after CSE is somewhat important
    because shared constant CSE can introduce this IR shape.
    jakobbotsch authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    627ef41 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    3bcf39d View commit details
    Browse the repository at this point in the history
  11. Delete UsePublishedCrossgen2 property (#108693)

    * Delete UsePublishedCrossgen2
    
    * Fix crossgen2 path
    jkotas authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    10e3d01 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    9ceb2bf View commit details
    Browse the repository at this point in the history
  13. Make the schema generator reuse algorithm more aggressive to reduce g…

    …enerated schema size. (#108764)
    eiriktsarpalis authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    3e268fb View commit details
    Browse the repository at this point in the history
  14. Fix an issue with the last level cache values on Linux running on cer…

    …tain AMD Processors (#108492)
    mrsharm authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    4f69316 View commit details
    Browse the repository at this point in the history
  15. Fix optimization of Vector512 And + Not to AndNot (#108775)

    * Fix optimization of Vector512 And + Not to AndNot
    
    Fixes #108613
    
    * Fix test
    BruceForstall authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    7b67ab3 View commit details
    Browse the repository at this point in the history
  16. Remove managed EH code frames from stack trace (#108723)

    When StackTrace is created inside of an exception filter, it contains
    stack frames of the managed exception handling code, like
    System.Runtime.EH.RhThrowEx
    System.Runtime.EH.DispatchEx
    System.Runtime.EH.FindFirstPassHandler
    
    These should not occur on the stack trace as they are internal
    implementation detail of the new EH.
    
    This change fixes it by adding [StackTraceHidden] attribute to these
    methods.
    
    Close #107995
    janvorli authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    64b9ece View commit details
    Browse the repository at this point in the history
  17. Arm64: Use TYP_SIMD8 for AddAcross (#108727)

    * Use TYP_SIMD8 for AddAcross intrinsics
    
    * add test cases
    
    * Mark non interesting method private
    
    * Remove method params
    
    * wrap test code in try-catch
    kunalspathak authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    6fa2f17 View commit details
    Browse the repository at this point in the history
  18. Add project to create helix work items for host tests (#108529)

    - Add `src/installer/tests/helixpublish.proj`
      - Defines correlation payloads (pre-built test targets, .NET install layout, product host binaries, test/mock host binaries)
      - Sets pre-commands to set environment variables used by tests for test assets and artifacts locations
      - Generate helix work items for each host test project - runs `dotnet test <host_test_dll>` for each test with the built output as the payload directory
    - Update `RepoDirectoryProvider` to use `HELIX_CORRELATION_PAYLOAD` (when available) for path to product/test host binaries.
    
    This is not hooked up to actually run in a pipeline. I tested by manually kicking off runs by setting environment variables and directly building the new project. For example:
    - `dotnet build src\installer\tests\helixpublish.proj -c Release /t:Test /p:Creator=dev /p:HelixTargetQueues=Windows.Amd64.Server2022.Open`
    - `dotnet build ./src/installer/tests/helixpublish.proj -c Release /t:Test /p:Creator=dev /p:HelixTargetQueues=Ubuntu.2204.Amd64.Open`
    elinor-fung authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    f457155 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    23a6d6f View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. Configuration menu
    Copy the full SHA
    a038f65 View commit details
    Browse the repository at this point in the history
  2. [LoongArch64] Remove the register tp and rewrite the definition of PT…

    …FF_SAVE_* in NativeAOT. (#108697)
    sunlijun-610 authored Oct 12, 2024
    Configuration menu
    Copy the full SHA
    2f37b48 View commit details
    Browse the repository at this point in the history
  3. Delete STUBLINKER_GENERATES_UNWIND_INFO (#108684)

    None of the stublinker stubs need this anymore
    jkotas authored Oct 12, 2024
    Configuration menu
    Copy the full SHA
    6fb75bf View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4900696 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. [main] Update dependencies from dotnet/xharness (#108478)

    * Update dependencies from https://github.com/dotnet/xharness build 20241001.1
    
    Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
     From Version 10.0.0-prerelease.24476.1 -> To Version 10.0.0-prerelease.24501.1
    
    * Update dependencies from https://github.com/dotnet/xharness build 20241009.1
    
    Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
     From Version 10.0.0-prerelease.24501.1 -> To Version 10.0.0-prerelease.24509.1
    
    * Update dependencies from https://github.com/dotnet/xharness build 20241011.1
    
    Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit
     From Version 10.0.0-prerelease.24509.1 -> To Version 10.0.0-prerelease.24511.1
    
    ---------
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    Co-authored-by: Larry Ewing <[email protected]>
    3 people authored Oct 13, 2024
    Configuration menu
    Copy the full SHA
    79cd4a1 View commit details
    Browse the repository at this point in the history
  2. Disable linux-x64 dev-innerloop (#108581)

    * Disable linux-x64 dev-innerloop
    
    * Add 'disabled against' comment
    am11 authored Oct 13, 2024
    Configuration menu
    Copy the full SHA
    7b69459 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6221ddb View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Automated bump of chrome version (#108816)

    Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
    github-actions[bot] and github-actions[bot] authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    4e2fe8d View commit details
    Browse the repository at this point in the history
  2. [mono] Use llvm 19.1.0 (#105427)

    * Bump to updated llvm 19
    
    * Fix mono_llvm_check_cpu_features
    
    * Update llvm deps
    
    * Update emsdk and icu deps
    
    * Remove wrong python dependency
    
    * Temporarily make WBT use WorkloadsTestPreviousVersions = true
    
    * Fix windows build, add ntdll dependency
    
    Co-authored-by: Alexander Köplinger <[email protected]>
    
    * Fix alloca builder creation
    
    This was hitting assert with debug version of llvm
    
    * Update eh_typeid_for intrinsic
    
    The signature changed in dotnet/llvm-project@10edb4991c127
    
    This fixes crash during registration of the intrinsic and the generated IR is now different.
    
    Before:
    
        CATCHPAD0_BB4:                                    ; preds = %LPAD0_BB3
          %11 = catchpad within %10 [ptr @_ZTIPi]
          %12 = tail call ptr @llvm.wasm.get.exception(token %11)
          %13 = tail call i32 @llvm.wasm.get.ehselector(token %11)
          %14 = tail call i32 @llvm.eh.typeid.for(ptr @_ZTIPi)
          %15 = icmp eq i32 %13, %14
          br i1 %15, label %CATCH_BB5, label %NOCATCH_BB6
    
    After:
    
        CATCHPAD0_BB4:                                    ; preds = %LPAD0_BB3
          %11 = catchpad within %10 [ptr @_ZTIPi]
          %12 = tail call ptr @llvm.wasm.get.exception(token %11)
          %13 = tail call i32 @llvm.wasm.get.ehselector(token %11)
          %14 = tail call i32 @llvm.eh.typeid.for.p0(ptr @_ZTIPi)
          %15 = icmp eq i32 %13, %14
          br i1 %15, label %CATCH_BB5, label %NOCATCH_BB6
    
    * Fix crash in emit_llvmonly_handler_start
    
    Do not try to emit branch when target_bb is not set
    
    * Fix swizzle_mask type
    
    That was catched by llvm debug asserts, the mask should be vector of 16 int8
    
    * Set unwind table kind
    
    To stop hitting assert in the verbose output, when aot compiler is built
    with the debug configuration of llvm
    
    * Update deps to llvm rc3
    
    * Update emsdk and icu deps
    
    * Revert "Temporarily make WBT use WorkloadsTestPreviousVersions = true"
    
    This reverts commit 7c370825cdaf5beec8ce10b1884fa5efb66b661b.
    
    * Update deps for llvm 19/rc4
    
    * Revert "Set unwind table kind"
    
    This reverts commit bba756cfbb03d3e606f690ca79ff6c6c5613b5a0.
    
    * Remove crashing wasi AOT tests
    
    * Disable wasi smoke AOT tests
    
    * Disable failing WBT test for wasi
    
    * Update dependencies to get llvm 19.1.0
    
    * Update emsdk and icu deps with updated binaryen
    
    * Fix emscripten versions
    
    * Add emscripten coherency dependencies back
    
    * Update llvm and derived dependencies
    
    * Remove general testing channel
    
    ---------
    
    Co-authored-by: Alexander Köplinger <[email protected]>
    radekdoulik and akoeplinger authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    1e48f9e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8a7fa48 View commit details
    Browse the repository at this point in the history
  4. [cdac] Make cDAC delegate to the DAC instead of the other way around …

    …(#108772)
    
    - `SOSDacImpl` in cDAC implements all the interfaces implemented by `ClrDataAccess`
    - `CLRDataCreateInstance` returns cDAC if it is enabled
    - `cdac_reader_get_sos_interface` takes the legacy DAC implementation
    - Legacy DAC no longer calls into cDAC for its `ISOSDac*` implementations
    - cDAC delegates to legacy DAC (if it has one) for APIs it has not implemented and asserts that the results are the same for APIs it has implemented
    
    Behavioural differences of note:
    - Since asserts comparing results are in the cDAC instead of DAC now, they will come through as a fail fast with or without a debugger attached - as opposed to before, when they were silently ignored when a debugger was attached. The assert message will print to the debugger output (if attached) or OutputDebugString/syslog.
    - If the cDAC implementation of an API errors, it does not fall back to calling the legacy DAC. I think this is reasonable given that we plan to put the ability to choose cDAC vs legacy DAC at a higher level. If cDAC implementation fails, it should fail and not try to hide it.
    - `ClrDataAccess` lifetime is handled by cDAC (when enabled), so actual release is dependent on finalization of the COM object.
    
    I ran the SOS tests in diagnostics repo against this change locally both with and without the cDAC enabled.
    elinor-fung authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    adba54d View commit details
    Browse the repository at this point in the history
  5. Update dependencies from https://github.com/dotnet/source-build-refer…

    …ence-packages build 20241011.4 (#108841)
    
    Microsoft.SourceBuild.Intermediate.source-build-reference-packages
     From Version 10.0.0-alpha.1.24507.1 -> To Version 10.0.0-alpha.1.24511.4
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    0212c3d View commit details
    Browse the repository at this point in the history
  6. Enable all configurations inner loop (#108848)

    * Revert "Disable linux-x64 dev-innerloop (#108581)"
    
    This reverts commit 7b69459.
    
    * Don't build tests in linux_x64_dev_innerloop
    
    Testing to determine if building tests were the source of OOMs in CI
    ericstj authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    44978f0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0783785 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f059869 View commit details
    Browse the repository at this point in the history
  9. ILLink: Don't mark attributes from MarkEntireType (#108552)

    Attributes are already marked from MarkType, called by MarkEntireType.
    The removed marking logic was using the assembly as the warning
    message origin, making these warnings hard to suppress (in
    addition to being redundant with the warnings at the type level).
    sbomer authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    6d23f64 View commit details
    Browse the repository at this point in the history
  10. JIT: very simple cloning heuristic (#108771)

    Avoid cloning large loops.
    
    We compute loop size by counting tree nodes of all statements of all
    blocks in the loop. If this is over a threshold, we inhibit cloning.
    
    Threshold value was chosen based on distribution of unrestricted cloned
    loop sizes in the benchmark run_pgo collection.
    AndyAyersMS authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    2098981 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Crossgen2 outer loop fixes (#108819)

    * Crossgen2 outer loop fixes
    
    * Test musl arm
    
    * Fix SingleFileHostSourcePath property for UseLocalAppHostPack=false
    
    * Unrelated typo
    
    * Fix crossgen executable name
    
    * Fix python
    
    * Executable permissions
    jkotas authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    6a9e153 View commit details
    Browse the repository at this point in the history
  2. Fix CET debugger stepping over CALL instructions (#108809)

    * Initial changes to support in-place single-stepping over call instructions from out of process
    
    * ThreadSuspension WIP
    
    * Change how in-place single step is tracked
    
    * Pass fSSCompleted to the right side
    
    * Only suspend other threads for in-place single step
    
    * Add thread resume in HandleSetThreadContextNeeded
    
    * ScanForTriggers should return DebuggerPatchSkip
    
    * Refactor out of proc thread suspension into CordbThread
    
    * Avoid using DebuggerPatchSkip for tracking in-place single step on left side, and resume threads on the right side before the left side is notified
    
    * Track InplaceSteppingThreads at the process level on the RS, ApplyRemotePatch/RemoveRemotePatch for patch writing
    
    * Block detach if m_inplaceSteppingThreads is not empty
    
    * Refactor InplaceSteppingThreads impl
    
    * Track thread create and exit for thread suspension
    
    * Change comments to minimize size of change
    
    * Fix blank space diff
    
    * Keep track of single step thread suspension count at the process level
    
    * Cleanup and correctly pass bool from LS to RS
    
    * Workaround crash caused by SSP restore on fake context
    
    * Change page protections when clearing or writing breakpoints
    
    * Remove debug output and perform some cleanup
    
    * Track unmanaged threads with SHash instead of unordered_map
    
    * Revert "Workaround crash caused by SSP restore on fake context"
    
    This reverts commit 874c465495edef0c85f55bdda9a82850c68a9af6.
    
    * Fix func-eval abort with minimal code change
    
    * Apply suggestions from noahfalk
    
    Co-authored-by: Noah Falk <[email protected]>
    
    * Always define IsInPlaceSingleStep and return false if not implemented
    
    * CR feedback from mikelle-rogers - correctly set begin iterator for suspending/resuming/closing threads
    
    ---------
    
    Co-authored-by: Noah Falk <[email protected]>
    tommcdon and noahfalk authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    a636e6d View commit details
    Browse the repository at this point in the history
  3. Fix argument passing of structs with padding on x86 (#108867)

    When passing a struct by value on x86, we copy its value to the stack.
    Sometimes this is done one field at a time, if the struct has been
    promoted. If there is padding between the fields (to create appropriate
    field alignment), then that padding needs to be zeroed.
    
    The bug is a case where there is padding between an earlier `double`
    field and a later, larger, SIMD field. We push 4-byte zeros but the code thinks
    it is pushing 8-byte zeros. The fix is simply to correctly calculate the number
    of zeros to push.
    
    Fixes #106140
    BruceForstall authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    e1a14a8 View commit details
    Browse the repository at this point in the history
  4. Switch SwiftSelf<T> position requirement to last (#108547)

    This is added as the last parameter by the Swift compiler, so to support
    instance calls taking parameters this needs to come last.
    jakobbotsch authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    74857d7 View commit details
    Browse the repository at this point in the history
  5. JIT: Stop calling morph from CSE (#106695)

    CSE cannot tolerate morph removing any defs, which many of morphs
    transformations can do. We have been slowly infecting morph with more
    and more checks to avoid this, but in reality CSE just should not
    reinvoke morph -- the benefits of doing this are minimal.
    jakobbotsch authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    07f15ef View commit details
    Browse the repository at this point in the history
  6. Update dependencies from https://github.com/dotnet/emsdk build 202410…

    …08.1 (#108707)
    
    Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport
     From Version 10.0.0-alpha.1.24504.3 -> To Version 10.0.0-alpha.1.24508.1
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    Co-authored-by: Larry Ewing <[email protected]>
    3 people authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    8ef27e2 View commit details
    Browse the repository at this point in the history
  7. JIT: Advance cursors through stores in strength reduction (#105267)

    This allows us to look through CSE'd locals when an IV was CSE'd.
    
    Example diff:
    ```csharp
    private static void CopyInts(int[] arr1, int[] arr2)
    {
        if (arr2.Length != arr1.Length)
            return;
    
        for (int i = 0; i < arr1.Length; i++)
        {
            arr2[i] = arr1[i];
        }
    }
    ```
    
    ```diff
    @@ -1,14 +1,16 @@
     G_M55903_IG03:  ;; offset=0x000C
    -       xor      eax, eax
            test     r8d, r8d
    -       jle      SHORT G_M55903_IG05
    -						;; size=7 bbWeight=0.50 PerfScore 0.75
    +       jle      SHORT G_M55903_IG06
    +						;; size=5 bbWeight=0.50 PerfScore 0.62
     
    -G_M55903_IG04:  ;; offset=0x0013
    -       mov      r10d, eax
    -       mov      r9d, dword ptr [rcx+4*r10+0x10]
    -       mov      dword ptr [rdx+4*r10+0x10], r9d
    -       inc      eax
    -       cmp      r8d, eax
    -       jg       SHORT G_M55903_IG04
    -						;; size=20 bbWeight=3.96 PerfScore 18.81
    +G_M55903_IG04:  ;; offset=0x0011
    +       mov      eax, 16
    +						;; size=5 bbWeight=0.25 PerfScore 0.06
    +
    +G_M55903_IG05:  ;; offset=0x0016
    +       mov      r10d, dword ptr [rcx+rax]
    +       mov      dword ptr [rdx+rax], r10d
    +       add      rax, 4
    +       dec      r8d
    +       jne      SHORT G_M55903_IG05
    +						;; size=17 bbWeight=3.96 PerfScore 17.82
    ```
    
    arm64 especially benefits from strength reduction, e.g. a benchmark for the above:
    
    ```
    BenchmarkDotNet v0.13.12, Ubuntu 22.04.4 LTS (Jammy Jellyfish)
    Unknown processor
      Job-GXMAGJ : .NET 9.0.0 (42.42.42.42424), Arm64 RyuJIT AdvSIMD
      Job-MLUOLU : .NET 9.0.0 (42.42.42.42424), Arm64 RyuJIT AdvSIMD
    ```
    
    | Method   | Toolchain               | Mean     | Error     | Ratio |
    |--------- |------------------------ |---------:|----------:|------:|
    | CopyInts | Main | 6.683 μs | 0.0010 μs |  1.00 |
    | CopyInts | PR | 5.014 μs | 0.0003 μs |  0.75 |
    jakobbotsch authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    87a35d6 View commit details
    Browse the repository at this point in the history
  8. Avoid OverflowException in Boolean.TryFormat (#108572)

    * Avoid `OverflowException` in `Boolean.TryFormat`
    
    `MemoryMarshal.AsBytes` would throw unnecessarily when `destination.Length` exceeds 0x3FFFFFFF.
    
    * Use `string.TryCopyTo`
    
    ---------
    
    Co-authored-by: Egor Bogatov <[email protected]>
    xtqqczze and EgorBo authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    a174fd1 View commit details
    Browse the repository at this point in the history
  9. Fix compilation of Apple native shim on newer Clang

    Newer versions of Clang warn when you are doing enum comparisons of different enum types.
    vcsjones authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    e9e0ab4 View commit details
    Browse the repository at this point in the history
  10. Make ExecutionManager.md markdownlint-clean (#108866)

    Remove a stray end-of-line space
    GrabYourPitchforks authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    1464076 View commit details
    Browse the repository at this point in the history
  11. JIT: Produce correctly typed IR in TLS helper expansion (#108836)

    The TLS helper expansion would produce `ADD(long, int)` trees like
    ```
    ▌  STORE_LCL_VAR long   V01 rat0
    └──▌  ADD       long
       ├──▌  ADD       long
       │  ├──▌  LCL_VAR   long   V02 rat1
       │  └──▌  CNS_INT   int    72 $41
       └──▌  CNS_INT   long   192
    ```
    
    which is not legal IR. Fix that by inserting a cast. Also do some more
    aggressive folding to get rid of these casts in the normal cases, and to
    fold some constant arithmeticf in other cases.
    jakobbotsch authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    c5b9a02 View commit details
    Browse the repository at this point in the history
  12. Introduce a mechanism to disable CLR tests under SuperPMI collection …

    …(#108873)
    
    It should be _extremely_ rare to need to disable a test during SuperPMI
    collection. However, one case was found, so introduce the ability to do so.
    
    Use `<SuperPmiCollectIncompatible>true</SuperPmiCollectIncompatible>` in
    a test project file.
    
    (which also requires `<RequiresProcessIsolation>true</RequiresProcessIsolation>`)
    
    Fixes #108215
    BruceForstall authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    270c2b1 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    7f682ef View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    dedb7d1 View commit details
    Browse the repository at this point in the history
  15. Add ee_alloc_context (#104849)

    This change is some preparatory refactoring for the randomized allocation sampling feature. We need to add more state onto allocation context but we don't want to do a breaking change of the GC interface. The new state only needs to be visible to the EE but we want it physically near the existing alloc context state for good cache locality. To accomplish this we created a new ee_alloc_context struct which contains an instance of gc_alloc_context within it.
    
    The new ee_alloc_context.combined_limit field should be used by fast allocation helpers to determine when to go down the slow path. Most of the time combined_limit has the same value as alloc_limit, but periodically we need to emit an allocation sampling event on an object that is somewhere in the middle of an AC. Using combined_limit rather than alloc_limit as the slow path trigger allows us to keep all the sampling event logic in the slow path.
    
    PR feedback Co-authored-by: Jan Kotas <[email protected]>
    noahfalk authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    69dc5ec View commit details
    Browse the repository at this point in the history
  16. Move IsDebuggerPresent to minipal, convert to QCall (#108837)

    * Move IsDebuggerPresent to minipal, convert to QCall
    
    ---------
    
    Co-authored-by: Aaron Robinson <[email protected]>
    am11 and AaronRobinsonMSFT authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    44b7ba3 View commit details
    Browse the repository at this point in the history
  17. Update dependencies from https://github.com/dotnet/emsdk build 202410…

    …14.2 (#108884)
    
    Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport
     From Version 10.0.0-alpha.1.24508.1 -> To Version 10.0.0-alpha.1.24514.2
    
    Dependency coherency updates
    
    runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk,runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
     From Version 19.1.0-alpha.1.24501.1 -> To Version 19.1.0-alpha.1.24510.2 (parent: Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    5c718e8 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    5e9a425 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Configuration menu
    Copy the full SHA
    f72179a View commit details
    Browse the repository at this point in the history
  2. Add ee_alloc_context (NativeAOT) (#104851)

    This change is some preparatory refactoring for the randomized allocation sampling feature. We need to add more state onto allocation context but we don't want to do a breaking change of the GC interface. The new state only needs to be visible to the EE but we want it physically near the existing alloc context state for good cache locality. To accomplish this we created a new ee_alloc_context struct which contains an instance of gc_alloc_context within it.
    
    The new ee_alloc_context::combined_limit should be used by fast allocation helpers to determine when to go down the slow path. Most of the time combined_limit has the same value as alloc_limit, but periodically we need to emit an allocation sampling event on an object that is somewhere in the middle of an AC. Using combined_limit rather than alloc_limit as the slow path trigger allows us to keep all the sampling event logic in the slow path.
    
    * PR feedback
    
    Co-authored-by: Jan Kotas <[email protected]>
    noahfalk and jkotas authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    588bc45 View commit details
    Browse the repository at this point in the history
  3. [wasm] Stop testing with V8 and wasmconsole (#108711)

    * Do not run tests with v8 scenario on CI. Leave code that supports running v8 scenario.
    
    * Remove console app, consolidate template base class, order inheritance, clean the code.
    
    * Fix build error: Keep all types of bundle options in `Common` dir.
    
    * Rename the param after merge with main.
    
    * Fix cast errors in providers.
    
    * Blazor and Browser bundle names got unified some time ago.
    
    * Fix running of browser published apps.
    
    * Fix the test transformed from console to browser.
    
    * Browser sdk does not allow appending RID.
    
    * Fix "item was already added" in build.
    ilonatommy authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    0290065 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7bf8802 View commit details
    Browse the repository at this point in the history
  5. Consolidate LocateNativeCompiler target (#103375)

    * Consolidate LocateNativeCompiler target
    
    * Set install_name on all Apple platforms
    
    ---------
    
    Co-authored-by: Jan Kotas <[email protected]>
    am11 and jkotas authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    c627f38 View commit details
    Browse the repository at this point in the history
  6. Vectorize codegen for left shift operator on byte vector (#108336)

    * Generate vectorized left shift for Vector128<Byte>
    
    * Use lower ISA instead
    
    * Expand for larger size vector widths
    
    * jit format
    
    * Move transformation to gtNewSimdBinOp
    
    * Remove conditional, use assert similar to GT_RSZ case
    
    * Fix missing semicolon
    
    * Use fgMakeMultiUse instead of gtCloneExpr, re-use previous shift count calculation
    
    * Consolidate GT_LSH path into same path as GT_RSZ
    
    * Use TYP_INT instead of TYP_SHORT for GT_LSH
    
    * Also only use CORINFO_TYPE_INT
    
    ---------
    
    Co-authored-by: Alex Covington (Advanced Micro Devices <[email protected]>
    Co-authored-by: Tanner Gooding <[email protected]>
    3 people authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    790a607 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cc8948a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7056bbd View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    def5e32 View commit details
    Browse the repository at this point in the history
  10. Remove static monitor helper functions (#107667)

    - Replace them with using the normal monitor helpers
    - Change CORINFO_HELP_GETSYNCFROMCLASSHANDLE to return an `object` instead of the underlying lock object, implementation of the JIT helper can be shared with other `TypeHandle` to `RuntimeType` scenarios
    - This will likely improve the performance of synchronized methods, but that is beside the point, since this feature is so rarely used
    davidwrighton authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    3001129 View commit details
    Browse the repository at this point in the history
  11. Automatically synthesize ilproj assembly names for tests (#108730)

    * Add -ANAME=xxx option to ilasm
    * Update IL SDK to add SynthesizeIlasmAssemblyName property
    * Update one test subfolder to use new property
    kg authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    2b4e823 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    4bb3219 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    9e1edb7 View commit details
    Browse the repository at this point in the history
  14. Merge remote-tracking branch 'runtime/main' into merge-oct-24

    # Conflicts:
    #	.github/policies/resourceManagement.yml
    #	eng/liveBuilds.targets
    #	eng/pipelines/runtimelab.yml
    #	src/coreclr/jit/compiler.h
    #	src/coreclr/tools/aot/ILCompiler.Compiler/IL/ILImporter.Scanner.cs
    #	src/tests/Common/Directory.Build.targets
    #	src/tests/Directory.Build.targets
    yowl committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    6ad4423 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. resolve conflicts

    Use LateNodeRef or EarlyNodeRef
    Always SetExpandedEarly even in Optimised builds
    Some formatting that keeps getting applied on save so presume it is wanted.
    Remove TestDynamicInterfaceCastable as it uses a thunk pool and uses RhGetCommonStubAddress which we haven't implemented.
    yowl committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    8e581c4 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. download package

    yowl committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    2cc121f View commit details
    Browse the repository at this point in the history
  2. revert and test

    yowl committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    da32e53 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. test

    yowl committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1f4c961 View commit details
    Browse the repository at this point in the history
  2. test

    yowl committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e6b4cdb View commit details
    Browse the repository at this point in the history
  3. test

    yowl committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    a303e3d View commit details
    Browse the repository at this point in the history
  4. test

    yowl committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    f0f2ee8 View commit details
    Browse the repository at this point in the history