Project graph restore #44322
Draft
Project graph restore #44322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet-watch loaded the msbuild project graph before restoring the project. Capabilities, such as
<ProjectCapability Include="WebAssembly" />is only added in a props file ofmicrosoft.net.sdk.webassembly.packpackage. If the project node from the graph loaded before restore is queried for capabilities, it will not have theWebAssemblycapability.This causes dotnet-watch to fail to apply changes to WASM.
The change moves project graph loading after project evaluation is performed and includes restore target in the evaluation.
The issue wasn't caught before by existing dotnet-watch WASM test because the test helpers always run
dotnet buildbefore testing dotnet-watch behavior. The change removes this pre-build step, so that tests validate the correct dotnet-watch behavior on non-restored projects by default.Fixes #44044