Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly set ContinueOnError for RemoveDir when cleaning repos #44434

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Correctly set ContinueOnError for RemoveDir when cleaning repos #44434

wants to merge 1 commit into from
+1 −1

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer requested review from a team as code owners October 24, 2024 14:17
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Oct 24, 2024
@ViktorHofer ViktorHofer enabled auto-merge (squash) October 24, 2024 14:17
@ViktorHofer
Copy link
Member Author

@akoeplinger let me know that this is the same as "true". We found out that because we invoke the VMR orchestrator with /warnaserror, the warning the again gets propagated to an error. That's weird and there's at tracking issue for that: dotnet/msbuild#2845

@ViktorHofer ViktorHofer marked this pull request as draft October 24, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@MichaelSimons MichaelSimons MichaelSimons approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ViktorHofer @akoeplinger @MichaelSimons