Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add System.Diagnostics.DiagnosticSource 9.0.0 #1101

Merged
merged 7 commits into from
Dec 20, 2024

Conversation

JanProvaznik
Copy link
Member

Needed for MSBuild telemetry investments. dotnet/msbuild#11169

  1. ./generate.sh --package System.Diagnostics.DiagnosticSource,9.0.0
  2. add DependencyPackageProjects to eng/Build.props

@JanProvaznik JanProvaznik requested a review from a team as a code owner December 20, 2024 13:53
@@ -6,6 +6,7 @@
<!-- runtime prebuilts. Update when runtime produces intermediate packages correctly. -->
<UsagePattern IdentityGlob="runtime.linux-x64.Microsoft.NETCore.ILAsm/*" />
<UsagePattern IdentityGlob="runtime.linux-x64.Microsoft.NETCore.ILDAsm/*" />
<UsagePattern IdentityGlob="Microsoft.NETCore.App.Ref/*9.0.0*" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be added. I think I know how to fix this and will push a fix.

@JanProvaznik
Copy link
Member Author

@dotnet/source-build I did quite weird stuff to get this PR green, please review how it should be done correctly.

  1. it failed upon seeing the scoped keywords in the generated files https://github.com/dotnet/source-build-reference-packages/pull/1101/checks?check_run_id=34712767234 fixed by: c48afa6 (#1101) c162c9b (#1101)
  2. It failed with error CS0518: Predefined type 'System.Runtime.CompilerServices.IsExternalInit' is not defined or imported https://github.com/dotnet/source-build-reference-packages/pull/1101/checks?check_run_id=34714580836 resolved by c162c9b (#1101)
  3. a prebuilt was reported for microsoft.netcore.app.ref which in fact exists in the repo https://github.com/dotnet/source-build-reference-packages/tree/main/src/targetPacks/ILsrc/microsoft.netcore.app.ref , resolved by 40967d8 (#1101)

@MichaelSimons
Copy link
Member

  1. a prebuilt was reported for microsoft.netcore.app.ref which in fact exists in the repo https://github.com/dotnet/source-build-reference-packages/tree/main/src/targetPacks/ILsrc/microsoft.netcore.app.ref , resolved by 40967d8 (#1101)

I think I took care of this in 1de36a7

@MichaelSimons
Copy link
Member

It failed with error CS0518: Predefined type 'System.Runtime.CompilerServices.IsExternalInit' is not defined or imported https://github.com/dotnet/source-build-reference-packages/pull/1101/checks?check_run_id=34714580836 resolved by c162c9b (#1101)

This is a known problem tracked with dotnet/source-build#4159. We have a common shared file with the type in it. I update the project to reference it.

@MichaelSimons MichaelSimons merged commit 44f3339 into dotnet:main Dec 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants