Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Hashtable/ArrayList in AccessKeyManager and remove locks #10000

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Replace Hashtable/ArrayList in AccessKeyManager and remove locks #10000

wants to merge 16 commits into from

Commits on Oct 16, 2024

  1. Swap _keyToElements from Hashtable to Dictionary<string, ArrayList>

    @h3xds1nz
    h3xds1nz committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    d9ef41d View commit details
    Browse the repository at this point in the history

  2. Replace ArrayList inside Dictionary with List<WeakReference>

    @h3xds1nz
    h3xds1nz committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a00140d View commit details
    Browse the repository at this point in the history

  3. Convert WeakReference as generic WeakReference<IInputElement>

    @h3xds1nz
    h3xds1nz committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    7e12246 View commit details
    Browse the repository at this point in the history

  4. Mark functions that could be static

    @h3xds1nz
    h3xds1nz committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b118221 View commit details
    Browse the repository at this point in the history

  5. Mark GetAccessKeyCharacter static as well

    @h3xds1nz
    h3xds1nz committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    ea8fdcd View commit details
    Browse the repository at this point in the history

  6. Remove locks for _keyToElements as instances of AccessKeyManager are … 

    …per thread
    @h3xds1nz
    h3xds1nz committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    3de643d View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Mark rest of the methods static and work off the thread variable

    @h3xds1nz
    h3xds1nz committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    72012c2 View commit details
    Browse the repository at this point in the history

  2. Simplify OnText/OnKeyDown

    @h3xds1nz
    h3xds1nz committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    1201064 View commit details
    Browse the repository at this point in the history

  3. Use pattern matching and remove CriticalGetActiveSource (identical me… 

    …thods)
    @h3xds1nz
    h3xds1nz committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    f515939 View commit details
    Browse the repository at this point in the history

  4. Rewrite AccessKeyInformation as immutable readonly struct

    @h3xds1nz
    h3xds1nz committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    936119a View commit details
    Browse the repository at this point in the history

  5. Remove redundant usings

    @h3xds1nz
    h3xds1nz committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    faf134d View commit details
    Browse the repository at this point in the history

  6. Mark PostProcessInput as static too

    @h3xds1nz
    h3xds1nz committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    81a845b View commit details
    Browse the repository at this point in the history

  7. Mark fields in events readonly, one last pattern-match

    @h3xds1nz
    h3xds1nz committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    edc2692 View commit details
    Browse the repository at this point in the history

  8. Simplify IsTargetable

    @h3xds1nz
    h3xds1nz committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    330dfc4 View commit details
    Browse the repository at this point in the history

  9. Strongly type in PurgeDead

    @h3xds1nz
    h3xds1nz committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    32d89ed View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2024

  1. Remove a null check that we don't need

    @h3xds1nz
    h3xds1nz committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    4930266 View commit details
    Browse the repository at this point in the history