fix span kind

src/Mocha.Core/Models/Trace/MochaSpanKind.cs

@@ -6,9 +6,9 @@ namespace Mocha.Core.Models.Trace;
 public enum MochaSpanKind
 {
     Unspecified = 0,
-    Client = 1,
+    Internal = 1,
     Server = 2,
-    Internal = 3,
+    Client = 3,
     Producer = 4,
     Consumer = 5
 }

src/Mocha.Core/Storage/Jaeger/Trace/JaegerSpanKind.cs

@@ -0,0 +1,14 @@
+// Licensed to the .NET Core Community under one or more agreements.
+// The .NET Core Community licenses this file to you under the MIT license.
+
+namespace Mocha.Core.Storage.Jaeger.Trace;
+
+public static class JaegerSpanKind
+{
+    public const string Unspecified = "unspecified";
+    public const string Internal = "internal";
+    public const string Server = "server";
+    public const string Client = "client";
+    public const string Producer = "producer";
+    public const string Consumer = "consumer";
+}

src/Mocha.Storage/EntityFrameworkCore/Jaeger/EFToJaegerSpanConversionExtensions.cs

@@ -55,11 +55,10 @@ public static IEnumerable<JaegerTrace> ToJaegerTraces(
             .GroupBy(s => s.TraceID)
             .Select(g =>
             {
-                var spans = g.ToArray();
-
+                var spansOfCurrentTrace = g.ToArray();
                 var jaegerProcesses = new List<JaegerProcess>();
 
-                foreach (var span in spans)
+                foreach (var span in spansOfCurrentTrace)
                 {
                     resourceAttributesBySpanId.TryGetValue(span.SpanID, out var attributes);
                     attributes ??= Array.Empty<EFResourceAttribute>();
@@ -80,7 +79,7 @@ public static IEnumerable<JaegerTrace> ToJaegerTraces(
                     Processes = jaegerProcesses
                         .DistinctBy(p => p.ProcessID)
                         .ToDictionary(p => p.ProcessID),
-                    Spans = spans
+                    Spans = spansOfCurrentTrace
                 };
             });
 
@@ -115,7 +114,7 @@ private static IEnumerable<JaegerSpan> ToJaegerSpans(
                             RefType = JaegerSpanReferenceType.ChildOf,
                         }
                     ],
-                Tags = spanAttributes.Select(ToJaegerTag).ToArray(),
+                Tags = spanAttributes.ToJaegerSpanTags(span).ToArray(),
                 Logs = spanEvents.ToJaegerSpanLogs(spanEventAttributes).ToArray()
             };
 
@@ -135,6 +134,28 @@ private static JaegerTag ToJaegerTag(this AbstractEFAttribute attribute)
         return jaegerTag;
     }
 
+    private static IEnumerable<JaegerTag> ToJaegerSpanTags(
+        this IEnumerable<EFSpanAttribute> spanAttributes,
+        EFSpan span)
+    {
+        if (span.StatusCode == EFSpanStatusCode.Error)
+        {
+            yield return new JaegerTag { Key = "error", Type = JaegerTagType.Bool, Value = true };
+        }
+
+        yield return new JaegerTag
+        {
+            Key = "span.kind",
+            Type = JaegerTagType.String,
+            Value = span.SpanKind.ToJaegerSpanKind()
+        };
+
+        foreach (var attribute in spanAttributes)
+        {
+            yield return attribute.ToJaegerTag();
+        }
+    }
+
     private static IEnumerable<JaegerSpanLog> ToJaegerSpanLogs(
         this IEnumerable<EFSpanEvent> spanEvents,
         IEnumerable<EFSpanEventAttribute> spanEventAttributes)
@@ -175,6 +196,16 @@ private static IEnumerable<JaegerSpanLog> ToJaegerSpanLogs(
         _ => throw new ArgumentOutOfRangeException()
     };
 
+    private static string ToJaegerSpanKind(this EFSpanKind spanKind) => spanKind switch
+    {
+        EFSpanKind.Unspecified => JaegerSpanKind.Unspecified,
+        EFSpanKind.Internal => JaegerSpanKind.Internal,
+        EFSpanKind.Server => JaegerSpanKind.Server,
+        EFSpanKind.Client => JaegerSpanKind.Client,
+        EFSpanKind.Producer => JaegerSpanKind.Producer,
+        EFSpanKind.Consumer => JaegerSpanKind.Consumer,
+    };
+
     private static object ConvertTagValue(this EFAttributeValueType valueType, string value) => valueType switch
     {
         EFAttributeValueType.StringValue => value,

src/Mocha.Storage/EntityFrameworkCore/Trace/EFSpanKind.cs

@@ -6,9 +6,9 @@ namespace Mocha.Storage.EntityFrameworkCore.Trace;
 public enum EFSpanKind
 {
     Unspecified = 0,
-    Client = 1,
+    Internal = 1,
     Server = 2,
-    Internal = 3,
+    Client = 3,
     Producer = 4,
     Consumer = 5
 }