Bump actions/setup-java from 3 to 4 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
This is only available in Scala 2.13 because it makes use of productElementNames. The behaviour is unchanged in Scala 2.11/2.12.
[WIP] Include field names in rendering of Product (Scala 2.13 only)
Co-authored-by: Anatolii Kmetiuk <[email protected]>
Co-authored-by: Anatolii Kmetiuk <[email protected]>
Dotty initial support
Fix printing of annotated type
Bump Dotty to 0.27.0-RC1
Support Scala 3 on Scala.js
- Remove parallelism from CI which is flaky
Publish for Scala 2.11
….0.0-RC3 Upgrade Dotty to 3.0.0-RC3
Create release on GitHub when releasing to Maven
Support Scala 3.0.0
Link to documentation was broken
Make pprint robust against toString method returning null, fixes com-lihaoyi/Ammonite#1113 Review by @lolgab @anatoliykmetyuk
…guration (com-lihaoyi#71) Supersedes com-lihaoyi#55 the new `escapeUnicode` flag defaults to `false`, since unicode characters are common enough nowadays we should expect editors and other UIs to render them without issue. Someone who wants the old behavior can always manually set it to `true` `showFieldNames` was added in a kind of awkward manner to avoid breaking backwards binary compatibility. It's been long enough that I think a breakage is ok, so I'm moving it to be a default argument like the rest of our pprint configuration values
This fixes com-lihaoyi#28 We had a similar problem while pprinting `akka.kafka.ConsumerMessage.CommittableMessage`. I found that the problem is reproduced when `Product2` is used. `Walker.scala:90` calls `Util.isOperator(x.productPrefix)`, but `Product` defines it as an empty string : ``` def productPrefix = "" ``` So `ident(0)` in `Util.scala:50` fails with `java.lang.StringIndexOutOfBoundsException` I've added a unit test and my proposition of a fix.
Fixes com-lihaoyi/Ammonite#221 Fixes com-lihaoyi/Ammonite#629 Fixes com-lihaoyi/Ammonite#670 Fixes com-lihaoyi#45 Fixes com-lihaoyi#44 The old TPrint implementation did a clever thing where it allowed a user to over-ride the TPrinting of a given type by providing an appropriate implicit. While that worked in most cases, it was fiendishly complex, and the intricate nesting of implicit resolution and macro resolution ended up providing and endless source of hard to resolve bugs. This new implementation is much simpler and less flexible: we simply walk the type data structure in the macro, and spit out a colored `fansi.Str` with the type names hard-coded to `fansi.Green`. The only runtime support necessary is in the `def recolor` function, which parses the incoming `fansi.Str` and replaces the hardcoded `fansi.Green` colors with whatever is specified by the implicit `TPrintColors`. As implicits cannot be used to override tprinting anymore, we now have hardcoded support for tprinting functions and tuples. While the old macro generated a complex tree of Scala function calls that is evaluated to generate the output `fansi.Str` at runtime, the new macro simply spits out a single `fansi.Str` that is serialized into a `java.lang.String` and deserialized back into a `fansi.Str` for usage at runtime. We propagate a `WrapType` enumeration up the recursion, to help the callers decide if they need to wrap things in parens or not. This gives up a bit of flexibility, but AFAIK nobody was really using that flexibility anyway. In exchange, we fix a whole bunch of long-standing bugs, and have a drastically simpler implementation. The fixed bugs are covered by regression unit tests added to `TPrintTests.scala`. All existing tests also pass, so hopefully that'll catch any potential regressions. There's probably more bugs where we're not properly setting or handling the `WrapType`, but exhaustively testing/surfacing/fixing all of those is beyond the scope of this PR. For now, I just kept the current set of tests passing. Managed to get the Scala3 side working. I didn't realize how half-baked the Scala3 implementation of TPrint is; so much of the Scala2 functionality just isn't implemented and doesn't work. Nevertheless, fixing that is beyond the scope of this PR. I just kept it green with the existing set of green tests passing (except for the custom tprinter test, which is no longer applicable) Review by @lolgab.
Updates the readme, pulls in latest version of Fansi 0.3.0, and updates the code accordingly
…i#75) TPrinting of constant types regressed in 0.8.0, while PPrinting of booleans was always missing the colors that they should have had. This PR fixes both and adds a unit test to avoid regression
Logging to stderr rather than stdout.
* Support Scala 3 - Scala Native - Avoid running the Github Action workflow twice on PRs * Bump Scala Native to 0.4.4 * Skip Mima check for missing artifact
* Add PolyType to TPrintImpl * Add TPrint test for polytype * Tweak based on PR feedback * Allow Polytypes to be different on 2.12 vs 2.13
* deps: update all sorts of stuff This pr goes through and makes the various updates: - Bumps mill to the latest 0.10.5 - Bumps to the latest Scala versions for 2 and latest 3.1.x version - Drops 0.x support for ScalaJS - Move Scala native to 0.4.x - Adds in dependabot - Starts to cross test on 8 and 17 - Updates checkout and java actions * add issue filter for StringPrefix.apply * dep: update utest to 0.8.0
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3 to 4. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v3...v4) --- updated-dependencies: - dependency-name: actions/setup-java dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps actions/setup-java from 3 to 4.
Release notes
Sourced from actions/setup-java's releases.
... (truncated)
Commits
387ac29Upgrade Node to v20 (#558)9eda6b5feat: implement cache-dependency-path option to control caching dependency (#...78078daUpdate@actions/cachedependency and documentation (#549)5caaba6add support for microsoft openjdk 21.0.0 (#546)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)