-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Added skip_ssl_verify setting to OX push driver #191
base: main
Are you sure you want to change the base?
Conversation
6735c52
to
5649dea
Compare
Hi. You should probably use lua driver instead of modifying this driver, as it is heavily interdependent on Open-Xchange Appsuite. Also, if you want to do this, I would recommend adding the certificate (or CA cert) to your system store instead. |
In my opinion, using lua scripts is actually adding new point of errors. This is not necessary for just disabling ssl verification.
In my case it's unavailable option. |
1f9dcc3
to
83782ca
Compare
We're not much changing v2.3 anymore, and I'm planning on doing larger changes to v2.4 configuration handling which will make this possible in a generic way. |
As I see you are planning to do changes that will solve my problem. |
83782ca
to
73101fb
Compare
I mean, unless something unexpected happens, the first v2.4 release will have this solved in a different way (any ssl setting can be specified in any context). I'm actively working on the config rewrite now. |
Could you clarify when the release of v2.4 is expected? The last release was almost half a year ago. |
There is no schedule for now. Not anytime soon. |
Based on this information, I can only insist on applying this patch. |
This is WIP patch, I didn't tested it yet.
Updates about tests will be provided later.
I'll update documentation after this PR will be merged.