Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DDS-1724] Updated mailhog base image ref. #209

Merged
merged 3 commits into from
Oct 17, 2023
Merged

[DDS-1724] Updated mailhog base image ref. #209

merged 3 commits into from
Oct 17, 2023

Conversation

GROwen
Copy link
Contributor

@GROwen GROwen commented Oct 17, 2023 •
edited
Loading

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

Explain the details for making this change. What existing problem does the pull request solve?

Changelog Entry

Updates the Mailhog images upstream image tag to match the major version instead of minor.

@GROwen GROwen self-assigned this Oct 17, 2023
@GROwen GROwen marked this pull request as ready for review October 17, 2023 02:46
@GROwen GROwen added the NEEDS REVIEW Good for newcomers label Oct 17, 2023
@GROwen
Copy link
Contributor Author

GROwen commented Oct 17, 2023

@nicksantamaria this has been tested in DDS-1724

vincent-gao
vincent-gao approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@vincent-gao vincent-gao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it and it is functioning perfectly.

@GROwen GROwen merged commit 44802bf into 5.x Oct 17, 2023
9 checks passed
@GROwen GROwen deleted the build/DDS-1724--update-alpine branch October 17, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincent-gao vincent-gao vincent-gao approved these changes

@nicksantamaria nicksantamaria Awaiting requested review from nicksantamaria

Assignees

@GROwen GROwen

Labels
NEEDS REVIEW Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GROwen @vincent-gao