Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proof of concept - captcha support #1305

Closed
wants to merge 1 commit into from
Closed

Proof of concept - captcha support #1305

wants to merge 1 commit into from

Conversation

jeffdowdle
Copy link
Contributor

Issue:

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@jeffdowdle jeffdowdle added DO NOT MERGE WIP Early preview labels Aug 27, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 27, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 4c4f517
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/66cd352b74718e00088947a3

@cypress Cypress
Copy link

cypress bot commented Aug 27, 2024

ripple-framework    Run #2172

Run Properties:  status check failed Failed #2172  •  git commit 4c4f5172c8: feat: added proof of concept for captcha support
Project ripple-framework
Branch Review experiment/captcha
Run status status check failed Failed #2172
Run duration 08m 45s
Commit git commit 4c4f5172c8: feat: added proof of concept for captcha support
Committer Jeffrey Dowdle
View all properties for this run ↗︎
Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 186
View all changes introduced in this branch ↗︎

Tests for review

Failed  test/features/landingpage/forms.feature • 2 failed tests

View Output

Test Artifacts
Forms > Form submission - Error Test Replay Screenshots
Forms > Form submission - Success Test Replay Screenshots

@dylankelly
Copy link
Contributor

Closing in favour of finished solution in another PR

@dylankelly dylankelly closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DO NOT MERGE WIP Early preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffdowdle @dylankelly