Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/2.15.0 #1307

Merged
merged 31 commits into from
Sep 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
4c16b66
fix(@dpc-sdp/ripple-ui-core): add default timeZone for formatDate
Aug 13, 2024
34bfabf
fix(@dpc-sdp/ripple-tide-landing-page): use getLinkFromField function…
Aug 15, 2024
dccdfa1
fix(@dpc-sdp/ripple-tide-landing-page): hydration mismatch error on c…
Aug 15, 2024
9e18f07
Merge pull request #1293 from dpc-sdp/bugfix/format-date
dylankelly Aug 16, 2024
d8a2fca
Merge pull request #1295 from dpc-sdp/bugfix/carousel-event-card-link
dylankelly Aug 16, 2024
ac19c27
Merge pull request #1296 from dpc-sdp/bugfix/tide-card-content
dylankelly Aug 16, 2024
ce7d68d
feat(@dpc-sdp/ripple-tide-search): allow setting a defaultExtent valu…
Aug 19, 2024
afee797
fix(@dpc-sdp/ripple-tide-search): first map results hook firing befor…
Aug 19, 2024
442670e
fix(@dpc-sdp/ripple-ui-maps): update map imports
Aug 20, 2024
bbd20c6
Merge pull request #1297 from dpc-sdp/feature/default-extent
dylankelly Aug 20, 2024
d21a990
Merge branch 'release/2.15.0' into bugfix/initial-map-results-hook
Aug 20, 2024
3a00469
fix(@dpc-sdp/ripple-tide-api): fixed site section sometimes not displ…
jeffdowdle Aug 20, 2024
ccaf4af
test(@dpc-sdp/ripple-tide-api): fixed broken site section nav tests
jeffdowdle Aug 20, 2024
a3238e4
fix(@dpc-sdp/ripple-ui-maps): update map snapshot
Aug 21, 2024
d3d64f9
chore(@dpc-sdp/ripple-tide-search): pin es dependency versions
dylankelly Aug 21, 2024
9a4757b
feat(@dpc-sdp/ripple-tide-search): added 'hideResultsCount' option to…
jeffdowdle Aug 21, 2024
3c5696c
fix(@dpc-sdp/ripple-ui-core): remove RTL 'before' list styles
Aug 21, 2024
6c053fe
Merge pull request #1299 from dpc-sdp/bugfix/SD-152-side-menu-fix
jeffdowdle Aug 22, 2024
b816389
Merge pull request #1298 from dpc-sdp/bugfix/initial-map-results-hook
lambry Aug 22, 2024
cb1e45f
Merge pull request #1302 from dpc-sdp/bugfix/rtl-lists
lambry Aug 22, 2024
e8f728a
build: :green_heart: update lockfile
waitingallday Aug 22, 2024
236da21
Merge pull request #1301 from dpc-sdp/feature/SD-103-hide-results-count
jeffdowdle Aug 22, 2024
05ccc8c
fix(@dpc-sdp/ripple-ui-maps): move isFullScreen check and add support…
Aug 23, 2024
e10bd47
chore(@dpc-sdp/nuxt-ripple-cli): remove pinned es versions
dylankelly Aug 26, 2024
194db31
Merge pull request #1303 from dpc-sdp/bugfix/map-fullscreen-btn
dylankelly Aug 26, 2024
32fe253
Merge pull request #1300 from dpc-sdp/feature/es-version-pin
dylankelly Aug 27, 2024
d2a581d
feat(@dpc-sdp/nuxt-ripple-analytics): add new print event
Aug 27, 2024
1f7e687
feat(@dpc-sdp/ripple-tide-search): added additional functional needed…
jeffdowdle Aug 27, 2024
e09c7a8
Merge pull request #1304 from dpc-sdp/feature/print-event
dylankelly Aug 27, 2024
9bd4182
Merge pull request #1306 from dpc-sdp/feature/SD-102-kyc-map-support
jeffdowdle Aug 28, 2024
3e1a5e4
chore: 🔖 release ripple 2.15.0
dylankelly Aug 29, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,49 @@
# Changelog

## v2.15.0

[compare changes](https://github.com/dpc-sdp/ripple-framework/compare/2.14.0...v2.15.0)


### 🚀 Enhancements

- **@dpc-sdp/ripple-tide-search:** Allow setting a defaultExtent value for maps ([ce7d68d77](https://github.com/dpc-sdp/ripple-framework/commit/ce7d68d77))
- **@dpc-sdp/ripple-tide-search:** Added 'hideResultsCount' option to custom collection ([9a4757bf0](https://github.com/dpc-sdp/ripple-framework/commit/9a4757bf0))
- **@dpc-sdp/nuxt-ripple-analytics:** Add new print event ([d2a581dea](https://github.com/dpc-sdp/ripple-framework/commit/d2a581dea))
- **@dpc-sdp/ripple-tide-search:** Added additional functional needed for KYC map migration ([1f7e68727](https://github.com/dpc-sdp/ripple-framework/commit/1f7e68727))

### 🩹 Fixes

- **@dpc-sdp/ripple-ui-core:** Add default timeZone for formatDate ([4c16b66b1](https://github.com/dpc-sdp/ripple-framework/commit/4c16b66b1))
- **@dpc-sdp/ripple-tide-landing-page:** Use getLinkFromField function for carousel events ([34bfabf2f](https://github.com/dpc-sdp/ripple-framework/commit/34bfabf2f))
- **@dpc-sdp/ripple-tide-landing-page:** Hydration mismatch error on card content ([dccdfa1ce](https://github.com/dpc-sdp/ripple-framework/commit/dccdfa1ce))
- **@dpc-sdp/ripple-tide-search:** First map results hook firing before map is ready ([afee797a4](https://github.com/dpc-sdp/ripple-framework/commit/afee797a4))
- **@dpc-sdp/ripple-ui-maps:** Update map imports ([442670ea1](https://github.com/dpc-sdp/ripple-framework/commit/442670ea1))
- **@dpc-sdp/ripple-tide-api:** Fixed site section sometimes not displaying correct active page ([3a00469d7](https://github.com/dpc-sdp/ripple-framework/commit/3a00469d7))
- **@dpc-sdp/ripple-ui-maps:** Update map snapshot ([a3238e433](https://github.com/dpc-sdp/ripple-framework/commit/a3238e433))
- **@dpc-sdp/ripple-ui-core:** Remove RTL 'before' list styles ([3c5696cb2](https://github.com/dpc-sdp/ripple-framework/commit/3c5696cb2))
- **@dpc-sdp/ripple-ui-maps:** Move isFullScreen check and add supportsFullScreen ([05ccc8c10](https://github.com/dpc-sdp/ripple-framework/commit/05ccc8c10))

### 📦 Build

- 💚 update lockfile ([e8f728a28](https://github.com/dpc-sdp/ripple-framework/commit/e8f728a28))

### 🏡 Chore

- **@dpc-sdp/ripple-tide-search:** Pin es dependency versions ([d3d64f943](https://github.com/dpc-sdp/ripple-framework/commit/d3d64f943))
- **@dpc-sdp/nuxt-ripple-cli:** Remove pinned es versions ([e10bd47d7](https://github.com/dpc-sdp/ripple-framework/commit/e10bd47d7))

### ✅ Tests

- **@dpc-sdp/ripple-tide-api:** Fixed broken site section nav tests ([ccaf4af87](https://github.com/dpc-sdp/ripple-framework/commit/ccaf4af87))

### ❤️ Contributors

- Jeffrey Dowdle <[email protected]>
- David Featherston <[email protected]>
- Dylankelly <[email protected]>
- Jason Smith <[email protected]>

## v2.14.0

[compare changes](https://github.com/dpc-sdp/ripple-framework/compare/v2.13.1...v2.14.0)
Expand Down
16 changes: 16 additions & 0 deletions examples/nuxt-app/app.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,22 @@ export default defineAppConfig({
return '#333333'
}
}
},
mapResultHooks: {
exampleMapResultsHook: (map, results, locationQuery) => {
if (!map || !results || !locationQuery) return

centerMap(
map,
[
parseFloat(locationQuery?.center[0]),
parseFloat(locationQuery?.center[1])
],
13,
{},
'popover'
)
}
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,3 +115,13 @@ Feature: Custom Collection
When I visit the page "/filter-only"
Then the custom collection component results count should read "Displaying 1-20 of 282 results"
And only the search filters should be visible

@mockserver
Example: Should hide results count when hideResultsCount is set
Given I load the page fixture with "/landingpage/custom-collection/page"
And the custom collection results count has been hidden
And the search network request is stubbed with fixture "/landingpage/custom-collection/response" and status 200
Then the page endpoint for path "/filter-only" returns the loaded fixture

When I visit the page "/filter-only"
Then the custom collection component results count should be hidden
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
Feature: Site section navigation

Example of the site section navigation in the landing page sidebar

Background:
Given the page endpoint for path "/level-2-2" returns fixture "/landingpage/site-section-nav" with status 200
And the site endpoint returns fixture "/site/reference" with status 200

@mockserver
Scenario: Nested item active
When I visit the page "/level-2-2"
Then the site section nav should contain the following level 1 items:
| text | url |
| Level 1 - 1 | /level-1-1 |
| Level 1 - 2 | /level-1-2 |

Then the site section nav item with label "Level 1 - 1" should be expanded
Then the site section nav item with label "Level 1 - 2" should be collapsed

Then the site section nav item with label "Level 1 - 1" should be inactive
Then the site section nav item with label "Level 2 - 2" should be active
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
34 changes: 34 additions & 0 deletions examples/nuxt-app/test/features/maps/maps.feature
Original file line number Diff line number Diff line change
Expand Up @@ -97,3 +97,37 @@ Feature: Custom collection map component
Given I click the side panel item with text "Single Pin Test"
When I wait 2 seconds
Then the map matches the image snapshot "map-sidepanel-item-click"

@mockserver
Scenario: Map zooms to intended initial location with results hook
Given I load the page fixture with "/maps/basic-page"
And a custom map results hook called "exampleMapResultsHook" is used
Then the page endpoint for path "/map" returns the loaded fixture
And the "/api/tide/elasticsearch/elasticsearch_index_develop_node/_search" network request is stubbed with fixture "/maps/simple-map-results" and status 200 as alias "searchReq"
Given I visit the page "/map?location[center]=15809362.126037747&location[center]=-4543542.166789566"
When I wait 2 seconds
Then the map matches the image snapshot "map-initial-location-results-hook"

@mockserver
Scenario: Map zooms to intended custom default extent
Given I load the page fixture with "/maps/basic-page"
And the following default extent is used
| minx | miny | maxx | maxy |
| 15981434.752845502 | -4584261.14712816 | 16186285.988645602 | -4381244.400003005 |
Then the page endpoint for path "/map" returns the loaded fixture
And the "/api/tide/elasticsearch/elasticsearch_index_develop_node/_search" network request is stubbed with fixture "/maps/simple-map-results" and status 200 as alias "searchReq"
Given I visit the page "/map"
And I wait 2 seconds
Then the map matches the image snapshot "map-custom-default-extent"

@mockserver
Scenario: Map can be viewed fullscreen
Given I load the page fixture with "/maps/basic-page"
And the page endpoint for path "/map" returns the loaded fixture
And I visit the page "/map"
When I click the view fullscreen button
And I wait 100 milliseconds
Then the map should be fullscreen
When I click the exit fullscreen button
And I wait 100 milliseconds
Then the map should not be fullscreen
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ Feature: Publication page
| title | url | type | size |
| Victorian Skills Plan Implementation Update October 2023 | /sites/default/files/2023-10/16686-VSA-Implementation-Plan-Section_FA_Digital.pdf | pdf | 4.61 MB |
| Print full document | /victorian-skills-plan-2023-implementation-update/print-all | | |
When I click on the document "Print full document"
Then the dataLayer should include the following events
| event | element_text | link_url | component |
| print_document | Print full document | /victorian-skills-plan-2023-implementation-update/print-all | rpl-document |

@mockserver
Example: Publication print all
Expand Down
Loading