Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

[SRM-14] : Fix entityQuery condition #31

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[SRM-14] : Fix entityQuery condition #31

wants to merge 3 commits into from

Conversation

FleetAdmiralButter
Copy link
Contributor

@FleetAdmiralButter FleetAdmiralButter commented Jul 23, 2021 •
edited
Loading

Changed:

  1. Optimises the query so that only tide_news bundles with a populated body.summary are returned.

@FleetAdmiralButter FleetAdmiralButter self-assigned this Jul 23, 2021
GROwen
GROwen suggested changes Jul 23, 2021
View reviewed changes
tide_news.install Outdated
@@ -130,7 +130,7 @@ function tide_news_update_8003(&$sandbox) {
$sandbox['#finished'] = $count ? 0 : 1;
}

$batch_size = 10;
$batch_size = 100;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Altering deployed update hooks is a bad idea.

Because this change is going to be Premier specific you could create a patch using GitHub and reference it in the root composer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep @GROwen , I won't merge this, I opened this to create the .diff to include in the project.

@vincent-gao
Copy link
Contributor

LGTM @FleetAdmiralButter , but $batch_size = 100; seems unnecessary~

@FleetAdmiralButter FleetAdmiralButter changed the title [SRM-14] : Increases batch size [SRM-14] : Fix entityQuery condition Jul 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GROwen GROwen GROwen requested changes

@anthony-malkoun anthony-malkoun Awaiting requested review from anthony-malkoun

@MdNadimHossain MdNadimHossain Awaiting requested review from MdNadimHossain

At least 1 approving review is required to merge this pull request.

Assignees

@FleetAdmiralButter FleetAdmiralButter

Labels
DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FleetAdmiralButter @vincent-gao @GROwen