Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport/v2.1 parse image pull auth from env #1381

Merged
merged 4 commits into from
Jul 30, 2023
Merged

Backport/v2.1 parse image pull auth from env #1381

merged 4 commits into from
Jul 30, 2023

Conversation

sctb512
Copy link
Contributor

@sctb512 sctb512 commented Jul 21, 2023

This commit attempts to avoid loading auth from the nydusd configuration file, which is insecure for users. The auth loaded from env will overwrite the auth loaded from file if it is not null.

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@sctb512 sctb512 mentioned this pull request Jul 21, 2023
Open
@sctb512 sctb512 force-pushed the backport/v2.1/get-auth-from-env branch from 37c896f to 2a899b1 Compare July 21, 2023 11:47
@anolis-bot
Copy link
Collaborator

@sctb512 , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/86138

@anolis-bot
Copy link
Collaborator

@sctb512 , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@sctb512 sctb512 force-pushed the backport/v2.1/get-auth-from-env branch from 2a899b1 to 50b3d83 Compare July 21, 2023 12:01
@anolis-bot
Copy link
Collaborator

@sctb512 , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/86141

@anolis-bot
Copy link
Collaborator

@sctb512 , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS

Congratulations, your test job passed!

@sctb512 sctb512 force-pushed the backport/v2.1/get-auth-from-env branch from 50b3d83 to 548cfed Compare July 24, 2023 08:15
@anolis-bot
Copy link
Collaborator

@sctb512 , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/86617

@anolis-bot
Copy link
Collaborator

@sctb512 , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS

Congratulations, your test job passed!

@sctb512 sctb512 force-pushed the backport/v2.1/get-auth-from-env branch 2 times, most recently from c7da91b to 7696576 Compare July 24, 2023 09:10
@anolis-bot
Copy link
Collaborator

@sctb512 , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/86626

@anolis-bot
Copy link
Collaborator

@sctb512 , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/86627

@anolis-bot
Copy link
Collaborator

@sctb512 , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS

Congratulations, your test job passed!

@anolis-bot
Copy link
Collaborator

@sctb512 , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS

Congratulations, your test job passed!

@anolis-bot
Copy link
Collaborator

@sctb512 , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/86731

@anolis-bot
Copy link
Collaborator

@sctb512 , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS

Congratulations, your test job passed!

@sctb512 sctb512 force-pushed the backport/v2.1/get-auth-from-env branch from b8a7510 to c1e1d79 Compare July 26, 2023 07:38
@anolis-bot
Copy link
Collaborator

@sctb512 , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/87035

@sctb512 sctb512 force-pushed the backport/v2.1/get-auth-from-env branch from c1e1d79 to 37ba925 Compare July 26, 2023 08:26
@anolis-bot
Copy link
Collaborator

@sctb512 , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/87046

@sctb512
nydusd: parse image pull auth from env
1d4e596 
This commit attempts to avoid loading auth from the nydusd configuration
file, which is insecure for users. The auth loaded from env will
overwrite the auth loaded from file if it is not null.

Signed-off-by: Bin Tang <[email protected]>
@sctb512
fs: add test for filling auth
684206b 
Signed-off-by: Bin Tang <[email protected]>
@sctb512
docs: introduce IMAGE_PULL_AUTH env
07c683c 
Signed-off-by: Bin Tang <[email protected]>
@sctb512
cargo: update Cargo.toml to solve deny error
dad454c 
Signed-off-by: Bin Tang <[email protected]>
@sctb512 sctb512 force-pushed the backport/v2.1/get-auth-from-env branch from 37ba925 to dad454c Compare July 26, 2023 08:31
@anolis-bot
Copy link
Collaborator

@sctb512 , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/87049

@anolis-bot
Copy link
Collaborator

@sctb512 , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS

Congratulations, your test job passed!

@anolis-bot
Copy link
Collaborator

@sctb512 , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS

Congratulations, your test job passed!

@anolis-bot
Copy link
Collaborator

@sctb512 , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS

Congratulations, your test job passed!

@jiangliu jiangliu merged commit 3f3a94d into dragonflyoss:stable/v2.1 Jul 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiangliu jiangliu jiangliu approved these changes

Assignees
No one assigned
Labels
anolis_test_pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sctb512 @anolis-bot @jiangliu