Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove ctr-remote and use nerdctl #1623

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

Desiki-high
Copy link
Member

@Desiki-high Desiki-high commented Sep 19, 2024

Relevant Issue (if applicable)

close #1190
close #661

Details

Nerdctl is more useful than ctr-remote, deprecate it.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@Desiki-high Desiki-high requested review from a team as code owners September 19, 2024 06:53
@Desiki-high Desiki-high requested review from liubogithub, imeoer, jiangliu and power-more and removed request for a team September 19, 2024 06:53
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.24%. Comparing base (37a7b96) to head (2748f22).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1623      +/-   ##
==========================================
- Coverage   61.28%   61.24%   -0.05%     
==========================================
  Files         146      146              
  Lines       48156    48156              
  Branches    46123    46123              
==========================================
- Hits        29513    29493      -20     
- Misses      17085    17100      +15     
- Partials     1558     1563       +5     

see 6 files with indirect coverage changes

@Desiki-high Desiki-high force-pushed the remove-contrib/ctr-remote branch 3 times, most recently from 00d86ad to 68b0c18 Compare September 19, 2024 08:22
@Desiki-high Desiki-high changed the title chore: remove contrib/ctr-remote chore: remove contrib/ctr-remote and use nerdctl Sep 19, 2024
@Desiki-high Desiki-high changed the title chore: remove contrib/ctr-remote and use nerdctl chore: remove ctr-remote and use nerdctl Sep 19, 2024
Nerdctl is more useful than `ctr-remote`, deprecate it.

Signed-off-by: Yadong Ding <[email protected]>
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thanks!

@imeoer imeoer merged commit 9f439ab into dragonflyoss:master Sep 25, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ctr-remote is poorly maintained and currently uses many deprecated APIs ctr-remote image rpull error
2 participants