Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix foreign key comparison case sensitive #282

Merged
merged 2 commits into from
Oct 27, 2024

Conversation

ruizhii
Copy link
Contributor

@ruizhii ruizhii commented Oct 27, 2024

SQL keywords are case insensitive although they are often written in all caps. Object return from node-sql-parser is actually case sensitive based on the imported sql, thus "foreign key" doesn't work as expected.

Fix #276

SQL keywords are case insensitive although they are often written in all caps. Object return from node-sql-parser is actually case sensitive based on the imported sql, thus "foreign key" doesn't work as expected.
Copy link

vercel bot commented Oct 27, 2024

@bitlab-ruizhi is attempting to deploy a commit to the dottle's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@1ilit 1ilit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. Can you also fix it in the other import files?

@ruizhii
Copy link
Contributor Author

ruizhii commented Oct 27, 2024

No worries, below are all fixed

  • mariadb
  • mssql
  • mysql
  • postgres
  • sqlite

Copy link

vercel bot commented Oct 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drawdb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2024 1:44pm

@1ilit
Copy link
Member

1ilit commented Oct 27, 2024

Perfect, thank you!

@1ilit 1ilit merged commit 35d55a0 into drawdb-io:main Oct 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] import and get wrong relations
2 participants