This repository has been archived by the owner on Feb 22, 2020. It is now read-only.
#229 Fix identification on LUNA #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, can you clarify/fixup the "WIP" commit, and perhaps rebase to avoid that merge commit? *g* |
lamby
reviewed
Nov 27, 2017
tests/test_docker.sh
Outdated
|
|
||
| docker-compose -f local.yml run prediction pytest -rsx src/tests/test_identification.py | ||
|
|
||
| docker-compose -f local.yml run prediction pytest -rsx |
WGierke
force-pushed
the
229_fix_identification_luna
branch
from
a585fa8
to
a653146
Compare
|
@lamby Done. I changed test_docker for faster testing purposes, but that has been reverted again :) Shouldn't have commited that. |
Amateur! |
4 tasks
|
I really appreciate your offer to run the identification tests on your machine and to send me possible occurring stack traces @lamby ! 😁 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the identification of LUNA nodules as far as it gets on my machine. This means that currently all tests in
src/tests/test_identification.pyare failing for me since I don't have 21 GB of RAM (if RUN_SLOW_TESTS is set to true). Maybe someone else can execute them and send me tracebacks for further error investigation?Description
The problem was that sometimes the direct path to a MHD file was handed to the function instead of the path to the directory. The made changes should support now both alternatives.
Reference to official issue
This addresses #229 - identification test(s) should pass for luna scans.
How Has This Been Tested?
I added the test given in #229 .
CLA