Implementing sharelink feature requested in #77 #89

banool · 2018-01-03T01:58:35Z

This is in response to #77.

Following the current command structure for dbxcli, the new command can be found at dbxcli share getlink.

If the file / folder already has a sharelink, that link is retrieved and printed. This follows the pre-existing printing format from the sharing functions. If it doesn't have a sharelink, the link is created and printed.

There is also support for getting links for files that haven't fully uploaded yet. I wanted to functionality to be precisely like if you right click on a file and use Copy Dropbox Link. The side effect of this is I had to use the partially deprecated create_shared_link endpoint.

This is the first Go I've ever coded so I'm of course open to revisions.

diwakergupta · 2018-01-11T06:16:14Z

cmd/share-createlink.go

@@ -0,0 +1,147 @@
+// Copyright © 2017 Dropbox, Inc.
+// Author: Daniel Porteous


For consistency, can you omit this line? git blame can always reveal authors :)

diwakergupta · 2018-01-11T06:18:28Z

cmd/share-createlink.go

+	"github.com/spf13/cobra"
+)
+
+/**


Please use // to start comments. While go does support C style block comments, // is the norm and Javadoc-style comments are rare. More at https://golang.org/doc/effective_go.html#commentary

diwakergupta · 2018-01-11T06:19:20Z

cmd/share-createlink.go

+	// Confirm that the file exists.
+	exists, err := exists(path)
+	if !exists || err != nil {
+		print("The file / folder specified does not exist.\n")


Print the path here as well so users have context

diwakergupta · 2018-01-11T06:19:34Z

cmd/share-createlink.go

+		return
+	}
+
+	// print("File / folder does not yet have a sharelink, creating one...\n")


diwakergupta · 2018-01-11T06:21:47Z

cmd/share-createlink.go

+	fmt.Printf("Usage: %s share getlink [file / folder path]\n", os.Args[0])
+}
+
+/*


Same for comments here and elsewhere, start with //

diwakergupta · 2018-01-11T06:22:53Z

cmd/share-createlink.go

+** Try to get an existing share link for a file / folder.
+** It returns true if the file / folder had a link. Otherwise it returns false.
+ */
+func getExistingLink(dbx sharing.Client, path string) bool {


The name of this function is counter-intuitive, as it doesn't actually return the existing link. Perhaps checkExistingLink?

It doesn't just check the existing link though, it also returns it if it exists. I think checkExistingLinkAndReturnIfExists would be a bit wordy 😉. I can change it regardless if you want.

diwakergupta · 2018-01-11T06:23:37Z

cmd/share-createlink.go

+** CreateSharedLinkWithSettings doesn't allow pending uploads,
+** so we use the partially deprecated CreateSharedLink.
+ */
+func getNewLink(dbx sharing.Client, path string) bool {


Looks like you are using bool to handle errors. Why not return error instead?

Sounds like a good idea, I'll try that.

diwakergupta · 2018-01-11T06:23:52Z

cmd/share-createlink.go

+	// Get the sharelink even if the file isn't fully uploaded yet.
+	arg.PendingUpload = new(sharing.PendingUploadMode)
+	// Determine whether the target is a file or folder.
+	fi, err := os.Stat(path)


You can do this check before creating arg

diwakergupta · 2018-01-11T06:24:55Z

cmd/share-createlink.go

+}
+
+/* Return the path of the Dropbox folder. */
+func getDropboxFolder() string {


This whole function is super hacky and likely not cross-platform. Let me think if there's a better way.

Awesome, thanks. I'll address the other issues now and we can come back to this when you have a solution. There should be a function somewhere that returns where the Dropbox folder is, the information has to be held somewhere.

Given the complexity around obtaining the "canonical" Dropbox folder, for all scenarios (e.g. paid users, paired accounts, custom directories) and for all platforms, I'd prefer if we solve this via documentation and help, and being explicit. For instance, we can ask users to just supply the path instead of trying to prefix things ourselves. WDYT?

banool · 2018-01-11T08:10:59Z

I addressed all of the issues except those related to getDropboxFolder.

coatless · 2018-01-17T02:43:59Z

Any ETA on when this feature can be live?

banool · 2018-01-18T23:25:27Z

@coatless Just waiting on the go ahead from @diwakergupta, as well as perhaps a cleaner way to do the functionality provided by getDropboxFolder.

banool · 2018-02-25T23:36:26Z

@diwakergupta Think you could have another look at this?

coatless · 2018-03-30T01:40:17Z

@banool @diwakergupta it would be great to see headway on this feature as the ~/dropbox.py script listed under Linux Installation appears to be at EOL given:

root@remote:~# ~/dropbox.py status
You're using an old version of Dropbox. Please update within the next 4 days to continue using Dropbox.

https://www.dropbox.com/downloading?from_client=True
Up to date

diwakergupta · 2018-03-30T03:31:02Z

Sorry folks, will take a look right away!

MartinDelille · 2018-09-14T16:56:23Z

@diwakergupta Any update on this PR? I'd love to use this command.

I installed dbxcli only for this purpose because my current workflow is:

open -r myfile
Right click on the file: copy shareable link

MartinDelille · 2018-09-17T15:58:58Z

@banool is there a way to install your version to test it?

cahebert · 2019-10-22T23:28:38Z

Bumping this, I would love to see this feature incorporated into the main branch.

batt · 2019-11-11T10:05:59Z

I would love to have this PR merged too!

vlaminck · 2019-11-15T14:52:41Z

@diwakergupta any update on if this will get merged? It would be really nice to have.

vlaminck · 2019-11-15T19:30:17Z

I know this is super old and seems to not actually be maintained any more, but when I try to go build your branch, I get this error:

./main.go:43:24: cannot use versionCmd (type *"github.com/banool/dbxcli/vendor/github.com/spf13/cobra".Command) as type *"github.com/dropbox/dbxcli/vendor/github.com/spf13/cobra".Command in argument to cmd.RootCmd.AddCommand

coatless · 2019-11-15T19:38:15Z

Sadly, I think this software is official dead. I wouldn't push forward more on this as it literally was a year and then some. Consider looking into Dropbox alternatives.

banool · 2019-11-23T16:50:25Z

Unfortunately yes, I haven't looked into this PR for a long time. I don't intend to pick up the work again either since, as @coatless says, this appears to be entirely dead. Dropbox seems to be more interested in the designer / creative space than the technical space these days, so I don't expect to see any further development on this either. Given the recent price increase and worsening features relative to competitors, might be time to look elsewhere.

vlaminck · 2019-11-23T17:30:04Z

Yeah, I figured that'd be the case. Thanks for the responses.

If anyone finds this in the future, here's a Groovy script that I wrote to accomplish what I needed. https://gitlab.com/snippets/1915960

MartinDelille · 2019-11-23T18:45:23Z

I wanted to give it a look and I manage to make it work!

I rebased the PR (otherwise I had a segmentation fault).

$ dbxcli share getlink ~/Dropbox/Flyers\ Lyon.jpg
2019/11/23 19:38:45 client.go:619: WARNING: API `CreateSharedLink` is deprecated
2019/11/23 19:38:45 client.go:620: Use API `CreateSharedLinkWithSettings` instead
Flyers Lyon.jpg	https://www.dropbox.com/s/1mvz1bhiq7csq1l/Flyers%20Lyon.jpg?dl=0

As you can see, CreateSharedLink is deprecated but it shouldn't be a problem to fix that.

Regarding the output I would remove the file name in order to make the result "pipable":

$ dbxcli share getlink ~/Dropbox/Flyers\ Lyon.jpg | pbcopy

(for non MacOS user, pbcopy copy the input in the clipboard)

biounix · 2020-08-03T09:37:12Z

To anybody interested in that option:

#113 (comment)

CLAassistant · 2022-04-16T21:52:36Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

banool · 2022-04-19T23:47:58Z

I'm unsubscribing from this, please tag me if you need me if the maintainers ever return. Thanks!

MartinDelille · 2022-04-20T10:58:44Z

@banool If you want to get notified, stay subscribed because I don't think I will remember to ping you when it merged (there is not so much activity here anyway).

@biounix I just tried tbx for the first time after having it under my watched repository since you mentioned it. I opened a question here about it.

banool added 6 commits January 2, 2018 21:50

Early partially working functionality for createlink

3e1a8fe

Accept a file path as a createlink argument

6750176

Get a link when it didn't yet exist

909915b

Allow files / folders pending upload

952dece

Revert api key inclusion

7ced6fb

Polish, commentating, renaming

2900a25

banool mentioned this pull request Jan 3, 2018

Request: Add dropbox.py sharelink option #77

Open

diwakergupta requested changes Jan 11, 2018

View reviewed changes

Address issues raised regarding commenting and code structure

d9631e4

coatless mentioned this pull request Jan 17, 2018

Switch from dropbox.py to dbxcli coatless-rpkg/dropcli#5

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementing sharelink feature requested in #77 #89

Implementing sharelink feature requested in #77 #89

banool commented Jan 3, 2018

diwakergupta Jan 11, 2018

diwakergupta Jan 11, 2018

diwakergupta Jan 11, 2018

diwakergupta Jan 11, 2018

diwakergupta Jan 11, 2018

diwakergupta Jan 11, 2018

banool Jan 11, 2018

diwakergupta Jan 11, 2018

banool Jan 11, 2018

diwakergupta Jan 11, 2018

diwakergupta Jan 11, 2018

banool Jan 11, 2018

diwakergupta Mar 30, 2018

banool commented Jan 11, 2018

coatless commented Jan 17, 2018

banool commented Jan 18, 2018

banool commented Feb 25, 2018

coatless commented Mar 30, 2018 •

edited

Loading

diwakergupta commented Mar 30, 2018

MartinDelille commented Sep 14, 2018

MartinDelille commented Sep 17, 2018

cahebert commented Oct 22, 2019

batt commented Nov 11, 2019

vlaminck commented Nov 15, 2019

vlaminck commented Nov 15, 2019

coatless commented Nov 15, 2019

banool commented Nov 23, 2019

vlaminck commented Nov 23, 2019

MartinDelille commented Nov 23, 2019

biounix commented Aug 3, 2020 •

edited

Loading

CLAassistant commented Apr 16, 2022

banool commented Apr 19, 2022

MartinDelille commented Apr 20, 2022

		@@ -0,0 +1,147 @@
		// Copyright © 2017 Dropbox, Inc.
		// Author: Daniel Porteous

Implementing sharelink feature requested in #77 #89

Are you sure you want to change the base?

Implementing sharelink feature requested in #77 #89

Conversation

banool commented Jan 3, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

banool commented Jan 11, 2018

coatless commented Jan 17, 2018

banool commented Jan 18, 2018

banool commented Feb 25, 2018

coatless commented Mar 30, 2018 • edited Loading

diwakergupta commented Mar 30, 2018

MartinDelille commented Sep 14, 2018

MartinDelille commented Sep 17, 2018

cahebert commented Oct 22, 2019

batt commented Nov 11, 2019

vlaminck commented Nov 15, 2019

vlaminck commented Nov 15, 2019

coatless commented Nov 15, 2019

banool commented Nov 23, 2019

vlaminck commented Nov 23, 2019

MartinDelille commented Nov 23, 2019

biounix commented Aug 3, 2020 • edited Loading

CLAassistant commented Apr 16, 2022

banool commented Apr 19, 2022

MartinDelille commented Apr 20, 2022

coatless commented Mar 30, 2018 •

edited

Loading

biounix commented Aug 3, 2020 •

edited

Loading