Simplify static_dict #203
Open
Simplify static_dict #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyurik
force-pushed
the
optimize-static-dict
branch
from
4901706
to
86707ce
Compare
nyurik
force-pushed
the
optimize-static-dict
branch
2 times, most recently
from
5e3f957
to
e115cab
Compare
nyurik
force-pushed
the
optimize-static-dict
branch
from
e115cab
to
aa0a2f8
Compare
* Convert `IsMatch(dict, ...)` into a member method. The original `IsMatch` is marked as deprecated - and we probably can delete it, but it will require a major release due to being a breaking change. So for now, lets keep it, but remove it when releasing a new breaking version * Same for `BrotliFindAllStaticDictionaryMatches` and a few more methods (they were not moved though to allow for easier review) * lots of internal simplifications - like using direct comparisons, using bools, etc
nyurik
force-pushed
the
optimize-static-dict
branch
from
aa0a2f8
to
234313f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsMatch(dict, ...)into a member method. The originalIsMatchis marked as deprecated - and we probably can delete it, but it will require a major release due to being a breaking change. So for now, lets keep it, but remove it when releasing a new breaking versionBrotliFindAllStaticDictionaryMatches