Allow IDPs to be set dynamically by other plugs #16
Conversation
|
|
| def check_idp_id(conn, _opts) do | ||
| def check_idp_id(%Conn{private: %{samly_idp: %IdpData{}}} = conn, _opts), do: conn | ||
|
|
||
| def check_idp_id(conn, _opts), do: conn | ||
| idp_id_from = Application.get_env(:samly, :idp_id_from) |
There was a problem hiding this comment.
How does this line ever return anything but nil ?
idp_id_from = Application.get_env(:samly, :idp_id_from)
There was a problem hiding this comment.
This line exists in the current codebase and is unaffected by this PR.
There was a problem hiding this comment.
@bmuller ya i was just reviewing your PR and i just happen to be reviewing this method. And that line will never actually return the value its trying to access.
The way it says in the README to setup your configs is for example
config :samly, Samly.Provider,
idp_id_from: :path_segment,
So you would need to have that line be
Application.get_env(:samly, Samly.Provider)[:idp_id_from]
There was a problem hiding this comment.
Basically every where in this app it calls Application.get_env() its doing it in conflict with how it says to define it in the README.
I am working on an application that may have many IDP configurations, and they may need to be loaded dynamically. I believe this small modification would enable me to set the IDP configuration dynamically via a plug that runs earlier than Samly.