Add itemized payments #27
Conversation
|
LGTM |
| total_payments = total_amount_paid(payment.email) | ||
| previous_total = total_payments - payment.amount | ||
| total_payments = total_amount_paid_to_project( | ||
| payment.email, new_itemized_payments |
There was a problem hiding this comment.
Going from all payments to only the new ones is a significant change. It introduces the assumption that previous payments you are no longer looking at were already accounted for.
Is there a way to make this work with all previous itemized payments?
There was a problem hiding this comment.
Good call out! So we actually do use all itemized payments when we tally the total amount paid. Inside total_amount_paid_to_project, we combine the sums of existing itemized payments that have already been recorded in the file and these new_itemized_payments.
The reason we have to pass in the new itemized payments is because we haven't actually recorded them yet since we wait until payments have been processed without errors before recording anything (new valuation, renormalized attributions, and now, itemized payments). If we switch to a sqlite database at some point, this issue will be solved. We will be able to write to the itemized payments table within a transaction and query the whole table to get the correct total instead of passing new itemized payments down the chain.
Pull Request Test Coverage Report for Build 5549650281Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 5549650281Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Summary of Changes
Adds the concept of an ItemizedPayment for recording how much of an incoming payment went towards fees (instruments) and how much went to the project (attributions). We need this historical data when calculating the total amount that a person has paid into the project so that we can compare the total amount accurately with the price and the correct investment amount. Only the portion of a payment that went towards the project should count towards price/investment.
Public Domain Dedication
(Why: The freely released, copyright-free work in this repository represents an investment in a better way of doing things called attribution-based economics. Attribution-based economics is based on the simple idea that we gain more by giving more, not by holding on to things that, truly, we could only create because we, in our turn, received from others. As it turns out, an economic system based on attribution -- where those who give more are more empowered -- is significantly more efficient than capitalism while also being stable and fair (unlike capitalism, on both counts), giving it transformative power to elevate the human condition and address the problems that face us today along with a host of others that have been intractable since the beginning. You can help make this a reality by releasing your work in the same way -- freely into the public domain in the simple hope of providing value. Learn more about attribution-based economics at drym.org, tell your friends, do your part.)