Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keywords parameters for slack backend #173

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AntoinePrv
Copy link

I added keywords parameters in the slack backend to enable other parameters from the config, such as the username and the image (Fancier than the Slack Api Tester default name).

I mentioned it in the readme and also corrected: if you use the @ symbol the message is send to a Slack user which is no longer supported by Slack Api (only user ids are supported).

Thanks

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 82.77% when pulling b1a821f on AntoinePrv:slack into 9b5e7d2 on dschep:master.

@MACscr
Copy link

MACscr commented Aug 9, 2019

No luck with this? Having the sender name as "Slack Api Tester" is pretty annoying.

@szpak
Copy link

szpak commented May 3, 2022

That feature would be also useful for me to be able to use different sender icons, depending on the context (e.g. warning vs alert). @dschep Do you plan to accept it (in one way or another) or definitely not and it is required to use a patched version?

@dschep
Copy link
Owner

dschep commented May 11, 2022

i have no issue merging if the merge conflicts were resolved

@szpak
Copy link

szpak commented May 11, 2022

@AntoinePrv It has been some time, but maybe you still use that feature and would like to have it merged upstream (by resolving the conflicts)? :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants