Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AstroNote #214

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

st3fan
Copy link

@st3fan st3fan commented Sep 20, 2020

This patch adds support for AstroNote, which is a small push notifications app for Apple Watch.

I've marked the PR as Draft - I think it is complete but I'd love to hear if @dschep is interested in including this backend and if so, if anything is missing in this patch.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 81.623% when pulling 50f1853 on st3fan:st3fan/astronote into ecfeee9 on dschep:master.

@dschep
Copy link
Owner

dschep commented Sep 21, 2020

Hey @st3fan, this looks good for the most part. However, some time ago, I added the capability for ntfy to load backends from 3rd party modules, my official recomendation is that you publish this as It's own package, such as ntfy-astronote, that way updates to the astronote backend aren't blocked by me making new releases of ntfy. You can check out my ntfy-webpush library for an example of this: https://github.com/dschep/ntfy-webpush

@dschep
Copy link
Owner

dschep commented Sep 21, 2020

note, for discoverability, I'll still gladly accept a PR adding the new backend to the list of backends just as I've added for webpush once you've published your own package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants