Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid tainting the default config #270

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid tainting the default config #270

wants to merge 1 commit into from

Commits on Jan 3, 2024

  1. Avoid tainting the default config 

    When running tests, depending on the order they are discovered, the
default_config can become tainted before the test_default_config test is
run. This causes this test to fail.

Admittedly its likely never an issue when using ntfy as a script. But
its in general a good practice not to direcly use mutable objects as
default values and less flaky tests are easier to handle.
    @theMarix
    theMarix committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    c480047 View commit details
    Browse the repository at this point in the history