Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

Fixed use of old Albert interface - switched to new interface #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yayuniversal
Copy link

Fix for the issue #4. It seems that Albert only want versions for Python extensions in the format "0.x.x", so you'll probably have to review you version scheme.

@dshoreman
Copy link
Owner

dshoreman commented Oct 31, 2021

Hi Lilian, thanks for your PR.

Unfortunately the author of Albert is quite clear that they do not support Open Source Software, so I'm sorry but given the licensing nonsense in albertlauncher/albert#765, I cannot in good faith support it any longer.

The BC breaks he made were deliberate and avoidable (not to mention—like so many other decisions—made against community feedback). If he doesn't want other people to touch his code, I don't see why he should benefit from ours. Especially given the potential legal issues surrounding the GPL removal.

Further, I will not break semantic versioning in this repository purely to abide by some arbitrary rule that didn't exist before: if Albert doesn't work with plugins specifying valid version numbers, that's a bug on their end.

Thanks again for your contribution; I'm sorry your time was wasted. I will archive this repository shortly.
In case you created this PR for Hacktoberfest, I've added the label anyway so it should still count for your tshirt


Alternatives to Albert Launcher (tldr: use Rofi with rofi-translate!)

Moving forward, I would recommend trying out Rofi. It works slightly differently, but solves the same problems and is just as configurable if not moreso. It is also open source (MIT/X11 license) and built by a community, not just one person that reacts harshly to any feedback he gets.

I suggest giving rofi-translate a shot as an alternative for my plugin. While I haven't tested it, the project it's based on is still active and supports several Translation APIs in addition to Google's.

If you must continue to use Albert, try downgrading to an older version. I believe 0.14.x to 0.16.1 should work, but YMMV.


To be absolutely crystal clear should anybody try to distribute this for/with non-GPL Albert versions:

This plugin is GPL code and it—or any version based on it—MUST NOT be included in Albert or bundled with any supporting packages, at any point either now or in the future. It's sad that I have to write this, but here we are.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants