Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return empty dictionary when file has no properties #178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Return empty dictionary when file has no properties #178

wants to merge 1 commit into from

Commits on Apr 30, 2021

  1. Return empty dictionary when file has no properties 

    Fix dsoprea#89: properties method failed when no props defined

When a file has no properties, the xml doesn't contain 'target' and
target_elem is None. To conform to the documentation for properties,
return an empty dict (instead of None).

Test for both no properties and mime type property (writing a binary
file in the simplest way I can find that works in py2 and py3).
    @idbrii
    idbrii committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    9f01114 View commit details
    Browse the repository at this point in the history