Add automatic media job type compatibility and introduce the DataVertical enum #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incjo
changed the title
jzacsh
requested changes
Aug 30, 2022
There was a problem hiding this comment.
LGTM! I left a comment; also optional bit:
up to you, but this is easier to follow as two commits the way you have them, so when you click the merge button in github, consider unticking the "squash" button so that it keeps the commits separated (your commit to automate stuff; your commit to add an enum).
...ity-types-common/src/main/java/org/datatransferproject/types/common/models/DataVertical.java
Show resolved
Hide resolved
jzacsh
previously approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes progress against #1065 by building on top of #1062 by further expanding support for automatically handling media jobs.
It allows not writing dedicated media adapters in cases where the existing photo/video functionality is satisfactory. It also provides automatic interoperability with destinations that only provide a Media adapter.
Main contributions:
MediaToPhotoConversionImporterandMediaToPhotoConversionExporterwith generic versions that can support conversion between any two adapters:AnyToAnyImporterandAnyToAnyExporterMediaExporterDecoratorandMediaImporterDecoratorwhich combine existing photo and video adapters to seamlessly cover the media job type.TransferCompatibilityProviderwhich attempts to build a substitute adapter upon not finding a real one. E.g. when a media job can't find a media importer, it will combine existing photo and video importers to perform the job.DataVerticalenum which replaces the hardcoded type strings like"PHOTOS".Review the commit separately as the
DataVerticalcommit is very monotonic.note: this PR has a lot in it due to #1136 (comment)