bugfix: use correct time; fix brittle unit test #1336
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is fixing a single time-mishandling issue that uncovered two orthogonal problems:
Z
alias (for greenwhich) and offsets (like+00:00
). Gphotos api docs[a] (inlined into the code) shows we use the former, which is what the unit test uses as well.gradle test
behavior, so an out of the boxgit checkout master
had two failing tests for me[b] but not for our github ci/cd.toString()
(in our assertEquals) which relies on your localejava.time.Instant#equals
instead.[a]: https://developers.google.com/photos/library/reference/rest/v1/mediaItems#mediametadata lists
creationTime
as:[b]: local unit test failure looked like this for me (I'm in midwest US):