Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tokensurlauth partial primitive obsession fix #1342

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Tokensurlauth partial primitive obsession fix #1342

merged 3 commits into from
Mar 13, 2024

Commits on Mar 12, 2024

  1. noop(new api) use URI, avoid primitive obsession 

    open the door to let us start moving away from "primitive obsession"
(strings, all strings), which _in turn_ lets us start handling errors
more concisely and int he right places.

this is a prefactor for an upcoming apple-music PR that relies on this
class for oauth token refresh.
    @jzacsh
    jzacsh committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    c3a9447 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. unit test coverage (and TDD-found fix) for URI API

    @jzacsh
    jzacsh committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    ee85442 View commit details
    Browse the repository at this point in the history

  2. test coverage of rebuildWith... API

    @jzacsh
    jzacsh committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    5e351a6 View commit details
    Browse the repository at this point in the history