FIX: Metatag-Edge case fix, resolves #427 #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@manish-lal12 is attempting to deploy a commit to the Dub Team on Vercel. A member of the Team first needs to authorize it. |
|
|
steven-tey
approved these changes
Oct 22, 2024
steven-tey
approved these changes
Oct 22, 2024
|
/award 300 |
|
Awarding manish-lal12: 300 points 🕹️ Well done! Check out your new contribution on oss.gg/manish-lal12 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue of not showing metadata in some edge case websites is because they have blocked bots User-Agent, and while fetching the metadata the user agent is defined as
Dub.co Botin request headers, which are blocked by the host website.The simple solution is to remove the term
botfrom the header which i figured out after debugging for 4 days 😑. @steven-tey . Please review this.Screencast_20241021_133416.mp4