-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autofill: Increase ratio of complete credential saves #5386
base: develop
Are you sure you want to change the base?
Autofill: Increase ratio of complete credential saves #5386
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
internal data class AutofillStoreFormDataJsonRequest( | ||
val credentials: AutofillStoreFormDataCredentialsJsonRequest?, | ||
val trigger: FormSubmissionTriggerType?, | ||
) | ||
|
||
internal data class AutofillStoreFormDataCredentialsJsonRequest( | ||
val username: String?, | ||
val password: String?, | ||
val autogenerated: Boolean = false, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are types specifically for Moshi / JSON parsing, used internally in this class. but we don’t necessarily want the same types returned out of this class
for example, the trigger
is nullable when parsing from JSON, but when returning we also want that non-nullable and defaulting to UNKNOWN
if it couldn’t be parsed from the JSON
9578c3a
to
969ed0e
Compare
b8badc8
to
a36b674
Compare
a36b674
to
16e1970
Compare
Task/Issue URL: https://app.asana.com/0/72649045549333/1206048666874234/f
Description
Increases the ratio of complete credential saves by being able to capture a username-only form submission, and then re-attach it to a nearby password-only form submission. This is useful for scenarios like resetting passwords and multi-step logins.
Steps to test this PR
DRAFT: test sites:
Logcat filter:
message~:"Partial save" message~:"Pixel sent: m_autofill_logins_update_password_inline" message~:"Determined that username" message~:"Determined that username”
Simulating a multi-step login form
test
Login
buttonLogin
button (which is submitting only a password now)View
in snackbar)username=test
and password matches what you provided (i.e., the username was backfilled because the partial form submission’s username was later applied to the final form submission which didn’t have the username)