For third party requests differentiate if they are affiliated with first party #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwaresiak
reviewed
Sep 24, 2024
| let thirdPartyRequest = DetectedRequest(url: trackerUrlString, | ||
| eTLDplus1: requestETLDp1, | ||
| knownTracker: nil, | ||
| entity: entity, | ||
| state: .allowed(reason: .otherThirdPartyRequest), | ||
| state: .allowed(reason: isAffiliated ? .ownedByFirstParty : .otherThirdPartyRequest), |
There was a problem hiding this comment.
Can we have a test for this? I think TrackerResolver is pretty well tested so it would be good to include this case.
There was a problem hiding this comment.
Please mind that the update is not in TrackerResolver (as the request is not matching any tracker definition, and essentially we have a non-tracker third party request that came from affiliated domain).
I will try to extend the ContentBlockerRulesUserScript test where the change is.
There was a problem hiding this comment.
@bwaresiak I have updated the tests to cover this case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/414709148257752/1208376794617030/f
iOS PR: duckduckgo/iOS#3386
macOS PR: duckduckgo/macos-browser#3343
What kind of version bump will this require?: Minor
Description:
When loading a website and some of the allowed third party requests may not be recognized as trackers but by their URL they may belong to the same entity as the website. For that cases we should mark their state as
.allowed(reason: .ownedByFirstParty)(instead of.allowed(reason: .otherThirdPartyRequest)).Steps to test this PR:
See parent task for testing steps.
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template