Add Events Firing for Phishing Detection Settings #1012
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/72649045549333/1208270234071171/f
iOS PR: duckduckgo/iOS#3423
macOS PR: duckduckgo/macos-browser#3379
What kind of version bump will this require?:Minor
Optional:
Tech Design URL: N/A
CC:
Description:
In ✓ Phishing Detection Pixels we defined several pixels to include, and one of them did not make it into the initial release:
Steps to test this PR:
m_mac_phishing_detection_setting-toggled
in the debug output of the app👾[Standard-Fired] m_mac_phishing_detection_setting-toggled ["appVersion": "1.109.0", "pixelSource": "browser-dmg", "setting_toggled_to": "false"]
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template