Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Events Firing for Phishing Detection Settings #1012

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

not-a-rootkit
Copy link
Collaborator

@not-a-rootkit not-a-rootkit commented Oct 9, 2024

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/72649045549333/1208270234071171/f
iOS PR: duckduckgo/iOS#3423
macOS PR: duckduckgo/macos-browser#3379
What kind of version bump will this require?:Minor

Optional:

Tech Design URL: N/A
CC:

Description:
In ✓ Phishing Detection Pixels we defined several pixels to include, and one of them did not make it into the initial release:

  • macos.phishing-detection.feature-toggled:
    • Parameters:
      • newState - on/off, indicating whether the user turned it on or off
  • Condition
    • triggers when a user disables the feature from the settings page
  • Reasoning
    • the aim is to use this as a "do-no-harm" KPI, to determine how many users are actively choosing to disable/enable phishing protection

Steps to test this PR:

  1. Point to tespach/phish-det-settings-event
  2. Build the macOS browser
  3. Filter by m_mac_phishing_detection_setting-toggled in the debug output of the app
  4. Ensure you're authenticated via use-login.duckduckgo.com - this feature is internal only
  5. Go to Settings>General
  6. Toggle "Malicious Site Protection"
  7. Return to debug output and ensure you see:
  8. 👾[Standard-Fired] m_mac_phishing_detection_setting-toggled ["appVersion": "1.109.0", "pixelSource": "browser-dmg", "setting_toggled_to": "false"]

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

Internal references:

Software Engineering Expectations
Technical Design Template

@not-a-rootkit not-a-rootkit marked this pull request as ready for review October 9, 2024 16:19
@not-a-rootkit not-a-rootkit merged commit ffcbeb2 into main Oct 15, 2024
9 checks passed
@not-a-rootkit not-a-rootkit deleted the tespach/phish-det-settings-event branch October 15, 2024 16:14
samsymons added a commit that referenced this pull request Oct 21, 2024
* main:
  Second macOS CPM experiment (#1017)
  fix HStack width (#1022)
  Change tab URL calculation for contentblockerrules.js and surrogates.js (#1021)
  Add Events Firing for Phishing Detection Settings (#1012)
  Sabrina/onboarding UI updates (#1015)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants