Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix HStack width #1022

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix HStack width #1022

merged 1 commit into from
Oct 17, 2024

Conversation

SabrinaTardio
Copy link
Contributor

@SabrinaTardio SabrinaTardio commented Oct 16, 2024 •
edited
Loading

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/1204186595873227/1208559753129621/f
iOS PR: duckduckgo/iOS#3444
macOS PR: duckduckgo/macos-browser#3405
What kind of version bump will this require?: Patch

Optional:

Tech Design URL:
CC:

Description: Fix issue with dax dialog layout

Steps to test this PR:

  1. Start contextual onboarding
  2. Go to Facebook.com and check all copy is displayed
  3. Go to bbc.com and check all copy is displayed

<!—
Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you know do not need explicit testing.

Using a simulator where a physical device is unavailable is acceptable.
—>

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

—

Internal references:

Software Engineering Expectations
Technical Design Template

@SabrinaTardio SabrinaTardio marked this pull request as ready for review October 16, 2024 13:28
@SabrinaTardio SabrinaTardio merged commit 4e9ce77 into main Oct 17, 2024
9 checks passed
@SabrinaTardio SabrinaTardio deleted the sabrina/fix-dialog-width branch October 17, 2024 10:15
samsymons added a commit that referenced this pull request Oct 21, 2024
@samsymons
Merge branch 'main' into dominik/xcode-16
d42b173 
* main:
  Second macOS CPM experiment (#1017)
  fix HStack width (#1022)
  Change tab URL calculation for contentblockerrules.js and surrogates.js (#1021)
  Add Events Firing for Phishing Detection Settings (#1012)
  Sabrina/onboarding UI updates (#1015)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessandroboron alessandroboron alessandroboron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SabrinaTardio @alessandroboron