Allowing users to delete suggestions #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brindy
reviewed
Oct 31, 2024
| private(set) public var localSuggestions: [Suggestion] | ||
| public var topHits: [Suggestion] | ||
| public var duckduckgoSuggestions: [Suggestion] | ||
| public var localSuggestions: [Suggestion] |
There was a problem hiding this comment.
Wouldn't it be better to make this lets instead rather than effectively making this mutable? I should have done that when I made the last changes, sorry.
In the macOS code that is overwriting these it would be better to re-construct the result via the constructor instead.
brindy
requested changes
Oct 31, 2024
|
@brindy, I agree with you, way better now. Ready for another review |
brindy
approved these changes
Nov 1, 2024
samsymons
added a commit
that referenced
this pull request
Nov 3, 2024
* main: Validate VPN errors before re-throwing them (#1054) Allowing users to delete suggestions (#1027) Revert "Bump github.com/1024jp/gzipswift from 6.0.1 to 6.1.0" (#1055) Bump github.com/duckduckgo/privacy-dashboard from 5.3.0 to 7.1.1 (#1046) Bump github.com/duckduckgo/sync_crypto from 0.2.0 to 0.3.0 (#1048) Bump github.com/1024jp/gzipswift from 6.0.1 to 6.1.0 (#1050)
samsymons
added a commit
that referenced
this pull request
Nov 4, 2024
* main: Validate VPN errors before re-throwing them (#1054) Allowing users to delete suggestions (#1027) Revert "Bump github.com/1024jp/gzipswift from 6.0.1 to 6.1.0" (#1055) Bump github.com/duckduckgo/privacy-dashboard from 5.3.0 to 7.1.1 (#1046) Bump github.com/duckduckgo/sync_crypto from 0.2.0 to 0.3.0 (#1048) Bump github.com/1024jp/gzipswift from 6.0.1 to 6.1.0 (#1050) Update to subscription cookie (#1053) Bug Fix: Phishing Detection Dataset Discrepancies (#1032) Include www.youtube.com as Youtube host (#1028) Ignore GRDB (#1052) Connect refactored update flow to the new release notes page (#1025) Add to Dock - Add extra custom view to Contextual Dialog Content (#1043) Dependabot for BSK (#1045) Update autofill to 15.1.0 (#1044)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1148564399326804/1208219569168397/f
iOS PR: duckduckgo/iOS#3465
macOS PR: duckduckgo/macos-browser#3430
What kind of version bump will this require?: Minor
Optional:
Description:
Improvements of the HistoryCoordinator to allow users to delete individual suggestions
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template