Update breakage report locale to JSON format #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
reviewed
Jul 19, 2024
samsymons
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
LGTM, I also confirmed via this comment that using a hyphen instead of underscore is the correct behaviour.
samsymons
reviewed
Jul 19, 2024
samsymons
added a commit
that referenced
this pull request
Jul 25, 2024
* main: Moves evaluateJS methods to main thread (#908) Bumped C-S-S to 6.4.0 (#910) Don't show key icon for empty passwords (#890) Hotfix: fix index out-of-bounds in startAttachingCrashLogMessages (#906) Add support for additionalCampaignPixelParams (#899) Update breakage report locale to JSON format (#905) Add support for additionalCampaignPixelParams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/414235014887631/1207857268320366/f
iOS PR: duckduckgo/iOS#3112
macOS PR: duckduckgo/macos-browser#3000
What kind of version bump will this require?: Major/Minor/Patch
Optional:
Tech Design URL:
CC:
Description:
Steps to test this PR:
en-USformatOS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template