Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Enable Broken Site Toast on iOS #946

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Re-Enable Broken Site Toast on iOS #946

merged 3 commits into from
Aug 22, 2024

Conversation

SlayterDev
Copy link
Contributor

@SlayterDev SlayterDev commented Aug 15, 2024

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/1163321984198618/1207889813347127/f
iOS PR: duckduckgo/iOS#3244
macOS PR: duckduckgo/macos-browser#3108
What kind of version bump will this require?: Minor

Optional:

Tech Design URL:
CC:

Description:
This PR adds the prompt entry point back to BSK for the broken site report.

Steps to test this PR:

  1. See iOS PR

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

Internal references:

Software Engineering Expectations
Technical Design Template

@SlayterDev SlayterDev self-assigned this Aug 15, 2024
@SlayterDev SlayterDev marked this pull request as ready for review August 15, 2024 15:26
@SlayterDev SlayterDev merged commit 8b62a82 into main Aug 22, 2024
7 checks passed
@SlayterDev SlayterDev deleted the brad/reenable-prompt branch August 22, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants