Alesab/onboarding #964
Merged
Alesab/onboarding #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SabrinaTardio
force-pushed
the
alesab/onboarding
branch
from
62c3a2f
to
3317212
Compare
| @@ -397,6 +397,9 @@ let package = Package( | |||
| dependencies: [ | |||
| "BrowserServicesKit" | |||
| ], | |||
| resources: [ | |||
| .process("Resources") | |||
There was a problem hiding this comment.
That’s interesting, according to Apple this shouldn’t be needed 🤔
When you add a resource to your Swift package, Xcode detects common resource types for Apple platforms and treats them as a resource automatically. For example, you don’t need to make changes to your package manifest for the following resources:
Interface Builder files; for example, XIB files and storyboards
Core Data files; for example, xcdatamodeld files
Asset catalogs
.lproj folders you use to provide localized resources
If you add a resource file that Xcode doesn’t treat as a resource by default, you must configure it in your package manifest, as described in the next section.
There was a problem hiding this comment.
Yeah… apparently macOS does not like it without 🥲
alessandroboron
approved these changes
Aug 28, 2024
This reverts commit bcf3c1c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1204186595873227/1208077416568671/f
iOS PR: duckduckgo/iOS#3282
macOS PR: duckduckgo/macos-browser#3149
What kind of version bump will this require?: Minor
Optional:
Tech Design URL: https://app.asana.com/0/481882893211075/1208094950223874/f
Description: Extracts code from the onboarding that can be used by macOS as well
Steps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template