Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote feature flag for New Tab Page Improvements #969

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Remote feature flag for New Tab Page Improvements #969

merged 2 commits into from
Sep 2, 2024

Conversation

dus7
Copy link
Contributor

@dus7 dus7 commented Aug 30, 2024 •
edited
Loading

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/72649045549333/1207539163549338/f
iOS PR: duckduckgo/iOS#3294
macOS PR: duckduckgo/macos-browser#3176
What kind of version bump will this require?: Minor

Optional:

Tech Design URL:
CC:

Description:

Adds a remote feature to control availability of New Tab Page Improvements.

Steps to test this PR:
See duckduckgo/iOS#3294.

Internal references:

Software Engineering Expectations
Technical Design Template

@dus7 dus7 self-assigned this Aug 30, 2024
@dus7 dus7 marked this pull request as ready for review August 30, 2024 10:00
@dus7 dus7 requested a review from brindy August 30, 2024 10:01
brindy
brindy approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dus7 dus7 merged commit afdab42 into main Sep 2, 2024
7 checks passed
@dus7 dus7 deleted the mariusz/ntp-flag branch September 2, 2024 16:46
samsymons added a commit that referenced this pull request Sep 9, 2024
@samsymons
Merge branch 'main' into sam/set-vpn-user-agent
ee3f70e 
* main:
  Bump C-S-S to 6.14.1 (#977)
  Bump C-S-S to 6.14.0 (#973)
  Remote feature flag for New Tab Page Improvements (#969)
  Adds new Autofill unknownUsernameCategorization feature flag (#968)
  Fix site owned by major network (#966)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brindy brindy brindy approved these changes

Assignees

@dus7 dus7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dus7 @brindy