Remove VPN feature flag checks #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
commented
Sep 8, 2024
samsymons
commented
Sep 8, 2024
Sources/NetworkProtection/FeatureActivation/NetworkProtectionCodeRedemptionCoordinator.swift
Outdated
Show resolved
Hide resolved
samsymons
commented
Sep 8, 2024
Sources/NetworkProtection/KeyManagement/NetworkProtectionTokenStore.swift
Show resolved
Hide resolved
quanganhdo
approved these changes
Sep 13, 2024
* main: Revert "C.S.S Patch Privacy Config on C.S.S for "internal" support in… (#995) C.S.S Patch Privacy Config on C.S.S for "internal" support in DuckPlayer (#994) return urls on burn domains (#992) Update survey builder OS version (#984) Add feature flag for SKAN API (#993) [DuckPlayer] Add feature flag and update C.S.S (#983) Update Onboarding gradients (#985) Fix WKDownload cancellation under Xcode 16 (#986) Add shouldCheckServerTrust flag (#982) Promote password import in autofill menu (#976) Add Phishing Detection Feature (#981) Revert "Add Phishing Detection Package" (#980) Add Phishing Detection Package (#935) Update VPN user agent (#971) New feature flag for autofillSurveys (#974)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/414235014887631/1208254974939835/f
iOS PR: duckduckgo/iOS#3334
macOS PR: duckduckgo/macos-browser#3232
What kind of version bump will this require?: Major
Description:
This PR cleans up VPN feature flag checks.
Steps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template