C.S.S Patch Privacy Config on C.S.S for "internal" support in DuckPlayer #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 13, 2024
shakyShane
approved these changes
Sep 13, 2024
Bunn
approved these changes
Sep 13, 2024
afterxleep
added a commit
to duckduckgo/iOS
that referenced
this pull request
Sep 13, 2024
Task/Issue URL: https://app.asana.com/0/1204099484721401/1208292211771741/f BSK PR: duckduckgo/BrowserServicesKit#994 Description: We want all internal users enrolled in the experiment Update in BSK to patch Privacy Config, so 'internal' is translated to 'enabled' when privacyConfig is passed to the FE
samsymons
added a commit
that referenced
this pull request
Sep 13, 2024
* main: Revert "C.S.S Patch Privacy Config on C.S.S for "internal" support in… (#995) C.S.S Patch Privacy Config on C.S.S for "internal" support in DuckPlayer (#994) return urls on burn domains (#992) Update survey builder OS version (#984) Add feature flag for SKAN API (#993) [DuckPlayer] Add feature flag and update C.S.S (#983) Update Onboarding gradients (#985) Fix WKDownload cancellation under Xcode 16 (#986) Add shouldCheckServerTrust flag (#982) Promote password import in autofill menu (#976) Add Phishing Detection Feature (#981) Revert "Add Phishing Detection Package" (#980) Add Phishing Detection Package (#935) Update VPN user agent (#971) New feature flag for autofillSurveys (#974)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204099484721401/1208292211771741/f
iOS PR: duckduckgo/iOS#3359
macOS PR: duckduckgo/macos-browser#3272
What kind of version bump will this require?: Minor
Description:
The Frontend does not support "internal" state for features, so in order to release
DuckPlayer to internal users, we need to patch the Privacy Config to replace "internal" with "enabled"
This will be removed once DuckPlayer is released to the public
Testing