Skip to content

Commit

Permalink
Delegate new tab creation to WebView (#3746)
Browse files Browse the repository at this point in the history
<!--
Note: This checklist is a reminder of our shared engineering
expectations. Feel free to change it, although assigning a GitHub
reviewer and the items in bold are required.

⚠️ If you're an external contributor, please file an issue first before
working on a PR, as we can't guarantee that we will accept your changes
if they haven't been discussed ahead of time. Thanks!
-->

Task/Issue URL:
https://app.asana.com/0/856498667320406/1208699273169079/f
Tech Design URL:
CC:

**Description**:

Delegate new tab creation to WebView.

<!--
If at any point it isn't actively being worked on/ready for
review/otherwise moving forward strongly consider closing it (or not
opening it in the first place). If you decide not to close it, use Draft
PR while work is still in progress or use `DO NOT MERGE` label to
clarify the PRs state and comment with more information.
-->

**Steps to test this PR**:
1. Navigate to
https://privacy-test-pages.site/privacy-protections/referrer-trimming/
2. Check for referrer and how tabs behave.

<!--
Before submitting a PR, please ensure you have tested the combinations
you expect the reviewer to test, then delete configurations you *know*
do not need explicit testing.

Using a simulator where a physical device is unavailable is acceptable.
-->

**Definition of Done (Internal Only)**:

* [ ] Does this PR satisfy our [Definition of
Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)?

**Device Testing**:

* [ ] iPhone 
* [ ] iPad

**OS Testing**:

* [ ] iOS 15
* [ ] iOS 16
* [ ] iOS 17
* [ ] iOS 18

---
###### Internal references:
[Software Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design
Template](https://app.asana.com/0/59792373528535/184709971311943)
  • Loading branch information
bwaresiak authored Dec 20, 2024
1 parent 9415d44 commit 26699be
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions DuckDuckGo/TabViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -2032,8 +2032,8 @@ extension TabViewController: WKNavigationDelegate {
}

if isNewTargetBlankRequest(navigationAction: navigationAction) {
delegate?.tab(self, didRequestNewTabForUrl: url, openedByPage: true, inheritingAttribution: adClickAttributionLogic.state)
completion(.cancel)
// This will fallback to native WebView handling through webView(_:createWebViewWith:for:windowFeatures:)
completion(allowPolicy)
return
}

Expand Down

0 comments on commit 26699be

Please sign in to comment.