Skip to content

Commit

Permalink
remove references to obsolete FBConfig (#3297)
Browse files Browse the repository at this point in the history
<!--
Note: This checklist is a reminder of our shared engineering
expectations. Feel free to change it, although assigning a GitHub
reviewer and the items in bold are required.

⚠️ If you're an external contributor, please file an issue first before
working on a PR, as we can't guarantee that we will accept your changes
if they haven't been discussed ahead of time. Thanks!
-->

Task/Issue URL:
https://app.asana.com/0/1171671347221384/1208194339440141/f
Tech Design URL:
CC:

**Description**: Remove all references to the obsolete FBConfig file,
which has been replaced by the shared privacy config.

<!--
If at any point it isn't actively being worked on/ready for
review/otherwise moving forward strongly consider closing it (or not
opening it in the first place). If you decide not to close it, use Draft
PR while work is still in progress or use `DO NOT MERGE` label to
clarify the PRs state and comment with more information.
-->

**Steps to test this PR**:
1.
2.

<!--
Before submitting a PR, please ensure you have tested the combinations
you expect the reviewer to test, then delete configurations you *know*
do not need explicit testing.

Using a simulator where a physical device is unavailable is acceptable.
-->

**Definition of Done (Internal Only)**:

* [ ] Does this PR satisfy our [Definition of
Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)?

**Copy Testing**:

* [ ] Use of correct apostrophes in new copy, ie `’` rather than `'`

**Orientation Testing**:

* [ ] Portrait
* [ ] Landscape

**Device Testing**:

* [ ] iPhone SE (1st Gen)
* [ ] iPhone 8
* [ ] iPhone X
* [ ] iPhone 14 Pro
* [ ] iPad

**OS Testing**:

* [ ] iOS 15
* [ ] iOS 16
* [ ] iOS 17

**Theme Testing**:

* [ ] Light theme
* [ ] Dark theme

---
###### Internal references:
[Software Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design
Template](https://app.asana.com/0/59792373528535/184709971311943)
  • Loading branch information
ladamski authored Aug 30, 2024
1 parent 79ea8b4 commit 46bd8e2
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 7 deletions.
1 change: 0 additions & 1 deletion Core/AppConfigurationURLProvider.swift
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ struct AppConfigurationURLProvider: ConfigurationURLProviding {
case .privacyConfiguration: return URL.privacyConfig
case .trackerDataSet: return URL.trackerDataSet
case .surrogates: return URL.surrogates
case .FBConfig: fatalError("This feature is not supported on iOS")
case .remoteMessagingConfig: return RemoteMessagingClient.Constants.endpoint
}
}
Expand Down
1 change: 0 additions & 1 deletion Core/Configuration.swift
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ public extension Configuration {
case .privacyConfiguration: return "privacyConfiguration"
case .surrogates: return "surrogates"
case .trackerDataSet: return "trackerDataSet"
case .FBConfig: return "FBConfig"
case .remoteMessagingConfig: return "remoteMessagingConfig"
}
}
Expand Down
2 changes: 1 addition & 1 deletion DuckDuckGo.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -10650,7 +10650,7 @@
repositoryURL = "https://github.com/DuckDuckGo/BrowserServicesKit";
requirement = {
kind = exactVersion;
version = 190.0.0;
version = 190.0.1;
};
};
9F8FE9472BAE50E50071E372 /* XCRemoteSwiftPackageReference "lottie-spm" */ = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/DuckDuckGo/BrowserServicesKit",
"state" : {
"revision" : "ac53011582abcca4aefd66f15308332273eecb49",
"version" : "190.0.0"
"revision" : "245750c9ca559813307641e819fb27c6d294339f",
"version" : "190.0.1"
}
},
{
Expand Down
2 changes: 0 additions & 2 deletions DuckDuckGo/ConfigurationURLDebugViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@ struct CustomConfigurationURLProvider: ConfigurationURLProviding {
var customPrivacyConfigurationURL: URL?
var customTrackerDataSetURL: URL?
var customSurrogatesURL: URL?
var customFBConfigURL: URL?
var customRemoteMessagingConfigURL: URL?

let defaultProvider = AppConfigurationURLProvider()
Expand All @@ -194,7 +193,6 @@ struct CustomConfigurationURLProvider: ConfigurationURLProviding {
case .privacyConfiguration: customURL = customPrivacyConfigurationURL
case .trackerDataSet: customURL = customTrackerDataSetURL
case .surrogates: customURL = customSurrogatesURL
case .FBConfig: customURL = nil
case .remoteMessagingConfig: customURL = customRemoteMessagingConfigURL
}
return customURL ?? defaultURL
Expand Down

0 comments on commit 46bd8e2

Please sign in to comment.