Skip to content

Commit

Permalink
Allowing users to delete suggestions on macOS (#3465)
Browse files Browse the repository at this point in the history
Task/Issue URL: https://app.asana.com/0/1148564399326804/1208219569168397/f
Tech Design URL:
CC:

Description:
This change is not related to iOS. We are adding and option to delete suggestions on macOS.
  • Loading branch information
tomasstrba authored Nov 3, 2024
1 parent a90fae0 commit 8c33793
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 7 deletions.
4 changes: 4 additions & 0 deletions Core/HistoryManager.swift
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,10 @@ class NullHistoryCoordinator: HistoryCoordinating {
completion()
}

func removeUrlEntry(_ url: URL, completion: (((any Error)?) -> Void)?) {
completion?(nil)
}

}

public class HistoryDatabase {
Expand Down
2 changes: 1 addition & 1 deletion DuckDuckGo.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -10970,7 +10970,7 @@
repositoryURL = "https://github.com/DuckDuckGo/BrowserServicesKit";
requirement = {
kind = exactVersion;
version = 202.3.0;
version = 202.4.0;
};
};
9F8FE9472BAE50E50071E372 /* XCRemoteSwiftPackageReference "lottie-spm" */ = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/DuckDuckGo/BrowserServicesKit",
"state" : {
"revision" : "7b78b46340c9981b9774352be08c3c28b3a19011",
"version" : "202.3.0"
"revision" : "80894bf69fe789e41b13f3de6be97f1300ca56e5",
"version" : "202.4.0"
}
},
{
Expand Down Expand Up @@ -122,8 +122,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/duckduckgo/privacy-dashboard",
"state" : {
"revision" : "9de2b2aa317a48d3ee31116dc15b0feeb2cc9414",
"version" : "5.3.0"
"revision" : "53fd1a0f8d91fcf475d9220f810141007300dffd",
"version" : "7.1.1"
}
},
{
Expand Down Expand Up @@ -176,8 +176,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/duckduckgo/sync_crypto",
"state" : {
"revision" : "2ab6ab6f0f96b259c14c2de3fc948935fc16ac78",
"version" : "0.2.0"
"revision" : "0c8bf3c0e75591bc366407b9d7a73a9fcfc7736f",
"version" : "0.3.0"
}
},
{
Expand Down

0 comments on commit 8c33793

Please sign in to comment.