Implement barebones NetP UI #1840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graeme
commented
Jul 18, 2023
graeme
commented
Jul 18, 2023
graeme
commented
Jul 18, 2023
| } | ||
|
|
||
| @MainActor | ||
| func clear() async { |
There was a problem hiding this comment.
Only for testing while still behind a feature flag. In the final implementation, this will be moved to an item in the Debug menu
graeme
commented
Jul 18, 2023
|
This currently depends on #1837 to allow it to full function according to the test steps. |
graeme
force-pushed
the
graeme/implement-barebones-netp-ui
branch
from
30d9de4
to
7d98062
Compare
graeme
changed the base branch from
develop
to
diego/remove-distributed-notification-code-from-netp-bsk
graeme
force-pushed
the
graeme/implement-barebones-netp-ui
branch
from
7d98062
to
30d9de4
Compare
graeme
changed the base branch from
diego/remove-distributed-notification-code-from-netp-bsk
to
develop
samsymons
reviewed
Jul 19, 2023
| HStack { | ||
| if let status = statusModel.statusMessage { | ||
| Text(status) | ||
| .foregroundColor(statusModel.isNetPEnabled ? .green : .red) |
There was a problem hiding this comment.
Note to anyone else reviewing this: this is a dev UI that we're using for NetP, the next project will build the final UI and will be using DRK rather than hardcoded colours.
graeme
commented
Jul 19, 2023
| @@ -608,7 +608,6 @@ In addition to the details entered into this form, your app issue report will co | |||
| // MARK: Network Protection | |||
|
|
|||
| public static let netPNavTitle = NSLocalizedString("netP.title", value: "Network Protection", comment: "Title for the Network Protection feature") | |||
| public static let netPCellDetail = NSLocalizedString("netP.cell.detail", value: "Hide your location and conceal your online activity", comment: "Detail string describing what NetP is") | |||
There was a problem hiding this comment.
As discussed offline: this will not go into the final feature so does not need to be translated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205045707803898/f
Description:
This will be the final PR of the iOS: Update NetworkProtection package to support iOS project. It provides the absolute minimum UI required to be able to test the operation of the NetworkProtectionPacketTunnelProvider and related components on iOS.
Note that the UI here is very much temporary, behind feature flags and will be almost entirely replaced in iOS: MVP TestFlight Build.
Steps to test this PR:
PacketTunnelProviderextension in theDuckDuckGoapp target’s build phases.<!—
Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you know do not need explicit testing.
Using a simulator where a physical device is unavailable is acceptable.
—>
Copy Testing:
’rather than’Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
—
Internal references:
Software Engineering Expectations
Technical Design Template