Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSK update: KS #1891

Merged
merged 5 commits into from
Aug 4, 2023
Merged

BSK update: KS #1891

merged 5 commits into from
Aug 4, 2023

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Aug 2, 2023

Task/Issue URL: https://app.asana.com/0/72649045549333/1204311881295998/f
BSK PR: duckduckgo/BrowserServicesKit#438
macOS PR: duckduckgo/macos-browser#1408

Description:

Steps to test this PR:

  1. Validate NetP works

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@graeme graeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and all is now good 👍

mallexxx added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Aug 4, 2023
@mallexxx mallexxx merged commit f9b22ae into develop Aug 4, 2023
6 of 7 checks passed
@mallexxx mallexxx deleted the alex/kill-switch branch August 4, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants