Remove NewTabPage retain cycles #3532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dus7
force-pushed
the
mariusz/ntp-leaking
branch
from
aaf9a9b
to
51b5173
Compare
samsymons
approved these changes
Nov 4, 2024
samsymons
added a commit
that referenced
this pull request
Nov 5, 2024
# By Daniel Bernal (7) and others # Via Daniel Bernal (3) and others * main: (29 commits) Send pixel on sync secure storage failure (#3542) Onboarding Add to Dock Refactor for Intro scenario (#3538) Update C-S-S to 6.29.0 (#3541) Change save password Never for Site button to Not Now (#3471) Release 7.144.0-1 (#3540) UserDefaults misbehavior monitoring (#3510) Send pixel on sync secure storage read failure (#3530) Remove NewTabPage retain cycles (#3532) Update release notes (#3529) Release 7.144.0-0 (#3528) Add Privacy Config feature to control ad attribution reporting (#3506) Validate VPN errors before re-throwing them (#3513) Allowing users to delete suggestions on macOS (#3465) Update build number Update build number Bump rexml from 3.3.8 to 3.3.9 (#3495) Release 7.142.1-1 (#3525) Add a debouncer to NavBars animator (#3519) Release 7.143.0-1 (#3516) Update to subscription cookie (#3512) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Nov 6, 2024
…tatus # By Graeme Arthur (4) and others # Via GitHub (1) and Graeme Arthur (1) * main: Adding app backgrounded result to rule compilation (#3533) Send pixel on sync secure storage failure (#3542) Onboarding Add to Dock Refactor for Intro scenario (#3538) Update C-S-S to 6.29.0 (#3541) Change save password Never for Site button to Not Now (#3471) Release 7.144.0-1 (#3540) UserDefaults misbehavior monitoring (#3510) Send pixel on sync secure storage read failure (#3530) Remove NewTabPage retain cycles (#3532) Update release notes (#3529) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206226850447395/1208686031091434/f
Tech Design URL:
CC:
Description:
Leak 1:
NewTabPageViewControllerwas not dismissed properly, this caused it to stay in memory as a child view controller ofMainViewController.In effect it was possible to dismiss FaviconFetcherTutorial. Removing the leak required to do additional changes to make it work. I moved it to
MainViewController, so that it's not dependent on NewTabPage.Leak 2:
NewTabPageSettingsModelwas leaking via strong reference present inNTPSettingItem.Steps to test this PR:
NewTabPageViewControllerandNewTabPageSettingsModel*objects.Definition of Done (Internal Only):
Internal references:
Software Engineering Expectations
Technical Design Template