Update BSK for PixelKit suffix change #3534
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
federicocappelli
approved these changes
Nov 5, 2024
samsymons
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Nov 6, 2024
Required: Task/Issue URL: https://app.asana.com/0/0/1208695427490034/f iOS PR: duckduckgo/iOS#3534 macOS PR: duckduckgo/macos-browser#3509 What kind of version bump will this require?: Major Description: This PR renames the existing dailyAndCount PixelKit type to legacyDailyAndCount. A new dailyAndCount case has been added, but it uses new suffixes.
…tatus # By Graeme Arthur (4) and others # Via GitHub (1) and Graeme Arthur (1) * main: Adding app backgrounded result to rule compilation (#3533) Send pixel on sync secure storage failure (#3542) Onboarding Add to Dock Refactor for Intro scenario (#3538) Update C-S-S to 6.29.0 (#3541) Change save password Never for Site button to Not Now (#3471) Release 7.144.0-1 (#3540) UserDefaults misbehavior monitoring (#3510) Send pixel on sync secure storage read failure (#3530) Remove NewTabPage retain cycles (#3532) Update release notes (#3529) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
deleted the
sam/migrate-daily-and-count-type-to-legacy-status
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1208695427490034/f
Tech Design URL:
CC:
Description:
This PR updates BSK for the PixelKit suffix change.
iOS doesn't use PixelKit yet, so it's not affected.
Steps to test this PR:
Definition of Done (Internal Only):
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template