Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding Add To Dock Pixels #3543

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

alessandroboron
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/72649045549333/1208590665790272/f

Description:

Add pixels for "Add To Dock" experiment.

Steps to test this PR:
Prerequisites:

  1. Ensure that isOnboardingHighlightsEnabled returns true in OnboardingManager.
  2. Add return VariantIOS(name: "mx", weight: 1, isIncluded: VariantIOS.When.always, features: [.newOnboardingIntroHighlights, .contextualDaxDialogs]) in DefaultVariantManager -> selectVariant() at line 156.

Scenario 1 - Add to Dock is presented from linear onboarding

  1. Ensure that addToDockEnabledState returns .intro in OnboardingManager.
  2. Launch the App.
  3. Wait for the Add to Dock Promo screen is presented.
  4. Ensure that “m_onboarding_add_to_dock_promo_impressions_unique” is fired.
  5. Tap “Skip” button and ensure that “m_onboarding_add_to_dock_promo_dismiss_button_tapped” is fired.

Repeat the test and when Add to Dock Promo screen is presented:

  1. Tap the “Show me how” button and ensure that “m_onboarding_add_to_dock_promo_show_tutorial_button_tapped” is fired.
  2. Tap the “Got It” button and ensure that “m_onboarding_add_to_dock_tutorial_dismiss_button_tapped” is fired.

Scenario 2 - Add to Dock is presented from contextual onboarding

  1. Ensure that addToDockEnabledState returns .contextual in OnboardingManager.
  2. Launch the App.
  3. Complete the contextual onboarding till the end of journey dialog.
  4. Ensure that “m_onboarding_add_to_dock_promo_impressions_unique” is fired.
  5. Tap the “Start Browsing” button and ensure that “m_onboarding_add_to_dock_promo_dismiss_button_tapped” is fired.

Repeat the test and when Add to Dock Promo contextual dialog is presented:

  1. Tap the “Show me how” button and ensure that “m_onboarding_add_to_dock_promo_show_tutorial_button_tapped” is fired.
  2. Tap the “Start Browsing” button and ensure that “m_onboarding_add_to_dock_tutorial_dismiss_button_tapped” is fired.

Repeat the test and instead of showing the End of journey dialog from NTP, show it from contextual dialog.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant