Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1208590665790272/f
Description:
Add pixels for "Add To Dock" experiment.
Steps to test this PR:
Prerequisites:
isOnboardingHighlightsEnabled
returnstrue
in OnboardingManager.return VariantIOS(name: "mx", weight: 1, isIncluded: VariantIOS.When.always, features: [.newOnboardingIntroHighlights, .contextualDaxDialogs])
inDefaultVariantManager
->selectVariant()
at line 156.Scenario 1 - Add to Dock is presented from linear onboarding
addToDockEnabledState
returns.intro
in OnboardingManager.Repeat the test and when Add to Dock Promo screen is presented:
Scenario 2 - Add to Dock is presented from contextual onboarding
addToDockEnabledState
returns.contextual
in OnboardingManager.Repeat the test and when Add to Dock Promo contextual dialog is presented:
Repeat the test and instead of showing the End of journey dialog from NTP, show it from contextual dialog.
Definition of Done (Internal Only):
Copy Testing:
’
rather than’
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
—
Internal references:
Software Engineering Expectations
Technical Design Template